wait_event_interruptible

7.e.Q · 11-04-2004, 03:20 AM

Hello,

I need your help. GCC gives me the errormessage

Code:

invalid lvalue in unary `&'

inside this function:

Code:

static int dpn_stop(struct net_device *dev)
{
	init_waitqueue_head(&dpn_wq_term);

	ioctl_disable_vme_int(3+(sgd->ctrl.un.diu_switch & 3));
	free_irq(sgd->ctrl.un.irq, 0);

	cli();
	dpn_run = 0;
	wait_event_interruptible(&dpn_wq_term, dpn_run == 0);

	return 0;
}

at the line with wait_event_interruptible... We can't find the mistake we made. What did we do wrong regarding syntax?

We are translating a driver from an old Linux Kernel 2.2.14 to the new architecture of the Kernel 2.6. And this is one of the problems we run into.

Thanks a lot

Hendrik

rjlee · 11-04-2004, 04:13 AM

The problem is probably with the way you're using dpn_wq_term, which you have not defined in the above snippet.

I tried googling for wait_event_interruptible as I can't remember the syntax off-hand (I must get back into kernel hacking!) but I couldn't find anywhere that used an ampusand in the first parameter, so you might try ignoring it.

That's about as much help as I can give without seeing the declarations.

7.e.Q · 11-04-2004, 04:21 AM

dpn_wq_term is defined globally. We use it inside several functions. Is this the problem?

rjlee · 11-05-2004, 01:00 PM

It's quite normal to use global variables inside kernel modules. The question is what kind of variable is it?

As a thought, you may want to remove the ampusand (&) from the call to the macro; the macro may well be inserting one itself.

7.e.Q · 11-08-2004, 02:00 AM

Well, I removed the '&' and now it translates... Who can read is clearly in the advantage:

Code:

error: invalid lvalue in unary `&'