bad exit code when slackpkg does not find named packages

mcandre · 01-06-2019, 10:56 AM

slackpkg should return a nonzero exit code when the named packages are unavailable. This helps communicate error information to downstream systems, such as automation scripts and continuous integration servers and Docker builds, so that we can detect problems earlier.

rworkman · 01-16-2019, 12:23 AM

Quote:

Originally Posted by mcandre

slackpkg should return a nonzero exit code when the named packages are unavailable. This helps communicate error information to downstream systems, such as automation scripts and continuous integration servers and Docker builds, so that we can detect problems earlier.

Code:

commit c7216fb599374fee9833967e8a18d25e1348c4ba (origin/master)
Author: Robby Workman <rworkman@slackware.com>
Date:   Wed Jan 16 00:15:57 2019 -0600

    Catch errors and return exit status 1 if they occur
    
    Thanks to mcandre on LQ for the suggestion.

diff --git a/files/core-functions.sh b/files/core-functions.sh
index 19eebf3..fa02653 100644
--- a/files/core-functions.sh
+++ b/files/core-functions.sh
@@ -7,8 +7,10 @@
 # Clean-up tmp and lock files
 #
 function cleanup() {
+       local retval=0
        [ "$SPINNING" = "off" ] || tput cnorm
        if [ -e $TMPDIR/error.log ]; then
+               retval=1
                echo -e "         
 \n==============================================================================
 WARNING!        WARNING!        WARNING!        WARNING!        WARNING!
@@ -24,7 +26,7 @@ One or more errors occurred while slackpkg was running:
                rm $CACHEPATH/$NAMEPKG &>/dev/null
        fi              
        ( rm -f /var/lock/slackpkg.$$ && rm -rf $TMPDIR ) &>/dev/null
-       exit
+       exit ${retval}
 }
 trap 'cleanup' 2 14 15                 # trap CTRL+C and kill