tor.pid file missing after reboot on Slackware Current

MasterZ80 · 10-18-2020, 11:55 AM

Hi folks,

I'm wondering if anyone is facing this. I compile Tor from Slackbuilds.org on Slackware current, Tor works fine until reboot the system, the PID file always disappears (and the /var/run/tor directory too). Trying to launch rundeck I see the following error on /var/log/tor/tor.log:

Code:

Oct 17 12:20:52.000 [warn] Unable to open "/var/run/tor/tor.pid" for writing: No such file or directory
Oct 17 12:20:52.000 [err] Unable to write PIDFile "/var/run/tor/tor.pid"

So, as a dirty workaround, I created the file before start Tor on rc.local init script "manually" in the following way:

Code:

# Tor.
if [ -x /etc/rc.d/rc.tor ]; then
	# slackware current pid workaround.
	if [ ! -f /var/run/tor/tor.pid ]; then
		mkdir /var/run/tor
		touch /var/run/tor/tor.pid
		chown -R tor:tor /var/run/tor/
	fi

	# now start tor
    /etc/rc.d/rc.tor start
fi

This works OK but it's just a workaround, would be ideal that works without this manual file creation. Any thoughts about this?

Thanks in advance.

mumahendras3 · 10-18-2020, 02:41 PM

I don't use Tor, but I don't think you actually need to create the tor.pid file. You probably only need to create the /var/run/tor directory so that Tor can write its pid file inside /var/run/tor directory. Also, It's normal that the pid file is gone when you reboot since it's only used to stop Tor process by using its PID written inside that pid file. I think the Tor slackbuild mantainer need to add a mkdir command inside the rc.tor script before starting the main Tor process.

PROBLEMCHYLD · 10-18-2020, 04:32 PM

You have to add it in your torrc file like

PidFile /var/run/tor/tor.pid

MasterZ80 · 10-18-2020, 05:22 PM

Thanks for the help! Another way is to add the following code on the tor_start() function (on /etc/rc.d/rc.tor file):

Code:

mkdir /var/run/tor/
chown tor:tor /var/run/tor

And now tor can create the PID file with:

Code:

/usr/bin/tor -f /etc/tor/torrc

It's a workaround too but looks like more elegant than add all proccess on the rc.local script.

chrisretusn · 10-19-2020, 06:02 AM

Quote:

Originally Posted by MasterZ80

Thanks for the help! Another way is to add the following code on the tor_start()

When Slackware put /run on tmpfs, this is what I did. Bold is the addition.

Code:

tor_start() {
  PID=$(/bin/cat $PIDFILE 2>/dev/null)
  if [ -n "$PID" ]; then
    echo "Tor is already running. PID: $PID"
  else
    # If there is a PIDFILE, tor acts like it starts, but doesn't. 
    if [ -f "$PIDFILE" ]; then
      rm -f $PIDFILE
    fi
    if [ ! -d /var/run/tor ]; then
      mkdir -p /var/run/tor
      chown tor:tor /var/run/tor
    fi
    echo "Starting tor:  /usr/sbin/tor"
    /usr/sbin/tor
  fi
}

Quote:

It's a workaround too but looks like more elegant than add all proccess on the rc.local script.

I don't view this as a workaround. It how it should be handled in my view. Also you do not need to create the PID file.

Edit: I made this change to my local build for tor, not directly to the installed /etc/rc.d/rc.tor file.

MasterZ80 · 10-19-2020, 06:36 AM

Hi chrisretusn, it seems logic. The original tor_start() function on rc.tor file hosted on Slackbuilds.org have this look:

Code:

tor_start() {
  if [ -n "$MAX_FILEDESCRIPTORS" ]; then
    echo -n "Raising maximum number of filedescriptors (ulimit -n) to $MAX_FILEDESCRIPTORS"
    if ulimit -n "$MAX_FILEDESCRIPTORS" ; then
      echo "..."
    else
      echo ": FAILED."
    fi
  fi
  echo "Starting Tor..."
  /usr/bin/tor
}

I'll improve the code with your suggestion. Thanks a lot.