Hello,

I don't know why, but I had the idea to add the changelog viewer after reading the first post of this thread.

You can scroll left/right in the changelog viewer with left/right keys.


I did some change to the changelog viewer so that it can display changelog entries from 3rd party repositories, too.

To achieve this, I modified getfile() so that, it downloads ChangeLog from 3rd party repositories, merges them with slackware changelog into a file called Unified-ChangeLog.txt, and, generates an index file called Unified-ChangeLog.idx.

Notes:

1. This does not affect the ChangeLog.txt used by check-updates.
   
   
2. There's no consequence when a repository has no ChangeLog.txt file.
   
   
3. In some case, the ChangeLog.txt of a repository is not directly accessible from the URL specified in slackpkgplus.conf. In that case, getfile() automatically searches in parent URLs. For instance, if the URL specified in slackpkgplus.conf is a/b/c/d and the ChangeLog.txt is in a/, getfile() will try the URLs a/b/c/d/ChangeLog.txt, a/b/c/ChangeLog.txt, a/b/ChangeLog.txt, and a/ChangeLog.txt ...
   
   
4. When the ChangeLog.txt is not found in a repository, a 404 error is reported by the downloader (see below). Maybe it would be better to redirect downloader error in /dev/null when downloading the changelog (lines #574-581 once the patch is applied):
   
   Code:

   ---

   http://taper.alienbase.nl/mirrors/people/alien/multilib/14.1//ChangeLog.txt:
2016-03-15 16:00:30 ERROR 404: Not Found.

   ---

5. the showChangeLogInfo() function expects the changelog entries follow the "standard" slackware changelog format, which can be described as being :
   
   Code:

   ---

   path/to/package_name.t[blgx]z:[ ]added|moved|rebuilt|upgraded"
<text|null>
<SEPARATOR|null>

   ---

   
   SEPARATOR is a string starting with a plus followed by dashed, followed by a plus, and followed by 0 to n spaces.
   
   Important:
   Some repositories don't follow this format. Therefore, in this case, showChangeLogInfo() will find no changelog entry for packages from these repositories, or could truncate some information from the changelog.

Here is a screenshot of changelog viewer with changelog entries from 3rd party repositories :

As I said earlier, when the repository don't follow the "standard" changelog format, some information can be truncated, which is the case for the entry compat32-tools in the screenshot above.



The patch (Attachment 21154) is for slackpkg+/devel 1.7.b4 :
Hope this help.

--
Seb

I'm sorry for the time, but I'm a lot occupied this period.

Yes, I like the Changelog for 3th party repository, even if just few repositories has useful information (well, when I wrote slackpkg+ there was few repositories with CHECKSUMS.md5 and very few with the GPG-KEY; today all have it) and not all Changelog files have a slackware-compatible format.

I dislike to search Changelog in parent directories becouse that means to go out the path specified from the user. I know the a lot o repositories have Changelog just in parent. So I think that we should add a setting in slackpkgplus.conf where the user explicitly allow to serch changelog in parent.

The 404 problem reported from wget I think that should be managed but it is to review later becouse we have a lot of downloader
1) wget
2) wgetdebug
3) cacheddownloader (that also use curl to retrieve the headers)
4) custom $DOWNLOADCMD

we have the same problem with some not existent MANIFEST.bz2 and other metadata that not all repositories have.

Also I want to reintroduce the function that we removed a lot of time ago, regarding the install-new working for multilib.
Everytime I run the install-new command I have to remember to run slackpkg install multilib; and if I have no a full slackware installation I have to remember which 32bit libraries I have to install. The idea is the same of years ago.. find for 32bit packages that have the corrispondent 64bit installed as setupmultilib.sh does.

Hello,

I understand and I see no problem with that.


Something like that should do the trick :

1. add the variable SEARCH_CLOG_INPARENT which allows to define whether or not the 3rd party repository changelogs must be searched in parent:

Code:

---

# Defines if the changelog of any 3rd party repository must be searched in parent URL when not found in base URL.
 #
 # Can be set to "on" or "off" (default)
 #
SEARCH_CLOG_INPARENT=off

---

2. Once you have applied the patch I sent, replace the two lines below :

Code:

---

        BDNAMES=( $(echo $BASEDIR | tr "/" " ") )
        LIMIT=$(( ${#BDNAMES[@]} - 1 ))

---

by :

Code:

---

      LIMIT=1

      if [ "$SEARCH_CLOG_INPARENT" == "on" ] ; then
            BDNAMES=( $(echo $BASEDIR | tr "/" " ") )
            LIMIT=$(( ${#BDNAMES[@]} - 1 ))
      fi

---

Ok.

Here is my point of view on this:

• install-new should be left as is : dedicated to install new packages added to official slackware tree, and only that. Therefore, to install new packages from any other repository, slackpkg install <reponame> must be used instead.
  
• Reintroducing install-new only for the multilib repository could be misunderstood by users. They could think that install-new works for all 3rd party repositories, and would not understand why the required package Y added to the repository R is not proposed by slackpkg.
  
• As far as i remember, introducing install-new for all repositories is tricky, and anyway, could lead slackpkg to suggest a bunch of unexpected/undesired packages. So, doing that is not an option.
  

--
SeB

Sorry for absence..
On my office I've currently double work to do and a lot to do on my house.

However if there are not other think to report, these days I will release beta5 with the only 3th party changelogs, and if it works well I think that we can release an rc release to freeze any other new feature and only fix current.
If someone has something to say, speak now or forever hold your peace :D

I have other ideas but I finished the time to elaborate it; I will add it in a further version.

I whould some feedback from who think to put slackpkg in her own repository and from who asked for a stable release.

My idea is to release slackpkg 1.7 stable before slackware 14.2 (that is currently -rc1) so to test it sufficiently to call it stable when slackware 14.2 will be release.

I'm seeing the code for changelog and I found something to fix.

(aligned to latest patch excluding SEARCH_CLOG_INPARENT implementation)

* row 1284 and 1343
CLogOpt is defined as CLOGopt
dialog.tmp does not ends with blank space so dialog.tmp.off is always == dialog.tmp


* row 1334
if no packages are selected the selection dialogs return without an error, and the user think that it does not work.
I think that should appear a dialog with a similar of "Please, select at least a package"


* row 1187
changelog should not use tab becouse it has an anomaly when you scroll left<->right with the arrow keys.



Currently I've not tried all, but it is a great work.

Thankyou

So the if $CLogOpt statement is always executed. Sorry. Just change it by if $CLOGopt ...

Sorry, but I don't understand what you mean :
Right. This should do the trick :
Maybe you can supersede it with 4 to 8 spaces.

--
SeB

I have tried with slackpkg install, not upgrade.
There may have a different format.
I have not a pc now to test.

Ok, I didn't think about that. sorry.

So to fix the 1st problem, replace :

by

and to fix the 2nd problem, replace :
by
P.S: I think its better to have comments here to understand why we're doing that. However, you can get rid of one of the two if you want.


--
SeB

slackpkg+-1.7.b4.1 released

I also removed some unuseful verbosity in cached_downloader for clarity and compact output. If you want some output set VERBOSE=2 or does not use the caching downoader

May be useful to write - in the Unified-ChangeLog.idx - then repository name:

19127:slackpkgplus: pkg/slackpkg+-1.7.b4.2-noarch-2mt.txz: Rebuilt

Only preparing the next slackpkg+ changelog I saw what we done in this release.
I needed a separated file to track all changes!!

A very thanks to all contributing with code, bug reporting, idea or comments!!!!

Now begins the bugfixing only.

Hello,

I guess you want to print the repository name in front of each entry displayed in the ChangeLog dialog.

I looked at this, but this would be too tricky to do with the current code because of the way files Unified-ChangeLog.txt and Unified-ChangeLog.idx are generated.

So to achieve this, I modified the code, so that, for each repository, there is a couple of files {<reponame>.txt, <reponame>.idx} stored in directory WORKDIR/ChangeLogs, and I updated the functions getfile() and showChangeLogInfo() accordingly.

the patch Attachment 21586 is for slackpkg+/dev 1.7.b4.2 :
Here is a screenshot of slackpkg with this patch in action :

Cheers.

--
SeB

The ideas was to put repository name in Unified-ChangeLog.idx so to see it when opening manually that file, but it's a good idea to show it in dialog and put metadata in a dedicaded subdir.

I not jet merging that code, however I found a bug in the old code.

this is false.
In effect at this point the $WORKDIR contains the older changelog, so if you run slackpkg update after a slackware update you does not have the new slackware changes in Unified-ChangeLog.
The ChangeLog.txt is downloaded in $TMPDIR
Also I think that the entire Unified-ChangeLog should be generated in $TMPDIR.
If you abort with ctrl+c the slackpkg update during changelog download, the older Unified-ChangeLog will be removed and the new is partial.

So, do you plan to include it, or do you want to stick with older version with Unified-ChangeLog.{txt,idx} ?

Oops, sorry.

Ah, ok. In fact, on command "update", slackpkg calls updatefilelists() which calls checkchangelog(), so the ChangeLog.txt is downloaded in TMPDIR, then, when checkchangelog() returns, updatefilelists() copies ChangeLog.txt from TMPDIR into WORKDIR.


In this case the Unified-ChangeLog.{txt,idx} (or files in ChangeLogs/) generated in TMPDIR by getfile() will need to be copied into WORKDIR before slackpkg exits. However, since we can't control when getfile() is called to download the ChangeLog file, we have 2 choices here :

1. Duplicate the code which handle the command "update" from original slackpkg, and add the required code to copy the ChangeLog from TMPDIR into WORKDIR :
2. copy the Unified-ChangeLog.{txt,idx} from TMPDIR into WORKDIR when the function cleanup() is called, unless this function is called in response to a CTRLC (ie. SIGINT) :
Which solution do you want to implement ?

Another point which has nothing to do with the last changes.

This morning, when reading this thread, I've tried to run the command slackpkg search mozilla-firefox, but it returned nothing :
However, the commands below show that firefox is installed, and referenced in slackpkg database. Furthermore, firefox is not blacklisted :
So, I checked slackpkg+ code on github, and found that "search" works well until this commit. The problem comes from line #920 :

This line fails because GREPOPTS include the option --word-regex and there are slashes in the regular-expression. However I don't understand the need of those slashes (in Bold RED). Can you explain this ?

Anyway, without these slash at line #920 :
the command slackpkg search works as expected:
Hope this help.

--
SeB

Now I've few time, so I reply quickly.


Yes, I will include it (so you can patch it directly)


I think that the second way (cleanup() modify) is the better way. There is already a similar use in that function:


[quote]Other users has experienced the same problem with the original slackpkg, but I have no time now to see the problem.



Now I don't remember well, but with the '/' it searches only in url, without it, it search in repository too. I've to search the real reason, but I remember that there was a reason.