regards the issue for dir:// repositories, I fixed it and substituted ls with find.

When I wrote it, I did not use find becouse I can't know the structure of the tree, and if it contains many subdir it can slow down the start of slackpkg in any command (search,upgrade,update,...).
In effect, dir:// may be a dedicated directory containing just packages, but may be a directory containing any other things.
So I tried to put dir://home/ as local repository (about 200.000 mixed files)
It take about 10 seconds before start commands.
I think that it is an acceptable time (how many people set the entire home as local repository? He does it at his own risk).

please try it before I commit (apply to 1.7.b3):

I'm reorganizing the slackpkg+ official repositories.

I want continue to support the -1.6 version for a lot.
So I'm thinking that structure (that I will insert in repositories.txt in next commit)

http://slakfinder.org/slackpkg+/ --> latest slackpkg+ stable version
http://slakfinder.org/slackpkg+1.6/ --> the 1.6.x version; it will be supported for a lot
http://slakfinder.org/slackpkg+1.7/ --> the 1.7.x version; the next stable version
http://slakfinder.org/slackpkg+current/ --> the current version; use it to try new features
http://slakfinder.org/slackpkg+dev/ --> the development version; use it to help the development

currently
slackpkg+1.6/ is a link to slackpkg+/
slackpkg+1.7/ and slackpkg+current/ is a link to slackpkg+dev/

When slackpkg+ 1.7 stable will be released, slackpkg+/ will be a link to slackpkg+1.7/, so all users automatically upgrade to it.
Who want continue to use slackpkg+ 1.6 have to point to slackpkg+1.6/ directly.

slackpkg+current/ will be a snapshot of slackpkg+dev/ tree
slackpkg+1.6/ will be mantained for fixes
slackpkg+1.7/ will be mantained for fixes and minor updates

what do you think of that plan?


Currently repositories.txt contains some 14.2 repository from microlinux.
Someone are preparing some 14.2 repository?

current and dev branches look like duplicates to me. Or do you really see a case when you'd want to play in dev/ without adjusting current/ accordingly?

Why not try to follow an approach similar to Slackware: One stable version + one development version?

You could have slackpkg+/ link to the latest stable version (1.6 today and 1.7 when it's released). So I would see:

slackpkg+dev/ will be the development tree (I would not name it "current" to avoid a possible confusion that it's a package for Slackware -current. It's not)
slackpkg+/ will be a link to the latest stable version (slackpkg+1.6/ for now)
slackpkg+1.7/ will be created when a new stable version is released based on dev tree. slackpkg+/ will then be changed to link to this latest stable version.

In git, usually, the master branch is a development code, for stable versions you may use git tags and any non-master branches, and for testing new features you can use another branch(es). That will just simplify your work. Yes, I know, you prefer to do all the actions manually, but why you don't use git, I don't understand. IMO git is not so difficult to learn...

I don't know. I think that in dev/ I'm more free to do experiments, add features (or simplest patches), and then remove it.
The -current even if it is not a -stable tree, however should have less experiments.
The reason for a public -dev is just becouse I want keep public all experiments.

Slackware has many stable versions, one -current version (that is not a development version), and one or more non-public tree for internal development.

yes

good observation. slackpkg+current should not exists with that name.




opinions...
however for git I'm trying to reorganizing the ideas, and one it to put -current as master and -dev in another branch. Many time I used git reset and git push forced in a branch; the -master branch is not a good candidate for that operation.


I did never used tags, but the idea is a branch 1.6 and a branch 1.7

I like git but I prefer to apply patches then commit&push instead to merge from other fork becouse I'm free to review before apply it.
Also git give best results when a project has many indipendent files. Here I've a single big file that is not simple to manage (I already tried to cut in in multiple files, but it did not add many value). Here git is just used to
1) keep track of modifies
2) keep it public in a simplest way
3) allow me to work from many computers

To discuss patches and bug the best way is linuxquestions (the real best place should be slacky.eu in italian language ;), but I cannot ask the moon :) ).

Hello,

I have some new code (beta) that should be, I guess, useful.

This is currently for slackpkg+/devel (ie. 1.7.b3), but could be backported to previous version(s), and even, to slackpkg.

This is a simple extension to the dialog shown in response to commands install, upgrade, and upgrade-all, which allows users to check the changelog for the selected packages.

To do that, I added a button, called ChangeLog, between the Ok and Cancel buttons of the packages selection dialog.

For instance, running slackpkg upgrade patches will show this :

Attachment 21108

When the button ChangeLog is clicked, a textbox is displayed with the changelog entries for the selected packages, like as below :

Attachment 21109

When the changelog textbox is closed, the packages selection dialog is restored, with the exact same selection as before. For instance:

Attachment 21110


The code is in beta stage and must be tested and reviewed by anyone interrested.

Attachment 21111
Cheers.

--
Seb

Zerouno, do you want slackpkg+ "stable: questions/troubles here or in a separate thread?

One of my favourite quotes of all time.

Here's the best place.

I was searching the code for the beta4 ;)


Version 1.7.b4 - 14/Mar/2016
- slackpkg search now search in dir:// repositories too.
- subdirectory allowed in dir:// repositories.
- slackpkg search honour correctly the '+' character
- Added 'ChangeLog' dialog box to show the changelog of selected packages
(thanks to phenixia2003)


the dialog function(s) contain a bug regard the size of it.
For the changelog, the dialog is 19x70, but the slackware changelog contains rows up to 79 columns.
For package list, 'package name'+'repository name' may be longer than 70 characters.
This is not a large problem since few packages have long name, and the changelog dialogbox is a non-critical feature, but I think it's the time to solve it.

Hello,

I don't know why, but I had the idea to add the changelog viewer after reading the first post of this thread.

You can scroll left/right in the changelog viewer with left/right keys.


I did some change to the changelog viewer so that it can display changelog entries from 3rd party repositories, too.

To achieve this, I modified getfile() so that, it downloads ChangeLog from 3rd party repositories, merges them with slackware changelog into a file called Unified-ChangeLog.txt, and, generates an index file called Unified-ChangeLog.idx.

Notes:

1. This does not affect the ChangeLog.txt used by check-updates.
   
   
2. There's no consequence when a repository has no ChangeLog.txt file.
   
   
3. In some case, the ChangeLog.txt of a repository is not directly accessible from the URL specified in slackpkgplus.conf. In that case, getfile() automatically searches in parent URLs. For instance, if the URL specified in slackpkgplus.conf is a/b/c/d and the ChangeLog.txt is in a/, getfile() will try the URLs a/b/c/d/ChangeLog.txt, a/b/c/ChangeLog.txt, a/b/ChangeLog.txt, and a/ChangeLog.txt ...
   
   
4. When the ChangeLog.txt is not found in a repository, a 404 error is reported by the downloader (see below). Maybe it would be better to redirect downloader error in /dev/null when downloading the changelog (lines #574-581 once the patch is applied):
   
   Code:

   ---

   http://taper.alienbase.nl/mirrors/people/alien/multilib/14.1//ChangeLog.txt:
2016-03-15 16:00:30 ERROR 404: Not Found.

   ---

5. the showChangeLogInfo() function expects the changelog entries follow the "standard" slackware changelog format, which can be described as being :
   
   Code:

   ---

   path/to/package_name.t[blgx]z:[ ]added|moved|rebuilt|upgraded"
<text|null>
<SEPARATOR|null>

   ---

   
   SEPARATOR is a string starting with a plus followed by dashed, followed by a plus, and followed by 0 to n spaces.
   
   Important:
   Some repositories don't follow this format. Therefore, in this case, showChangeLogInfo() will find no changelog entry for packages from these repositories, or could truncate some information from the changelog.

Here is a screenshot of changelog viewer with changelog entries from 3rd party repositories :

As I said earlier, when the repository don't follow the "standard" changelog format, some information can be truncated, which is the case for the entry compat32-tools in the screenshot above.



The patch (Attachment 21154) is for slackpkg+/devel 1.7.b4 :
Hope this help.

--
Seb

I'm sorry for the time, but I'm a lot occupied this period.

Yes, I like the Changelog for 3th party repository, even if just few repositories has useful information (well, when I wrote slackpkg+ there was few repositories with CHECKSUMS.md5 and very few with the GPG-KEY; today all have it) and not all Changelog files have a slackware-compatible format.

I dislike to search Changelog in parent directories becouse that means to go out the path specified from the user. I know the a lot o repositories have Changelog just in parent. So I think that we should add a setting in slackpkgplus.conf where the user explicitly allow to serch changelog in parent.

The 404 problem reported from wget I think that should be managed but it is to review later becouse we have a lot of downloader
1) wget
2) wgetdebug
3) cacheddownloader (that also use curl to retrieve the headers)
4) custom $DOWNLOADCMD

we have the same problem with some not existent MANIFEST.bz2 and other metadata that not all repositories have.

Also I want to reintroduce the function that we removed a lot of time ago, regarding the install-new working for multilib.
Everytime I run the install-new command I have to remember to run slackpkg install multilib; and if I have no a full slackware installation I have to remember which 32bit libraries I have to install. The idea is the same of years ago.. find for 32bit packages that have the corrispondent 64bit installed as setupmultilib.sh does.

Hello,

I understand and I see no problem with that.


Something like that should do the trick :

1. add the variable SEARCH_CLOG_INPARENT which allows to define whether or not the 3rd party repository changelogs must be searched in parent:

Code:

---

# Defines if the changelog of any 3rd party repository must be searched in parent URL when not found in base URL.
 #
 # Can be set to "on" or "off" (default)
 #
SEARCH_CLOG_INPARENT=off

---

2. Once you have applied the patch I sent, replace the two lines below :

Code:

---

        BDNAMES=( $(echo $BASEDIR | tr "/" " ") )
        LIMIT=$(( ${#BDNAMES[@]} - 1 ))

---

by :

Code:

---

      LIMIT=1

      if [ "$SEARCH_CLOG_INPARENT" == "on" ] ; then
            BDNAMES=( $(echo $BASEDIR | tr "/" " ") )
            LIMIT=$(( ${#BDNAMES[@]} - 1 ))
      fi

---

Ok.

Here is my point of view on this:

• install-new should be left as is : dedicated to install new packages added to official slackware tree, and only that. Therefore, to install new packages from any other repository, slackpkg install <reponame> must be used instead.
  
• Reintroducing install-new only for the multilib repository could be misunderstood by users. They could think that install-new works for all 3rd party repositories, and would not understand why the required package Y added to the repository R is not proposed by slackpkg.
  
• As far as i remember, introducing install-new for all repositories is tricky, and anyway, could lead slackpkg to suggest a bunch of unexpected/undesired packages. So, doing that is not an option.
  

--
SeB

Sorry for absence..
On my office I've currently double work to do and a lot to do on my house.

However if there are not other think to report, these days I will release beta5 with the only 3th party changelogs, and if it works well I think that we can release an rc release to freeze any other new feature and only fix current.
If someone has something to say, speak now or forever hold your peace :D

I have other ideas but I finished the time to elaborate it; I will add it in a further version.

I whould some feedback from who think to put slackpkg in her own repository and from who asked for a stable release.

My idea is to release slackpkg 1.7 stable before slackware 14.2 (that is currently -rc1) so to test it sufficiently to call it stable when slackware 14.2 will be release.

I'm seeing the code for changelog and I found something to fix.

(aligned to latest patch excluding SEARCH_CLOG_INPARENT implementation)

* row 1284 and 1343
CLogOpt is defined as CLOGopt
dialog.tmp does not ends with blank space so dialog.tmp.off is always == dialog.tmp


* row 1334
if no packages are selected the selection dialogs return without an error, and the user think that it does not work.
I think that should appear a dialog with a similar of "Please, select at least a package"


* row 1187
changelog should not use tab becouse it has an anomaly when you scroll left<->right with the arrow keys.



Currently I've not tried all, but it is a great work.

Thankyou

So the if $CLogOpt statement is always executed. Sorry. Just change it by if $CLOGopt ...

Sorry, but I don't understand what you mean :
Right. This should do the trick :
Maybe you can supersede it with 4 to 8 spaces.

--
SeB

I have tried with slackpkg install, not upgrade.
There may have a different format.
I have not a pc now to test.

Ok, I didn't think about that. sorry.

So to fix the 1st problem, replace :

by

and to fix the 2nd problem, replace :
by
P.S: I think its better to have comments here to understand why we're doing that. However, you can get rid of one of the two if you want.


--
SeB

slackpkg+-1.7.b4.1 released

I also removed some unuseful verbosity in cached_downloader for clarity and compact output. If you want some output set VERBOSE=2 or does not use the caching downoader

May be useful to write - in the Unified-ChangeLog.idx - then repository name:

19127:slackpkgplus: pkg/slackpkg+-1.7.b4.2-noarch-2mt.txz: Rebuilt

Only preparing the next slackpkg+ changelog I saw what we done in this release.
I needed a separated file to track all changes!!

A very thanks to all contributing with code, bug reporting, idea or comments!!!!

Now begins the bugfixing only.

Hello,

I guess you want to print the repository name in front of each entry displayed in the ChangeLog dialog.

I looked at this, but this would be too tricky to do with the current code because of the way files Unified-ChangeLog.txt and Unified-ChangeLog.idx are generated.

So to achieve this, I modified the code, so that, for each repository, there is a couple of files {<reponame>.txt, <reponame>.idx} stored in directory WORKDIR/ChangeLogs, and I updated the functions getfile() and showChangeLogInfo() accordingly.

the patch Attachment 21586 is for slackpkg+/dev 1.7.b4.2 :
Here is a screenshot of slackpkg with this patch in action :

Cheers.

--
SeB

The ideas was to put repository name in Unified-ChangeLog.idx so to see it when opening manually that file, but it's a good idea to show it in dialog and put metadata in a dedicaded subdir.

I not jet merging that code, however I found a bug in the old code.

this is false.
In effect at this point the $WORKDIR contains the older changelog, so if you run slackpkg update after a slackware update you does not have the new slackware changes in Unified-ChangeLog.
The ChangeLog.txt is downloaded in $TMPDIR
Also I think that the entire Unified-ChangeLog should be generated in $TMPDIR.
If you abort with ctrl+c the slackpkg update during changelog download, the older Unified-ChangeLog will be removed and the new is partial.

So, do you plan to include it, or do you want to stick with older version with Unified-ChangeLog.{txt,idx} ?

Oops, sorry.

Ah, ok. In fact, on command "update", slackpkg calls updatefilelists() which calls checkchangelog(), so the ChangeLog.txt is downloaded in TMPDIR, then, when checkchangelog() returns, updatefilelists() copies ChangeLog.txt from TMPDIR into WORKDIR.


In this case the Unified-ChangeLog.{txt,idx} (or files in ChangeLogs/) generated in TMPDIR by getfile() will need to be copied into WORKDIR before slackpkg exits. However, since we can't control when getfile() is called to download the ChangeLog file, we have 2 choices here :

1. Duplicate the code which handle the command "update" from original slackpkg, and add the required code to copy the ChangeLog from TMPDIR into WORKDIR :
2. copy the Unified-ChangeLog.{txt,idx} from TMPDIR into WORKDIR when the function cleanup() is called, unless this function is called in response to a CTRLC (ie. SIGINT) :
Which solution do you want to implement ?

Another point which has nothing to do with the last changes.

This morning, when reading this thread, I've tried to run the command slackpkg search mozilla-firefox, but it returned nothing :
However, the commands below show that firefox is installed, and referenced in slackpkg database. Furthermore, firefox is not blacklisted :
So, I checked slackpkg+ code on github, and found that "search" works well until this commit. The problem comes from line #920 :

This line fails because GREPOPTS include the option --word-regex and there are slashes in the regular-expression. However I don't understand the need of those slashes (in Bold RED). Can you explain this ?

Anyway, without these slash at line #920 :
the command slackpkg search works as expected:
Hope this help.

--
SeB

Now I've few time, so I reply quickly.


Yes, I will include it (so you can patch it directly)


I think that the second way (cleanup() modify) is the better way. There is already a similar use in that function:


[quote]Other users has experienced the same problem with the original slackpkg, but I have no time now to see the problem.



Now I don't remember well, but with the '/' it searches only in url, without it, it search in repository too. I've to search the real reason, but I remember that there was a reason.

Hello,

Attachment 21644


Cheers.

--
SeB

uploaded.
Great work

Hello,

I've just upgraded to Slackware current. I cleaned up all third-party packages during the upgrade and I'm now slowly adding back some of them using stable slackpkg+ 1.6.1p2.

Everything is OK except for one package from alienBOB current repository: rhino-1_7R3-noarch-1alien.tgz

I get the error message when running "slackpkg install rhino": It's strange because I can install other packages from the repository (so it's not a GPG key issue). Also when I download manually the tgz, asc and md5 files, the checks are correct.

Could it be an issue with the stable version of slackpkg+?

the tgz package is not failing.

If you see entire output you can see that fails the asc file.

is not a slackpkg+ problem; may be a problem in repository; contact Eric (that however should follow this thread)

Thanks zerouno for the explanation.

I left a message on alienBOB blog to make sure he notices.

[EDIT]
rhino package has been updated in alienBOB repository. No more problem, I could upgrade the package using slackpkg.
[/EDIT]

it's the time to release a slackpkg+ rc.
:)

rc1 is here

just some fix.
Please test it

the regex for changelog detect does fail in some slackware update (Fri May 20 21:20:29 UTC 2016):

in dialog does show
this should solve, but I dont known if it generate some regression:

phenixia2003 what do you think?

Hello,


I'm ok with that. I did some tests with the attached script and all seems ok. This script downloads a slackware changelog, extract the packages informations using the old and new regex and show the diff (in vim) between these two set of data.

for instance, if you want to see the impact of the new regex for slackware64-current, run it as below :

--
SeB

You are what an italian people call "Pazzo scatenato" :D

the script has found a bug in changelog :)

I've readapted the script for thirdy party repository. It has found other bugs in other changelogs.

But as regression I intend another thing.

With the new regex we have many other things in .idx file.
slackware:
alienbob:
...

I don't think that this can cause problems or regressions in changelog search code but I must to consider that possibility.

:cool:

The only way to prevent this is to change the expression used to build the index (see at the end of this post)


This will cause no problems, nor regressions. showChangeLogInfos() uses the index to only get informations (start position in changelog, pathname, status) about the packages listed in file TMPDIR/dialog.out, which, contains package names (ie. basename-version-arch-build.t[gx]z) only. But, if you want to avoid this, you can use the "old" regular-expression to create the index at line #646-#648 (slackpkg/devel).

Current code:
New code:
Note, that the regular expression above is a bit different from the one currently used by slackpkg+ :

1. I added "[ ]*" after "t[blxg]z" because I've found an entry (in slackware 13.0 changelog) which match this particular case.

2. the "z?" is to prevent the malformed entries, like those you mentioned earlier (ie.n/openssl-1.0.1j-x86_64-1.tx and xap/seamonkey-2.26-x86_64-1.tx: )

Cheers.


--
SeB

I've no a computer in this moment, but I don't think that we must manage the exceptions to the normality.

The best way is to report the bug to Patrick (but that problem is about two years old).
Sometime a user may not see a changelog, this is not a real problem.

Patrik gave us a "Last call"
I decided to reciprocate with a "Last Call" for slackpkg+1.7, so please test! :)

Seems that
does not means exactly "remove first line and insert TEXT instead it", so if both expressions start with the same number, the line is dropped instead replaced.
So if $LINEIDX == $PRIORITYIDX the selected package is dropped from pkglist in givepriority():
They have a similar case when using "slackpkg upgrade file:./package-1-x86-1.txz"; the package is added on top of pkglist and that sed drop it.

Seems that
does work, but I'm not sure that
does work for any $PRIORITYIDX and for any $LINEIDX


currently I've solved with
since it is not useful to remove and reinsert the same line at the same point

Do you like bash-completation?

install the bash-completation package, then copy following code in /etc/bash_completion.d/slackpkg the close and reopen the shell, then test and give me feedback.

Hello,

hmm, correct me if I'm wrong, but, if you insert before deleting, you should delete at LINEIDX+1 when PRIORITYIDX (ie. insert point) < LINEIDX (ie. delete point).


I'm ok with that.

--
SeB

The same that I thought. But seems that the new inserted lines are not considered by the other expressions.

No one of the following statement respect what I thought.
but the line number in the expression seems that just match the input file, not the manipulation. From 'man sed'
Well, today I learned another thing :)

These lines are not inserted in the file, just written to standard output. The sed commands takes each line of the file as input, not a text written to standard output, so the sed commands have no effect on such text. In other words, the commands you use apply to the pattern space and the 'i' command doesn't write to the pattern space so no further command is applied to that text.

IMO the right way to learn sed is not to read "man sed" but rather the POSIX specification. The same apply to other utilities as well as to the shell command language.

Should you want to have the second sed expression applied to the result of the first one why not used a | ? It might be ugly but it works.

Maybe a bit off-topic but I'm not sure that the quoted section of sed man page is relevant to your issue.

I'm no sed expert but my understanding of the above is relevant when you have more than one input file for the sed command as explained here.

It works but is overly complicated. Also, cat is useless. Just write instead:or:And the order of the commands doesn't matter in this case so this works as well:

Someone has tested bash completation?

here another version (copy as /etc/bash-completation/slackpkg)

Through the years Slackpkg has become KISS. after that it is well not Slack it is just to much work trying to tell people like I like it.
so create your own repo. Your a slacker that's what it is about. And KISS the the work away. Some times you just have to do it by your self.
:)

slackpkg+ 1.7.0 is ready. I've just to reorder the changelog, adjust the slackbuild and my build/upload scripts.

Also I have to re-organize the github repository.
The proposal is the following: https://github.com/zuno/testplus
"devel" branch was removed and the "master" will be the main line (development) branch, as slackware-current does; and the branches "1.6" and "1.7" will be the stable packages (and the following backported patches from "master" branch)
This means that I must do a forced commit to rename master to 1.6 and devel to master.

However if I want to hold the current structure, the "devel" branch have to be merged in "master" branch, but the 'merge' command fails since the "stable" branch was merged in "master", so I must however do a forced commit with no-fastforward option (I'm not a git expert).

Slackpkg+ 1.7.0 stable was released.

Currently http://slakfinder.org/slackpkg+/ contains the 1.6 and
http://slakfinder.org/slackpkg+dev/ contains the 1.7.0rc3
You can find the new version in http://slakfinder.org/slackpkg+1.7/


I ask you to test it by configuring the 1.7 repository for last minute bug (packaging or uploading bugs; remember that the 1.7 was bird as a more tested release before the official release).

this is the git branch https://github.com/zuno/slackpkgplus/tree/1.7

Thanks for the new stable version 1.7.0

I just installed it and ran an upgrade. It was OK and the changelog (from Slackware only for now) was correctly displayed.

Using the default values for the new parameters, I tested the file search with incomplete/complete word (upgradep/upgradepkg), the case-sensitive search (MPlayer, mplayer and Mplayer) and got the expected results.

The search of changelog.txt in parent directory for alienbob current repository worked. I'm just wondering if it's wise to show in the stderr log that there is an error when looking into the initial directory. I was a bit confused initially and thought that there was an issue with alienbob repository. Maybe the error message could be hidden and replaced by a warning when SEARCH_CLOG_INPARENT=on.

Here are cosmetic comments:
In slackpkgplus.conf:
- the default value of SEARCH_CLOG_INPARENT is not mentioned in the comments
- typo error in comments for STRICTGPG: heterogeneous
In README:
- there is no info for parameter SEARCH_CLOG_INPARENT

Finally, I don't understand the verb "bird" in or (in README) Could you please explain? If it's a technical term, I'm sorry for my lack of tech knowledge.

Thanks again to you and the other developers for this wonderful tool.