slackpkg+ delete packages without signature

regdub · 06-12-2021, 03:07 AM

This concerns especially users who have configured slackpkg with DELALL=off

Recents versions of slackpkg+ delete packages without signature in TEMP

Code is :

Code:

  if [ -e $TEMP ];then
    # clean cache from packages without gpg signature
    find $TEMP ! -type d|sort|tac|awk '{if($1~/\.asc$/)f[$1]++;if($1~/\.t.z$/ && !f[$1".asc"])print $1}' |xargs -r rm -f
  fi

Since I don't see it in the changelog, I can't say if this is an involountery import from a test version or if it's here on purpose.
From my backups, it seems this behavior appeared in 1.7.6-noarch-4mt.
If it's the "bad package" in the changelog, I would never guess it means that.
This has no opt-out mechanism.

@zerouno
If it's here on purpose, I don't understand why.
I see another thread which talks of "cache invalidation" in the dev branch ? Well, this would be a violent invalidation imho.

There can be packages here without signatures for historical reasons, put here manually or by other tools.
When configuring DELALL=off, slackpkg let the user do the cleaning in TEMP and it would be nice that slackpkg+ can keep the same behavior.
If this requires too much work, this cleaning should at least be limited to SLACKPKGPLUS_* directories.

Thanks for reading.

zerouno · 01-21-2022, 04:22 AM

sorry for no reply.
I don't follow regularly the entire forum.

I forgot to report it in changelog.

I've not considered some things.

The purpose of this code is to remove partial/broken downloads.

Help me to understand which files need to be not removed to fix it:

1) repository that has not gpg support
2) ????

the /var/cache/packages should be used just for slackpkg. Do you know some other tools using it?

regdub · 01-21-2022, 09:49 PM

Sorry for not having post a link in the main thread and thanks for the explanation.

I use $TEMP for other packages.
I also cleaned up signatures of official packages in 2020, something I didn't do again.
Here, $TEMP is not on the system partition but on a data partition.

I saw your patch on the other thread, nice and thanks.
I'll continue there, maybe after sleeping.