LinuxQuestions.org
Visit Jeremy's Blog.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 03-23-2018, 09:49 AM   #151
NoStressHQ
Member
 
Registered: Apr 2010
Location: Geneva - Switzerland ( Bordeaux - France / Montreal - QC - Canada)
Distribution: Slackware 14.2 - 32/64bit
Posts: 609

Rep: Reputation: 221Reputation: 221Reputation: 221

About 'redraw', it doesn't happen from within menus.

Also it might just be a "useless" clear screen while just rewriting everything, making the terminal going through black state before redrawing. You might be able to remove that if it is explicitly invoked.

Bests.
 
Old 03-23-2018, 09:55 AM   #152
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
Quote:
Originally Posted by NoStressHQ View Post
About 'redraw', it doesn't happen from within menus.

Also it might just be a "useless" clear screen while just rewriting everything, making the terminal going through black state before redrawing. You might be able to remove that if it is explicitly invoked.

Bests.
In sboui, the left and right lists are drawn in their own ncurses windows. When it needs to scroll, it does a wclear on that window and redraws it, including the outside frame. So there is a little bit of wasted redrawing there, and I'm thinking maybe the wclear call causes flickering even if it's only clearing one subwindow of the application. Maybe I can be a little more stingy with that and only do a complete redraw when really necessary.

Anyway, these are all good suggestions that I will try to fix or improve in the next release.

Last edited by montagdude; 03-23-2018 at 10:02 AM.
 
Old 03-23-2018, 10:21 AM   #153
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
I just did a quick test in tmux with the wclear being commented out, and it seemed to completely solve the flickering problem. So that seems to have been it. I will just have to figure out if there are cases where it is actually needed.
 
1 members found this post helpful.
Old 03-23-2018, 10:29 AM   #154
55020
Senior Member
 
Registered: Sep 2009
Location: Yorks. W.R. 167397
Distribution: Slackware
Posts: 1,307
Blog Entries: 4

Rep: Reputation: Disabled
Quote:
Originally Posted by montagdude View Post
Here is the order sboui uses to set the editor:
  1. The "editor" variable in the config file
  2. If that is not available, use the $EDITOR environment variable
  3. If that is not available, use vi.
Pretty much universally the Unix convention is that environment variables (volatile) override config files (static).
 
Old 03-23-2018, 02:14 PM   #155
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
Quote:
Originally Posted by 55020 View Post
Pretty much universally the Unix convention is that environment variables (volatile) override config files (static).
Are you sure? That seems non-intuitive to me that an environment variable that you may not have specifically set would override a config setting that you presumably did specifically set.

Since Midnight Commander was brought up earlier, let's take that as an example. It has an option to use the internal editor. If you enable that, files will be edited with mcedit, even if you have set $EDITOR to something else. Same thing with the internal viewer. So if that behavior is standard, it is definitely not universal.
 
Old 03-23-2018, 03:23 PM   #156
55020
Senior Member
 
Registered: Sep 2009
Location: Yorks. W.R. 167397
Distribution: Slackware
Posts: 1,307
Blog Entries: 4

Rep: Reputation: Disabled
Quote:
Originally Posted by montagdude View Post
Are you sure?
You must be new here
 
Old 03-23-2018, 03:24 PM   #157
NoStressHQ
Member
 
Registered: Apr 2010
Location: Geneva - Switzerland ( Bordeaux - France / Montreal - QC - Canada)
Distribution: Slackware 14.2 - 32/64bit
Posts: 609

Rep: Reputation: 221Reputation: 221Reputation: 221
Nice shot for the redraw.

About the $EDITOR, my problem is not the "actual behavior" although, yes the Env var should be "first class".

My problem might not be with the 'code' of the tool but the slackbuild (from sbo I guess) which set the configuration variable, without asking, with an arbitrary value...

The slackbuild should NOT set the editor in the config, OR it should use the actual $EDITOR to set it up with the user preference instead of a "niche factory choice" .

When I say problem, it's not the end of the world. I just explain what I find unnatural, vs what I'd expect as a "end user".

My problem is that the process:
Code:
  # installpkg sboui
  # sboui
And bam! vi is launched, whereas my EDITOR points to something else, and I need to "guess" that there are option and find it, and change it (so change is mandatory if you don't use vi). I think not forcing user with developer preference is a better user experience .
 
Old 03-23-2018, 04:02 PM   #158
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
Quote:
Originally Posted by NoStressHQ View Post
Nice shot for the redraw.

About the $EDITOR, my problem is not the "actual behavior" although, yes the Env var should be "first class".

My problem might not be with the 'code' of the tool but the slackbuild (from sbo I guess) which set the configuration variable, without asking, with an arbitrary value...

The slackbuild should NOT set the editor in the config, OR it should use the actual $EDITOR to set it up with the user preference instead of a "niche factory choice" .

When I say problem, it's not the end of the world. I just explain what I find unnatural, vs what I'd expect as a "end user".

My problem is that the process:
Code:
  # installpkg sboui
  # sboui
And bam! vi is launched, whereas my EDITOR points to something else, and I need to "guess" that there are option and find it, and change it (so change is mandatory if you don't use vi). I think not forcing user with developer preference is a better user experience .
Okay, so the problem in your mind boils down to the fact that sboui ships with a default value set for the "editor" config variable. If that were not the case, your $EDITOR would have been used from the get go. That is a very easy thing to fix. I will just change the default config file to not set anything for editor.

I still don't like the idea of an environment variable overriding the config setting, though. If I edit a program's config file, I am telling it that I expect it to behave in the way that I set. It's no different than my mc example: if I set it to "Use internal editor," then I expect it to do so, even though $EDITOR is set to something else.

Last edited by montagdude; 03-23-2018 at 04:03 PM.
 
1 members found this post helpful.
Old 03-24-2018, 01:37 AM   #159
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: West Jordan, UT, USA
Distribution: Slackware
Posts: 8,792

Rep: Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656
Quote:
Originally Posted by montagdude View Post
I have tested that this gives the expected behavior by exporting EDITOR=less, deleting the "editor = " line in ~/.sboui.conf, and viewing a README in sboui (it is opened with less). If that is not the behavior you are seeing, then I don't know why. Or are you just saying that there should be no value set for editor in the default config file?
As has been already mentioned (but I already typed most of this up before I realized there was another page)... Basically, having that option in the config file as a default overrides any system defaults. If a user has gone through the motions to switch the EDITOR/VISUAL variables, programs should utilize them by default. It does make sense to have an option to override it, but IMHO, that override shouldn't be used by default and should be something the user chooses to override.

Quote:
Originally Posted by montagdude View Post
I still don't like the idea of an environment variable overriding the config setting, though. If I edit a program's config file, I am telling it that I expect it to behave in the way that I set. It's no different than my mc example: if I set it to "Use internal editor," then I expect it to do so, even though $EDITOR is set to something else.
Think about it this way, if a user has vi set as the default editor in the config, then launches sboui with EDITOR=pico sboui, what program do you think the user would expect to be the editor?

Now, we already know there are default system editors that can be set with the EDITOR and VISUAL variables. Maybe a compromise could be to use those unless the editor= option in the conf file is set, but to also allow overriding that editor using something like SBEDITOR=pico sboui (which the variable could be documented in the man page/help files). Basically, this would allow overriding something that may be set in the config, while still allowing the system defaults if nothing is set.

Just some food for thought...
 
1 members found this post helpful.
Old 03-24-2018, 06:09 PM   #160
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
I'm starting to think that maybe the best solution is just to get rid of that option completely and just rely on the environment variables, with a sensible fallback in case those are not set. This would of course be documented in the manpage.
 
Old 03-25-2018, 04:23 PM   #161
USUARIONUEVO
Senior Member
 
Registered: Apr 2015
Posts: 2,335

Rep: Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930
Hi , im testing a little , but im not found option to set custom TAG.

By default sbo use _SBo TAG for packages , is possible to set custom TAG ?

Thanks for this little fantastic tool !
 
Old 03-25-2018, 05:18 PM   #162
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
Quote:
Originally Posted by USUARIONUEVO View Post
Hi , im testing a little , but im not found option to set custom TAG.

By default sbo use _SBo TAG for packages , is possible to set custom TAG ?

Thanks for this little fantastic tool !
There is a setting called repo_tag, but it is just meant for identifying packages from the repository. It doesn't override the TAG variable from the SlackBuild. Do you need it to do that?

Edit: I was just thinking, you could use build options for that. Those are just custom environment variables that are set when sboui invokes the install or upgrade command. Just hit Enter with the software you want selected in the right pane and select Build Options, then enter TAG=whatever as one of them.

Last edited by montagdude; 03-25-2018 at 05:31 PM.
 
Old 03-25-2018, 06:00 PM   #163
USUARIONUEVO
Senior Member
 
Registered: Apr 2015
Posts: 2,335

Rep: Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930
Hi , the option repo_tag , is not help me.

I can enter in to build options , but tired to edit all times , i want permanent in config.

I love "slackbuilds" TAG , ... is not important , but think arround some developer with custom repo packages needing tagged.

Im not like enter custom tag all times.

Wheni say custom repos, i talk arround , repos with packages built , like ponce or alienbob , that people probably not use automated tools for provide "build" packages to not lost time building , but my request is that simply , permanent TAG option in config.

Thanks!

Last edited by USUARIONUEVO; 03-25-2018 at 06:10 PM.
 
Old 03-25-2018, 06:04 PM   #164
montagdude
Senior Member
 
Registered: Apr 2016
Distribution: Slackware
Posts: 2,011

Original Poster
Rep: Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619Reputation: 1619
Use space to add a new build option. If you want to change the tag for all builds, set it in install_vars and upgrade_vars in the config file.

Alternatively, this seems like something the underlying package manager (e.g. sbopkg out sbotools) should be able to do.

Last edited by montagdude; 03-25-2018 at 06:09 PM.
 
Old 03-25-2018, 06:46 PM   #165
USUARIONUEVO
Senior Member
 
Registered: Apr 2015
Posts: 2,335

Rep: Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930Reputation: 930
@montagdude

Thanks fro your patience.

Quote:
install_cmd = "TAG=slackbuilds sbopkg -B -i";
upgrade_cmd = "TAG=slackbuilds sbopkg -B -i";
Thanks one more time !!!
 
  


Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] Call for Testers: MATE 1.17 willysr Slackware 25 04-21-2017 12:55 PM
[SOLVED] Call for Testers: MATE 1.14 for -Current willysr Slackware 13 05-27-2016 08:08 AM
Updating w3af to version 1.6.49 in SBo, need testers mralk3 Slackware 3 12-12-2015 05:54 PM
Call for Testers: MATE 1.8 willysr Slackware 137 08-06-2014 01:50 AM
ncurses-5.2-28 conflicts with file from package ncurses-5.2-12 tubby Linux - Software 4 06-16-2002 12:00 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 09:15 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration