LinuxQuestions.org
Download your favorite Linux distribution at LQ ISO.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 01-12-2018, 05:50 PM   #16
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,736

Rep: Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022

I can confirm the behavior before and after the patch was merged.
The patch does fix the issue.
 
Old 01-12-2018, 05:52 PM   #17
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,736

Rep: Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022Reputation: 1022
Quote:
Originally Posted by bamunds View Post
So @willysr did you find the patch needed for the intel-microcode SBo or was there some error in sbopkg? If the slackbuild I'll want to "note" in my Howto install Intel microcode thread to use latest intel-microcode.SlackBuild or users of sbopkg should now rebuild. Cheers
It has been updated in the last public update, so all you need is to run sbopkg -r and you will get the latest intel-microcode
 
Old 01-12-2018, 05:58 PM   #18
bassmadrigal
Senior Member
 
Registered: Nov 2003
Location: Newport News, VA
Distribution: Slackware
Posts: 4,753

Rep: Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637Reputation: 2637
Quote:
Originally Posted by bamunds View Post
1) I've never had this issue with either hand modifying and executing a slackbuild (and specifically didn't happen with the intel-microcode 20171117 modified to 20180108) or modifying the slackbuild within the sbopkg "Edit Slackbuild" or "Edit Info" functions.
You'd only see this issue if you look at the /usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild after installing a Slackware package created by sbopkg using a SlackBuild you modified and see that your changes aren't there. I just looked at my htpc, which I had modified the SlackBuild for kodi to build 17.6 (instead of the 17.4 that was on the repo). Yet, when I grep that SlackBuild, the version shows 17.4.

Code:
jbhansen@febtober:/$ grep SlackBuild$ /var/log/packages/kodi-17.6-x86_64-1_SBo 
usr/doc/kodi-17.6/kodi.SlackBuild
jbhansen@febtober:/$ grep "VERSION=" /usr/doc/kodi-17.6/kodi.SlackBuild 
VERSION=${VERSION:-17.4}
Quote:
Originally Posted by bamunds View Post
2) Examined the sbopkg code and I don't see any function to "cat" anything to /usr/doc, the slackbuild package does that function. Which is why a hand processed slackbuild will leave the correct files in /usr/doc just as using sbopkg does.
You're correct, the copying of the SlackBuild is not a function of sbopkg, but of the SlackBuild. Per SBo templates, SlackBuilds should contain the following line:

Code:
cat $CWD/$PRGNAM.SlackBuild > $PKG/usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild
However, you're wrong in that a modified SlackBuild using sbopkg will leave the correct file. When you customize a SlackBuild, sbopkg doesn't overwrite the original file. That remains in place untouched. So, sbopkg adds .sbopkg to the modified file, so it reads $PRGNAM.SlackBuild.sbopkg. so when the SlackBuild is run, it copies the original SlackBuild to /usr/doc, not the modified SlackBuild. Have a look at the pick_file function for more info.

Quote:
Originally Posted by bamunds View Post
3) sbopkg already recognizes that it has an original file and with original or modified it creates a package name to build using the .build extension. Then in both the process_package and build_package steps it will remove the .build in cleanup statements. This commit will eliminate that extension and cause a new issue, no cleanup in the process_package process of sbopkg.
It actually doesn't eliminate it since it just uses a copy when it creates the $PKGNAM.SlackBuild from PKGNAM.SlackBuild.build. And the cleanup still occurs without issue since the $PRGNAM.SlackBuild.original is mv'd over $PRGNAM.SlackBuild, so the only thing remaining that needs to be removed is $PRGNAM.SlackBuild.build, which is done during the cleanup

Quote:
Originally Posted by bamunds View Post
My concern is that this modification will cause new issues for a corner case that probably should not have been done in the first place.
Out of curiosity, do you consider ensuring the SlackBuilds used to build the package are stored in /usr/doc/$PRGNAM-$VERSION a corner case? Not really relevant to the discussion, just curious.

Quote:
Originally Posted by bamunds View Post
If I've put foot in mouth because of ignorance for reading code, I accept that I look foolish now. But that's how we learn....:-) Cheers.
And no worries on looking foolish, this is a lot of code to go through and I've spent probably more than 30 minutes digging through it all for my response (which I should've spent on my kitchen remodel).
 
Old Today, 05:45 PM   #19
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 420

Rep: Reputation: 91
I'm wondering when the patch is going to be made available to Slackware64-14.2? I ran sbopkg today and it is telling me the 0.38.1 is installed and latest.

Cheers
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
FireFox SlackBuild removes the "/usr/include" directory khronosschoty Slackware 4 12-13-2016 07:51 AM
[SOLVED] IPv6 "link-local" fe80:: vs "unique local address (ULA)" fc00:: + fd00:: psycroptic Linux - Networking 4 08-07-2014 01:51 AM
Ubuntu12.04 Libre office ".odt" & ".doc" file problem rishjain26 Ubuntu 1 05-08-2013 08:32 AM
Slackbuild enconters error with missing "ibus.csh" ShellyCat Slackware 3 01-11-2011 08:07 AM
Compromised? Files "/usr/lib.hwm", "/usr/lib.pwd", "/usr/lib.pwi" Klaus Pforte Linux - Security 4 09-29-2004 12:33 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 07:20 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration