LinuxQuestions.org
Visit Jeremy's Blog.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 01-12-2018, 04:50 PM   #16
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,804

Rep: Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075

I can confirm the behavior before and after the patch was merged.
The patch does fix the issue.
 
Old 01-12-2018, 04:52 PM   #17
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,804

Rep: Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075
Quote:
Originally Posted by bamunds View Post
So @willysr did you find the patch needed for the intel-microcode SBo or was there some error in sbopkg? If the slackbuild I'll want to "note" in my Howto install Intel microcode thread to use latest intel-microcode.SlackBuild or users of sbopkg should now rebuild. Cheers
It has been updated in the last public update, so all you need is to run sbopkg -r and you will get the latest intel-microcode
 
Old 01-12-2018, 04:58 PM   #18
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: Newport News, VA
Distribution: Slackware
Posts: 5,066

Rep: Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864
Quote:
Originally Posted by bamunds View Post
1) I've never had this issue with either hand modifying and executing a slackbuild (and specifically didn't happen with the intel-microcode 20171117 modified to 20180108) or modifying the slackbuild within the sbopkg "Edit Slackbuild" or "Edit Info" functions.
You'd only see this issue if you look at the /usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild after installing a Slackware package created by sbopkg using a SlackBuild you modified and see that your changes aren't there. I just looked at my htpc, which I had modified the SlackBuild for kodi to build 17.6 (instead of the 17.4 that was on the repo). Yet, when I grep that SlackBuild, the version shows 17.4.

Code:
jbhansen@febtober:/$ grep SlackBuild$ /var/log/packages/kodi-17.6-x86_64-1_SBo 
usr/doc/kodi-17.6/kodi.SlackBuild
jbhansen@febtober:/$ grep "VERSION=" /usr/doc/kodi-17.6/kodi.SlackBuild 
VERSION=${VERSION:-17.4}
Quote:
Originally Posted by bamunds View Post
2) Examined the sbopkg code and I don't see any function to "cat" anything to /usr/doc, the slackbuild package does that function. Which is why a hand processed slackbuild will leave the correct files in /usr/doc just as using sbopkg does.
You're correct, the copying of the SlackBuild is not a function of sbopkg, but of the SlackBuild. Per SBo templates, SlackBuilds should contain the following line:

Code:
cat $CWD/$PRGNAM.SlackBuild > $PKG/usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild
However, you're wrong in that a modified SlackBuild using sbopkg will leave the correct file. When you customize a SlackBuild, sbopkg doesn't overwrite the original file. That remains in place untouched. So, sbopkg adds .sbopkg to the modified file, so it reads $PRGNAM.SlackBuild.sbopkg. so when the SlackBuild is run, it copies the original SlackBuild to /usr/doc, not the modified SlackBuild. Have a look at the pick_file function for more info.

Quote:
Originally Posted by bamunds View Post
3) sbopkg already recognizes that it has an original file and with original or modified it creates a package name to build using the .build extension. Then in both the process_package and build_package steps it will remove the .build in cleanup statements. This commit will eliminate that extension and cause a new issue, no cleanup in the process_package process of sbopkg.
It actually doesn't eliminate it since it just uses a copy when it creates the $PKGNAM.SlackBuild from PKGNAM.SlackBuild.build. And the cleanup still occurs without issue since the $PRGNAM.SlackBuild.original is mv'd over $PRGNAM.SlackBuild, so the only thing remaining that needs to be removed is $PRGNAM.SlackBuild.build, which is done during the cleanup

Quote:
Originally Posted by bamunds View Post
My concern is that this modification will cause new issues for a corner case that probably should not have been done in the first place.
Out of curiosity, do you consider ensuring the SlackBuilds used to build the package are stored in /usr/doc/$PRGNAM-$VERSION a corner case? Not really relevant to the discussion, just curious.

Quote:
Originally Posted by bamunds View Post
If I've put foot in mouth because of ignorance for reading code, I accept that I look foolish now. But that's how we learn....:-) Cheers.
And no worries on looking foolish, this is a lot of code to go through and I've spent probably more than 30 minutes digging through it all for my response (which I should've spent on my kitchen remodel).
 
Old 01-17-2018, 04:45 PM   #19
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
I'm wondering when the patch is going to be made available to Slackware64-14.2? I ran sbopkg today and it is telling me the 0.38.1 is installed and latest.

Cheers
 
Old 01-17-2018, 08:28 PM   #20
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,804

Rep: Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075
Unfortunately no, the one we have in master is set for Slackware 15 repository by default
 
Old 01-18-2018, 10:34 AM   #21
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
Can I locally rebuild and apply the patch to the 14.2 version or are other issues introduced for stable's version?
Why sequester a patch that addresses a bug in the stable branch of SBo and Slackware?
 
Old 01-18-2018, 11:05 AM   #22
drumz
Member
 
Registered: Apr 2005
Location: Scottsdale, AZ, USA
Distribution: Slackware
Posts: 206

Original Poster
Rep: Reputation: 52
Quote:
Originally Posted by bamunds View Post
Can I locally rebuild and apply the patch to the 14.2 version or are other issues introduced for stable's version?
Why don't you try it out? To my eyes, this commit looks to be the only change that you'll have to undo to run on 14.2. But you should be checking /etc/sbopkg/sbopkg.conf on any upgrade, anyway, so you should spot that if you decide to upgrade. Just make sure you change the REPO_BRANCH back to 14.2.

For what it's worth, my sbopkg is 0.38.1 plus this patch to /usr/sbin/sbopkg.

I don't want to speak for willysr, but I don't see any major bug fixes since 0.38.1 that warrant another release of sbopkg before Slackware 15.0 is released. But I am looking forward to the next release with all the new features that have been added!
 
Old 01-18-2018, 01:32 PM   #23
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
Thanks, @willysr do you agree that simply applying the original patch listed in this thread is all that is needed for 14.2 and it won't break anything else? If possible, can I simply correct the sbopkg lines directly and not even rebuild?
 
Old 01-18-2018, 02:28 PM   #24
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: Newport News, VA
Distribution: Slackware
Posts: 5,066

Rep: Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864
Quote:
Originally Posted by bamunds View Post
Thanks, @willysr do you agree that simply applying the original patch listed in this thread is all that is needed for 14.2 and it won't break anything else? If possible, can I simply correct the sbopkg lines directly and not even rebuild?
Rebuilding is only required if a binary is produced. sbopkg is just a script, so it can be edited without issue.

Here's a quick run-through of what you'd need to do if you want to use the patch file rather than editing the script manually. First you'd need to download the patch (which I'm renaming to sbopkg.patch to simplify), then remove the lines editing the changelog and THANKS files (since they won't reside in the correct directory structure), which I'm doing with a sed command, then apply the patch.

Code:
su -
wget https://github.com/sbopkg/sbopkg/commit/371284cd8972641ece61957a76fe5629651e6c6a.patch -O sbopkg.patch
sed -i '1,56d;91,112d' sbopkg.patch
cd /usr/sbin
patch -p4 < ~/sbopkg.patch

Last edited by bassmadrigal; 01-19-2018 at 05:16 PM. Reason: Add the home directory for the patch file
 
1 members found this post helpful.
Old 01-19-2018, 03:31 PM   #25
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
Quote:
Originally Posted by bassmadrigal View Post

Code:
su -
wget https://github.com/sbopkg/sbopkg/commit/371284cd8972641ece61957a76fe5629651e6c6a.patch -O sbopkg.patch
sed -i '1,56d;91,112d' sbopkg.patch
cd /usr/sbin
patch -p4 < sbopkg.patch
Are the lines which you sed to add and replace do they line up with the sbopkg version 38.1 for 14.2? Otherwise I was thinking of simply looking at the commit on git and applying the changes at the proper points in the script I have using emacs as the editor. Thanks
 
Old 01-19-2018, 03:49 PM   #26
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: Newport News, VA
Distribution: Slackware
Posts: 5,066

Rep: Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864
Quote:
Originally Posted by bamunds View Post
Are the lines which you sed to add and replace do they line up with the sbopkg version 38.1 for 14.2? Otherwise I was thinking of simply looking at the commit on git and applying the changes at the proper points in the script I have using emacs as the editor. Thanks
Yes, this works perfectly for 14.2. The lines I use sed to remove are actually related to updating the THANKS and changelog files. The only reason I removed them is because the files aren't in the same location in the package as they are in the source, so the when running patch, it would complain it couldn't find them and then ask you where they are. I figured that was too much work, so it was easier to just not have those two files edited.

The patch lines doesn't match up exactly, but the patch program is smart enough to offset the line numbers to match what's in the latest stable binary. You'll see the following output stating it had to adjust 16 lines for each bit of code, but it still applies fine

Code:
patching file sbopkg
Hunk #1 succeeded at 3396 (offset -16 lines).
Hunk #2 succeeded at 3461 (offset -16 lines).
Hunk #3 succeeded at 3486 (offset -16 lines).
 
Old 01-19-2018, 04:02 PM   #27
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
OK, thanks, I still have great respect for your ongoing support and help to all the users here. Even if we sometimes have differing opinions.

For anyone else following this thread the last command needs the sbopatch file location prepended.

../usr/sbin# patch -p4 < /{folder where sbopkg.patch is located]/sbopkg.patch

It did work and the results where as you stated.

How did the kitchen remodel go?

Last edited by bamunds; 01-19-2018 at 04:11 PM.
 
Old 01-19-2018, 05:20 PM   #28
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: Newport News, VA
Distribution: Slackware
Posts: 5,066

Rep: Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864Reputation: 2864
Quote:
Originally Posted by bamunds View Post
OK, thanks, I still have great respect for your ongoing support and help to all the users here. Even if we sometimes have differing opinions.
No worries. I figure with how much I'm on this forum and post that I'll have differing opinions with people, but I'm here to help people. The other discussions, while I usually do somewhat enjoy them, are not my primary focus on here. And I have no problem still helping people even if we have differing opinions

Quote:
Originally Posted by bamunds View Post
For anyone else following this thread the last command needs the sbopatch file location prepended.

../usr/sbin# patch -p4 < /{folder where sbopkg.patch is located]/sbopkg.patch

It did work and the results where as you stated.
Whoops! My bad. That's what I get for typing without testing (although, I did test the patch on a local sbopkg script so I knew it worked). I added the location in the previous post so now it should be:

Code:
patch -p4 < ~/sbopkg.patch
That should work if you copy and paste all the commands, otherwise you might need to be a bit more specific with the location.

Quote:
Originally Posted by bamunds View Post
How did the kitchen remodel go?
It went great and we're pretty happy with it. Thanks for asking
 
Old 01-19-2018, 11:50 PM   #29
bamunds
Member
 
Registered: Sep 2013
Location: Mounds View MN
Distribution: Slackware64-14.2 Multilib
Posts: 522

Rep: Reputation: 131Reputation: 131
Glad to hear the kitchen went well. Hopefully it wasn't too cool for the final painting, or wallpaper, or if really extensive..exterior alerations. Cheers.
 
Old 01-20-2018, 12:12 AM   #30
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 3,804

Rep: Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075Reputation: 1075
Quote:
Originally Posted by bamunds View Post
Thanks, @willysr do you agree that simply applying the original patch listed in this thread is all that is needed for 14.2 and it won't break anything else? If possible, can I simply correct the sbopkg lines directly and not even rebuild?
Yes, that patch is all you need to apply to fix the issue, although the one is master looks more interesting
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
FireFox SlackBuild removes the "/usr/include" directory khronosschoty Slackware 4 12-13-2016 06:51 AM
[SOLVED] IPv6 "link-local" fe80:: vs "unique local address (ULA)" fc00:: + fd00:: psycroptic Linux - Networking 4 08-07-2014 12:51 AM
Ubuntu12.04 Libre office ".odt" & ".doc" file problem rishjain26 Ubuntu 1 05-08-2013 07:32 AM
Slackbuild enconters error with missing "ibus.csh" ShellyCat Slackware 3 01-11-2011 07:07 AM
Compromised? Files "/usr/lib.hwm", "/usr/lib.pwd", "/usr/lib.pwi" Klaus Pforte Linux - Security 4 09-28-2004 11:33 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 08:19 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration