SBo scripts not building on current (read 1st post, pls)

Ilgar · 01-16-2022, 04:34 PM

gnubg does not compile because it can not download the source. The link has probably changed. The following link works and the package compiles fine (after updating VERSION to 1.06.002):

Code:

https://ftp.gnu.org/gnu/gnubg/gnubg-release-1.06.002-sources.tar.gz

Ilgar · 01-16-2022, 04:49 PM

coq 8.9.0 does not build:

Code:

Num library not installed, required for OCaml 4.06 or later

This dependency does not exist in the SBo repo. The maintainer had told me in May that he would submit his ocaml-num package, but maybe he forgot. I'm gonna remind him...

hpfeil · 01-16-2022, 05:37 PM

Steghide compile errors traced to "const" instead of "constexpr" in Arguments.h.

Code:

Arguments.h:103:41: error: ‘constexpr’ needed for in-class initialization of static data member ‘const float Arguments::Default_Goal’ of non-integral type

Please add constexpr.patch to steghide.SlackBuild.

=-=-=-=-=-==-=-constexpr.patch=-=-=-=-=-

Code:

--- steghide-0.5.1-orig/src/Arguments.h	2003-10-11 14:23:57.000000000 -0700
+++ steghide-0.5.1/src/Arguments.h	2022-01-16 16:15:28.042468300 -0700
@@ -100,7 +100,7 @@
 	static const VERBOSITY	Default_Verbosity = NORMAL ;
 	static const unsigned long	Default_Radius = 0 ; // there is no default radius for all file formats
 	static const unsigned int	Max_Algorithm = 3 ;
-	static const float		Default_Goal = 100.0 ;
+	static constexpr float		Default_Goal = 100.0 ;
 	static const DEBUGCOMMAND	Default_DebugCommand = NONE ;
 	static const bool		Default_Check = false ;
 	static const unsigned int	Default_DebugLevel = 0 ;

-==-=-=-=-=-=-=-=-=====-=-=-=-==-=-=-=

hpfeil · 01-16-2022, 05:51 PM

ProgressOutput.h presents itself.

Call it what you will, progconstexpr.patch, rename the above argconstexpr.patch or maybe combine them into ponce.patch?

Code:

--- steghide-0.5.1-orig/src/ProgressOutput.h	2003-09-28 08:30:30.000000000 -0700
+++ steghide-0.5.1/src/ProgressOutput.h	2022-01-16 16:45:19.032378699 -0700
@@ -64,7 +64,7 @@
 	 **/
 	void done (float rate, float avgweight = NoAvgWeight) const ;
 
-	static const float NoAvgWeight = -1.0 ;
+	static constexpr float NoAvgWeight = -1.0 ;
 
 	protected:
 	std::string vcompose (const char *msgfmt, va_list ap) const ;

willysr · 01-16-2022, 07:28 PM

Quote:

Originally Posted by Ilgar

gnubg does not compile because it can not download the source. The link has probably changed. The following link works and the package compiles fine (after updating VERSION to 1.06.002):

Code:

https://ftp.gnu.org/gnu/gnubg/gnubg-release-1.06.002-sources.tar.gz

i can't get this source as well

willysr · 01-16-2022, 07:32 PM

Quote:

Originally Posted by hpfeil

Steghide compile errors traced to "const" instead of "constexpr" in Arguments.h.

Code:

Arguments.h:103:41: error: ‘constexpr’ needed for in-class initialization of static data member ‘const float Arguments::Default_Goal’ of non-integral type

Please add constexpr.patch to steghide.SlackBuild.

=-=-=-=-=-==-=-constexpr.patch=-=-=-=-=-

Code:

--- steghide-0.5.1-orig/src/Arguments.h	2003-10-11 14:23:57.000000000 -0700
+++ steghide-0.5.1/src/Arguments.h	2022-01-16 16:15:28.042468300 -0700
@@ -100,7 +100,7 @@
 	static const VERBOSITY	Default_Verbosity = NORMAL ;
 	static const unsigned long	Default_Radius = 0 ; // there is no default radius for all file formats
 	static const unsigned int	Max_Algorithm = 3 ;
-	static const float		Default_Goal = 100.0 ;
+	static constexpr float		Default_Goal = 100.0 ;
 	static const DEBUGCOMMAND	Default_DebugCommand = NONE ;
 	static const bool		Default_Check = false ;
 	static const unsigned int	Default_DebugLevel = 0 ;

-==-=-=-=-=-=-=-=-=====-=-=-=-==-=-=-=

I have this patch already, but it was not enabled for 14.2. I have it now enabled for 15.0. Thanks for spotting it

marav · 01-16-2022, 07:35 PM

Quote:

Originally Posted by willysr

i can't get this source as well

Just FYI
No issue here with this link

https://ftp.gnu.org/gnu/gnubg/

willysr · 01-16-2022, 08:02 PM

ok, turns out my bad connection

Ilgar · 01-17-2022, 04:48 PM

scipy 1.1.0 does not compile:

Code:

Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)
scipy/sparse/linalg/eigen/arpack/ARPACK/SRC/dsaup2.f:751:39:

  449 |             call dvout (logfil, 1, rnorm, ndigit,
      |                                   2
......
  751 |                call dvout (logfil, np, bounds, ndigit,
      |                                       1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)
error: Command "/usr/bin/gfortran -Wall -g -ffixed-form -fno-second-underscore -fPIC -O3 -funroll-loops -Iscipy/sparse/linalg/eigen/arpack/ARPACK/SRC -I/usr/lib64/python2.7/site-packages/numpy/core/include -c -c scipy/sparse/linalg/eigen/arpack/ARPACK/SRC/dsaup2.f -o build/temp.linux-x86_64-2.7/scipy/sparse/linalg/eigen/arpack/ARPACK/SRC/dsaup2.o" failed with exit status 1

Seems like an incompatibility in Fortran compilation with GCC 10, see here. I was able to fix it using the build option

Code:

FFLAGS="-fallow-argument-mismatch -fPIC"

The second one was necessary to avoid a second error that popped up at a different place after using the first option.

I also suggest bumping version to 1.2.2 (which I successfully tested), the last one to support Python 2.7.

hpfeil · 01-19-2022, 03:17 PM

Pybind11.SlackBuild fails to build, something about

package init file 'pybind11/include/pybind11/__init__.py' not found (or not a regular file)
package init file 'pybind11/include/pybind11/detail/__init__.py' not found (or not a regular file)
package init file 'pybind11/include/pybind11/stl/__init__.py' not found (or not a regular file)
package init file 'pybind11/share/cmake/pybind11/__init__.py' not found (or not a regular file)

File "/usr/lib64/python3.9/site-packages/setuptools/command/build_py.py", line 127, in build_package_data
srcfile in self.distribution.convert_2to3_doctests):
AttributeError: 'Distribution' object has no attribute 'convert_2to3_doctests'

I cloned the pybind11 2.9.0 git, which has a CMakeLists.txt. Cmake-GUI created a makefile that compiled no problem.

MDKDIO · 01-19-2022, 04:12 PM

veracrypt (Ponce repo)

In order to build 1.25.7 line 95 in the slackbuild need a minor edit

Code:

$PKG/usr/share/veracrypt/doc/* \
to
$PKG/usr/share/doc/veracrypt/* \

Else from that it builds fine

chris.willing · 01-19-2022, 06:31 PM

Quote:

Originally Posted by hpfeil

Pybind11.SlackBuild fails to build, something about

package init file 'pybind11/include/pybind11/__init__.py' not found (or not a regular file)
package init file 'pybind11/include/pybind11/detail/__init__.py' not found (or not a regular file)
package init file 'pybind11/include/pybind11/stl/__init__.py' not found (or not a regular file)
package init file 'pybind11/share/cmake/pybind11/__init__.py' not found (or not a regular file)

File "/usr/lib64/python3.9/site-packages/setuptools/command/build_py.py", line 127, in build_package_data
srcfile in self.distribution.convert_2to3_doctests):
AttributeError: 'Distribution' object has no attribute 'convert_2to3_doctests'

I cloned the pybind11 2.9.0 git, which has a CMakeLists.txt. Cmake-GUI created a makefile that compiled no problem.

I just rebuilt it without issue using the existing SlackBuild in SBo master for version 2.9.0.

Are you perhaps using the 14.2 SlackBuild which uses version 2.5.0?

chris

montagdude · 01-19-2022, 08:54 PM

I'm the maintainer of sbbdep. Someone (Giancarolo Dessi) informed me that the following patch is needed to build it on -current with the latest versions of gcc. I have confirmed the issue and that the patch corrects the build. Could you (Ponce) add this to your repo?

value.cpp.patch:

Code:

--- libsl3/src/sl3/value.cpp	2017-08-05 14:01:24.000000000 -0400
+++ libsl3/src/sl3/value.cpp.new	2022-01-19 21:38:19.648276809 -0500
@@ -10,6 +10,8 @@
 #include <sl3/value.hpp>
 
 #include <algorithm>
+#include <stdexcept>
+#include <limits>
 #include <climits>
 #include <cmath>
 #include <iomanip>

And the patch to include this in the SlackBuild:

Code:

--- sbbdep.SlackBuild	2022-01-19 21:54:04.649246402 -0500
+++ sbbdep.SlackBuild.new	2022-01-19 21:48:03.040104683 -0500
@@ -86,6 +86,8 @@
  \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
   -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
+# Fix issue with gcc 11+
+patch -p0 < $CWD/value.cpp.patch
 
 mkdir -p build
 cd build

willysr · 01-20-2022, 01:08 AM

please push to a github/gitlab branch and make a PR/MR

ponce · 01-20-2022, 01:34 AM

Quote:

Originally Posted by montagdude

I'm the maintainer of sbbdep. Someone (Giancarolo Dessi) informed me that the following patch is needed to build it on -current with the latest versions of gcc. I have confirmed the issue and that the patch corrects the build. Could you (Ponce) add this to your repo?

value.cpp.patch:

Code:

--- libsl3/src/sl3/value.cpp	2017-08-05 14:01:24.000000000 -0400
+++ libsl3/src/sl3/value.cpp.new	2022-01-19 21:38:19.648276809 -0500
@@ -10,6 +10,8 @@
 #include <sl3/value.hpp>
 
 #include <algorithm>
+#include <stdexcept>
+#include <limits>
 #include <climits>
 #include <cmath>
 #include <iomanip>

And the patch to include this in the SlackBuild:

Code:

--- sbbdep.SlackBuild	2022-01-19 21:54:04.649246402 -0500
+++ sbbdep.SlackBuild.new	2022-01-19 21:48:03.040104683 -0500
@@ -86,6 +86,8 @@
  \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
   -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
+# Fix issue with gcc 11+
+patch -p0 < $CWD/value.cpp.patch
 
 mkdir -p build
 cd build

Quote:

Originally Posted by willysr

please push to a github/gitlab branch and make a PR/MR

np for that, I spotted this also on slacky.eu, where Giancarlo reported it first: I pushed it in my branch, thanks!