LinuxQuestions.org

LinuxQuestions.org (/questions/)
-   Slackware (https://www.linuxquestions.org/questions/slackware-14/)
-   -   SBo scripts not building on current (read 1st post, pls) (https://www.linuxquestions.org/questions/slackware-14/sbo-scripts-not-building-on-current-read-1st-post-pls-4175561999/)

Poprocks 09-25-2019 04:59 PM

Quote:

Originally Posted by Skaendo (Post 6040631)
I'm not sure but I think that something in Slackware itself might need to be fixed. I am having a hard time building a bunch of packages off of SBo, and ones that are updated in Ponce's repo. Here are 2 and I'll have a couple more later. (inkscape, simple-scan and maybe qTox and libindicator3)

libido3 (full log)
packagekit (ponce repo) (full log)

Note that these were built with -j8, but I have done it with both -j8 and -j1 and it fails just the same.

EDIT: This build system is a fresh clean install as of update: Mon Sep 23 22:15:50 UTC 2019

You must have -Werror set somewhere in your CFLAGS. See if you can pinpoint it and get rid of it.

Skaendo 09-25-2019 05:26 PM

Quote:

Originally Posted by Poprocks (Post 6040637)
You must have -Werror set somewhere in your CFLAGS. See if you can pinpoint it and get rid of it.

I am using slackbuilds straight off of SBo and ponce's repo. I haven't changed a thing.

It's going to be a while before I can do anything else, computer will be busy for ~4 hours.

Poprocks 09-25-2019 05:51 PM

Quote:

Originally Posted by Skaendo (Post 6040646)
I am using slackbuilds straight off of SBo and your repo. I haven't changed a thing.

It's going to be a while before I can do anything else, computer will be busy for ~4 hours.

My comment above was a quick cursory reply based on looking at the failure particularly for libido3. Slackware -current uses a very recent version of gcc. In my experience as newer versions of gcc come out, the syntax gets stricter and stricter. In the case of libido3, the code seems to date back to 2016. I actually can't find the source anywhere except on http://unrealize.co.uk, which is a private server for Slackbuilds and scripts and is not the canonical home of the source.

You have to remember that by running -current and SBo-git, you're essentially volunteering to be part of the testing community. If you don't care to do that, you can always stick with stable releases of Slackware. Slackware isn't doing anything special here. Just using very recent versions of upstream software with little to no patching. Sometimes that causes breakages, since older source code is often written making assumptions that what builds now will build forever. This cannot be further from the truth!

For the record, I cannot reproduce this - libido3 builds fine on my machine. Looking at the source, some of the autotools scripts do some weird magic that sets what it calls "MAINTAINER_CFLAGS" which insert -Werror in certain circumstances. Looking at my Makefile generated after running autogen.sh and ./configure (with the CFLAGS defined in the SlackBuild), my CFLAGS are respected. You might want to poke at your Makefile which was generated by autotools and ensure that no monkey business is happening with your CFLAGS. If it is, you might need to hackishly patch your .am files to remove references to Werror to get this thing to build.

willysr 09-25-2019 07:30 PM

Quote:

Originally Posted by Skaendo (Post 6040646)
I am using slackbuilds straight off of SBo and ponce's repo. I haven't changed a thing.

It's going to be a while before I can do anything else, computer will be busy for ~4 hours.

See here: https://github.com/mateslackbuilds/m...70b680fe775c0d

I didn't realize we have libido in SBo, so i went to make my own for MSB.

Skaendo 09-25-2019 07:50 PM

Quote:

Originally Posted by willysr (Post 6040670)
See here: https://github.com/mateslackbuilds/m...70b680fe775c0d

I didn't realize we have libido in SBo, so i went to make my own for MSB.

Yes, your ido works fine here.

libindicator3 (ponce's repo) (full log)
simple-scan (full log)

This is on a fresh install of 'Wed Sep 25 22:22:51 UTC 2019' now. Still getting same errors.

willysr 09-25-2019 08:07 PM

yes, still working on libindicator here on MSB as well

Try this patch from upstream:
Code:

commit ce4654550ca72c1fd0ddd93bd36ee7562314b02d
Author: Matthias Klose <doko@ubuntu.com>
Date:  Tue Sep 3 18:14:42 2019 +0200

    Import patches-unapplied version 16.10.0+18.04.20180321.1-0ubuntu3 to ubuntu/eoan-proposed
   
    Imported using git-ubuntu import.
   
    Changelog parent: b7f44f0040f0e9b62bca17a25ca1c8923a20fed5
   
    New changelog entries:
      * Don't build with -Werror.

diff --git a/debian/changelog b/debian/changelog
index dfe45ab..0298a14 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+libindicator (16.10.0+18.04.20180321.1-0ubuntu3) eoan; urgency=medium
+
+  * Don't build with -Werror.
+
+ -- Matthias Klose <doko@ubuntu.com>  Tue, 03 Sep 2019 18:14:42 +0200
+
 libindicator (16.10.0+18.04.20180321.1-0ubuntu2) eoan; urgency=medium
 
  * No-change rebuild to drop multiarch-support dependency.
diff --git a/libindicator/Makefile.am b/libindicator/Makefile.am
index a3e58d7..4bbfd0b 100644
--- a/libindicator/Makefile.am
+++ b/libindicator/Makefile.am
@@ -65,7 +65,7 @@ libindicator_la_CFLAGS = \
        $(LIBINDICATOR_CFLAGS) \
        $(COVERAGE_CFLAGS) \
        -DG_LOG_DOMAIN=\"libindicator\" \
-        -Wall -Werror -Wno-error=deprecated-declarations
+        -Wall -Wno-error=deprecated-declarations
 
 libindicator_la_LIBADD = \
        $(LIBINDICATOR_LIBS) \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 96825f3..ecb53b0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -39,7 +39,7 @@ test_loader_SOURCES = \
        test-loader.c
 
 test_loader_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(builddir)\""
 
@@ -58,7 +58,7 @@ test_desktop_shortcuts_SOURCES = \
        test-desktop-shortcuts.c
 
 test_desktop_shortcuts_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        -DSRCDIR="\"$(srcdir)\"" \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(abs_builddir)\""
@@ -92,7 +92,7 @@ libdummy_indicator_blank_la_SOURCES = \
        dummy-indicator-blank.c
 
 libdummy_indicator_blank_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_blank_la_LIBADD = \
@@ -112,7 +112,7 @@ libdummy_indicator_null_la_SOURCES = \
        dummy-indicator-null.c
 
 libdummy_indicator_null_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_null_la_LIBADD = \
@@ -132,7 +132,7 @@ libdummy_indicator_signaler_la_SOURCES = \
        dummy-indicator-signaler.c
 
 libdummy_indicator_signaler_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_signaler_la_LIBADD = \
@@ -152,7 +152,7 @@ libdummy_indicator_simple_la_SOURCES = \
        dummy-indicator-simple.c
 
 libdummy_indicator_simple_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_simple_la_LIBADD = \
@@ -173,7 +173,7 @@ libdummy_indicator_entry_func_la_SOURCES = \
        dummy-indicator-entry-func.h
 
 libdummy_indicator_entry_func_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_entry_func_la_LIBADD = \
@@ -193,7 +193,7 @@ libdummy_indicator_visible_la_SOURCES = \
        dummy-indicator-visible.c
 
 libdummy_indicator_visible_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_visible_la_LIBADD = \
@@ -215,7 +215,7 @@ service_shutdown_timeout_SOURCES = \
        service-shutdown-timeout.c
 
 service_shutdown_timeout_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_shutdown_timeout_LDADD = \
@@ -241,7 +241,7 @@ service_manager_no_connect_SOURCES = \
        service-manager-no-connect.c
 
 service_manager_no_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_no_connect_LDADD = \
@@ -273,7 +273,7 @@ service_manager_connect_SOURCES = \
        service-manager-connect.c
 
 service_manager_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_connect_LDADD = \
@@ -287,7 +287,7 @@ service_manager_connect_service_SOURCES = \
        service-manager-connect-service.c
 
 service_manager_connect_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_connect_service_LDADD = \
@@ -320,7 +320,7 @@ service_version_manager_SOURCES = \
        service-version-manager.c
 
 service_version_manager_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_manager_LDADD = \
@@ -335,7 +335,7 @@ service_version_bad_service_SOURCES = \
        service-version-bad-service.c
 
 service_version_bad_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_bad_service_LDADD = \
@@ -350,7 +350,7 @@ service_version_good_service_SOURCES = \
        service-version-good-service.c
 
 service_version_good_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_good_service_LDADD = \
@@ -377,7 +377,7 @@ service_version_multiwatch_manager_SOURCES = \
        service-version-multiwatch-manager.c
 
 service_version_multiwatch_manager_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_manager_LDADD = \
@@ -392,7 +392,7 @@ service_version_multiwatch_manager_impolite_SOURCES = \
        service-version-multiwatch-manager-impolite.c
 
 service_version_multiwatch_manager_impolite_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_manager_impolite_LDADD = \
@@ -407,7 +407,7 @@ service_version_multiwatch_service_SOURCES = \
        service-version-multiwatch-service.c
 
 service_version_multiwatch_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_service_LDADD = \
@@ -433,7 +433,7 @@ service_manager_nostart_connect_SOURCES = \
        service-manager-nostart-connect.c
 
 service_manager_nostart_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_nostart_connect_LDADD = \
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 8df5445..d487c59 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -13,7 +13,7 @@ indicator_loader_SOURCES = \
        indicator-loader.c
 
 indicator_loader_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(builddir)\""


Skaendo 09-25-2019 09:12 PM

Quote:

Originally Posted by willysr (Post 6040681)
Try this patch from upstream:

Yep, libindicator3 patch works good.

I had to remove the first patch to /debian/changelog but I don't think that I'm missing too much there.

Skaendo 09-25-2019 09:21 PM

Here is a patch for simple-scan:

from here: https://gitlab.gnome.org/GNOME/simpl...200f612863c814

Code:

From 47d3532459863e3b0bc1c7fd3a200f612863c814 Mon Sep 17 00:00:00 2001
From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Sat, 14 Sep 2019 20:03:47 +0200
Subject: [PATCH] libwepmix: Fix use of possibly unassigned local variable
 'data'

---
 src/libwebpmux.vapi | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/libwebpmux.vapi b/src/libwebpmux.vapi
index f2461a2..42d2886 100644
--- a/src/libwebpmux.vapi
+++ b/src/libwebpmux.vapi
@@ -61,9 +61,7 @@ namespace WebP
        [CCode (cname = "vala_set_image")]
        public MuxError set_image (uint8[] bitstream, bool copy_data)
        {
-                Data data;
-                data.bytes = bitstream;
-                data.size = bitstream.length;
+                Data data = { bitstream, bitstream.length };
                return _set_image (data, copy_data);
        }
 
@@ -89,9 +87,7 @@ namespace WebP
        public MuxError set_chunk (string fourcc, uint8[] chunk_data, bool copy_data)
        requires (fourcc.length == 4)
        {
-            Data data;
-            data.bytes = chunk_data;
-            data.size = chunk_data.length;
+            Data data = { chunk_data ,chunk_data.length };
            return _set_chunk ((uchar[]) fourcc, data, copy_data);
        }
 
--
2.22.0


Skaendo 09-25-2019 09:28 PM

inkscape is broken as well, but log is too big for pastebin. I can upload it to mega if needed.

Poprocks 09-25-2019 09:44 PM

I tried building libido3 on my laptop which is running -current as well. It did produce the same error as you, whereas on my tablet it worked. I have no idea why, as both are running the same versions of gcc and the autotools. I think my tablet is a bit behind on -current though, so maybe some other link in the chain I'm not seeing has been updated since I last updated my tablet which is causing breakage. Anyway, this patch gets it to build for me:

libido3-16.10-drop-werror.patch

Quote:

--- libido3-16.10/src/Makefile.am.orig 2019-09-25 22:17:31.647062896 -0400
+++ libido3-16.10/src/Makefile.am 2019-09-25 22:17:38.746062751 -0400
@@ -66,7 +66,7 @@
$(GCC_FLAGS) \
$(GTK_CFLAGS) \
$(MAINTAINER_CFLAGS) \
- -Wall -Werror -Wextra -Wno-unused-parameter -Wno-error=deprecated-declarations
+ -Wall -Wextra -Wno-unused-parameter -Wno-error=deprecated-declarations

AM_CFLAGS = \
$(COVERAGE_CFLAGS)

Skaendo 09-25-2019 09:49 PM

Quote:

Originally Posted by Poprocks (Post 6040705)
I tried building libido3 on my laptop which is running -current as well. It did produce the same error as you, whereas on my tablet it worked. I have no idea why, as both are running the same versions of gcc and the autotools. I think my tablet is a bit behind on -current though, so maybe some other link in the chain I'm not seeing has been updated since I last updated my tablet which is causing breakage. Anyway, this patch gets it to build for me:

libido3-16.10-drop-werror.patch

Yea, Willy has it fixed here: https://www.linuxquestions.org/quest...ml#post6040670

Poprocks 09-25-2019 09:54 PM

Quote:

Originally Posted by Skaendo (Post 6040707)

Oh cool! I totally missed that.

The bump to glib2 2.62 seems to be the culprit. See: https://bugs.debian.org/cgi-bin/bugr...cgi?bug=940163

I'm sure Pat is totally kicking himself for dropping GNOME all those years ago... /s

willysr 09-25-2019 10:12 PM

yeah, MATE devs are also working on deprecations over the past few releases

ponce 09-26-2019 08:30 AM

Quote:

Originally Posted by Skaendo (Post 6040704)
inkscape is broken as well, but log is too big for pastebin. I can upload it to mega if needed.

you can update it to 1.0b1, note the additional dependencies
Code:

diff --git a/graphics/inkscape/inkscape.SlackBuild b/graphics/inkscape/inkscape.SlackBuild
index 2b53dc793d..698a5fb3db 100644
--- a/graphics/inkscape/inkscape.SlackBuild
+++ b/graphics/inkscape/inkscape.SlackBuild
@@ -23,8 +23,8 @@
 # ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 PRGNAM=inkscape
-PRGSUB=_A6N0YOn
-VERSION=${VERSION:-0.92.4}
+PRGSUB=
+VERSION=${VERSION:-1.0b1}
 BUILD=${BUILD:-1}
 TAG=${TAG:-_SBo}
 
@@ -70,32 +70,40 @@ find -L . \
  \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
  -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
-./autogen.sh
-
-CFLAGS="$SLKCFLAGS" \
-CXXFLAGS="$SLKCFLAGS -std=c++11" \
-./configure \
-  --prefix=/usr \
-  --libdir=/usr/lib${LIBDIRSUFFIX} \
-  --sysconfdir=/etc \
-  --localstatedir=/var \
-  --mandir=/usr/man \
-  --docdir=/usr/doc/$PRGNAM-$VERSION \
-  --build=$ARCH-slackware-linux
-
-make
-make install DESTDIR=$PKG
+mkdir -p build
+cd build
+  cmake \
+    -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \
+    -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \
+    -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \
+    -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
+    -DCMAKE_C_FLAGS:STRING="$SLKCFLAGS" \
+    -DCMAKE_CXX_FLAGS:STRING="$SLKCFLAGS" \
+    -DCMAKE_INSTALL_PREFIX=/usr \
+    -DLIB_INSTALL_DIR=/usr/lib${LIBDIRSUFFIX} \
+    -DINCLUDE_INSTALL_DIR=/usr/include \
+    -DLIB_SUFFIX=${LIBDIRSUFFIX} \
+    -DSYSCONF_INSTALL_DIR=/etc \
+    -DSHARE_INSTALL_PREFIX=/usr/share \
+    -DBUILD_SHARED_LIBS:BOOL=OFF \
+    -DMAN_INSTALL_DIR=/usr/man \
+    ..
+  make
+  make install DESTDIR=$PKG
+cd ..
+
+mv $PKG/usr/share/man $PKG/usr/man
 
 find $PKG | xargs file | grep -e "executable" -e "shared object" | grep ELF \
  | cut -f 1 -d : | xargs strip --strip-unneeded 2> /dev/null || true
 
-find $PKG/usr/man -type f -exec gzip -9 {} \;
-
 mkdir -p $PKG/usr/doc/$PRGNAM-$VERSION
 cp -a \
-  AUTHORS COPYING* INSTALL NEWS README TRANSLATORS doc/* \
+  AUTHORS COPYING* *.md TRANSLATORS doc/* \
  $PKG/usr/doc/$PRGNAM-$VERSION
 cat $CWD/$PRGNAM.SlackBuild > $PKG/usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild
+mv $PKG/usr/share/doc/$PRGNAM/* $PKG/usr/doc/$PRGNAM-$VERSION/
+rm -fR $PKG/usr/share/doc
 find $PKG/usr/doc -name "Makefile*" -exec rm {} \;
 find $PKG/usr/doc -type f -exec chmod 644 {} \;
 
diff --git a/graphics/inkscape/inkscape.info b/graphics/inkscape/inkscape.info
index c206ffccb0..c5de45be23 100644
--- a/graphics/inkscape/inkscape.info
+++ b/graphics/inkscape/inkscape.info
@@ -1,10 +1,10 @@
 PRGNAM="inkscape"
-VERSION="0.92.4"
+VERSION="1.0b1"
 HOMEPAGE="http://www.inkscape.org/"
-DOWNLOAD="https://inkscape.org/gallery/item/13330/inkscape-0.92.4_A6N0YOn.tar.bz2"
-MD5SUM="ac30f6d5747fd9c620c00dad500f414f"
+DOWNLOAD="http://ponce.cc/slackware/sources/repo/inkscape-1.0b1.tar.bz2"
+MD5SUM="54291b042406207659c340c31ea95c38"
 DOWNLOAD_x86_64=""
 MD5SUM_x86_64=""
-REQUIRES="lxml numpy"
+REQUIRES="gdl double-conversion lxml numpy potrace"
 MAINTAINER="Fernando Lopez Jr."
 EMAIL="fernando.lopezjr@gmail.com"


ponce 09-26-2019 09:00 AM

Quote:

Originally Posted by willysr (Post 6040681)
Try this patch from upstream:
Code:

commit ce4654550ca72c1fd0ddd93bd36ee7562314b02d
Author: Matthias Klose <doko@ubuntu.com>
Date:  Tue Sep 3 18:14:42 2019 +0200

    Import patches-unapplied version 16.10.0+18.04.20180321.1-0ubuntu3 to ubuntu/eoan-proposed
   
    Imported using git-ubuntu import.
   
    Changelog parent: b7f44f0040f0e9b62bca17a25ca1c8923a20fed5
   
    New changelog entries:
      * Don't build with -Werror.

diff --git a/debian/changelog b/debian/changelog
index dfe45ab..0298a14 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+libindicator (16.10.0+18.04.20180321.1-0ubuntu3) eoan; urgency=medium
+
+  * Don't build with -Werror.
+
+ -- Matthias Klose <doko@ubuntu.com>  Tue, 03 Sep 2019 18:14:42 +0200
+
 libindicator (16.10.0+18.04.20180321.1-0ubuntu2) eoan; urgency=medium
 
  * No-change rebuild to drop multiarch-support dependency.
diff --git a/libindicator/Makefile.am b/libindicator/Makefile.am
index a3e58d7..4bbfd0b 100644
--- a/libindicator/Makefile.am
+++ b/libindicator/Makefile.am
@@ -65,7 +65,7 @@ libindicator_la_CFLAGS = \
        $(LIBINDICATOR_CFLAGS) \
        $(COVERAGE_CFLAGS) \
        -DG_LOG_DOMAIN=\"libindicator\" \
-        -Wall -Werror -Wno-error=deprecated-declarations
+        -Wall -Wno-error=deprecated-declarations
 
 libindicator_la_LIBADD = \
        $(LIBINDICATOR_LIBS) \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 96825f3..ecb53b0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -39,7 +39,7 @@ test_loader_SOURCES = \
        test-loader.c
 
 test_loader_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(builddir)\""
 
@@ -58,7 +58,7 @@ test_desktop_shortcuts_SOURCES = \
        test-desktop-shortcuts.c
 
 test_desktop_shortcuts_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        -DSRCDIR="\"$(srcdir)\"" \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(abs_builddir)\""
@@ -92,7 +92,7 @@ libdummy_indicator_blank_la_SOURCES = \
        dummy-indicator-blank.c
 
 libdummy_indicator_blank_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_blank_la_LIBADD = \
@@ -112,7 +112,7 @@ libdummy_indicator_null_la_SOURCES = \
        dummy-indicator-null.c
 
 libdummy_indicator_null_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_null_la_LIBADD = \
@@ -132,7 +132,7 @@ libdummy_indicator_signaler_la_SOURCES = \
        dummy-indicator-signaler.c
 
 libdummy_indicator_signaler_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_signaler_la_LIBADD = \
@@ -152,7 +152,7 @@ libdummy_indicator_simple_la_SOURCES = \
        dummy-indicator-simple.c
 
 libdummy_indicator_simple_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_simple_la_LIBADD = \
@@ -173,7 +173,7 @@ libdummy_indicator_entry_func_la_SOURCES = \
        dummy-indicator-entry-func.h
 
 libdummy_indicator_entry_func_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_entry_func_la_LIBADD = \
@@ -193,7 +193,7 @@ libdummy_indicator_visible_la_SOURCES = \
        dummy-indicator-visible.c
 
 libdummy_indicator_visible_la_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 libdummy_indicator_visible_la_LIBADD = \
@@ -215,7 +215,7 @@ service_shutdown_timeout_SOURCES = \
        service-shutdown-timeout.c
 
 service_shutdown_timeout_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_shutdown_timeout_LDADD = \
@@ -241,7 +241,7 @@ service_manager_no_connect_SOURCES = \
        service-manager-no-connect.c
 
 service_manager_no_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_no_connect_LDADD = \
@@ -273,7 +273,7 @@ service_manager_connect_SOURCES = \
        service-manager-connect.c
 
 service_manager_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_connect_LDADD = \
@@ -287,7 +287,7 @@ service_manager_connect_service_SOURCES = \
        service-manager-connect-service.c
 
 service_manager_connect_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_connect_service_LDADD = \
@@ -320,7 +320,7 @@ service_version_manager_SOURCES = \
        service-version-manager.c
 
 service_version_manager_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_manager_LDADD = \
@@ -335,7 +335,7 @@ service_version_bad_service_SOURCES = \
        service-version-bad-service.c
 
 service_version_bad_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_bad_service_LDADD = \
@@ -350,7 +350,7 @@ service_version_good_service_SOURCES = \
        service-version-good-service.c
 
 service_version_good_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_good_service_LDADD = \
@@ -377,7 +377,7 @@ service_version_multiwatch_manager_SOURCES = \
        service-version-multiwatch-manager.c
 
 service_version_multiwatch_manager_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_manager_LDADD = \
@@ -392,7 +392,7 @@ service_version_multiwatch_manager_impolite_SOURCES = \
        service-version-multiwatch-manager-impolite.c
 
 service_version_multiwatch_manager_impolite_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_manager_impolite_LDADD = \
@@ -407,7 +407,7 @@ service_version_multiwatch_service_SOURCES = \
        service-version-multiwatch-service.c
 
 service_version_multiwatch_service_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_version_multiwatch_service_LDADD = \
@@ -433,7 +433,7 @@ service_manager_nostart_connect_SOURCES = \
        service-manager-nostart-connect.c
 
 service_manager_nostart_connect_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir)
 
 service_manager_nostart_connect_LDADD = \
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 8df5445..d487c59 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -13,7 +13,7 @@ indicator_loader_SOURCES = \
        indicator-loader.c
 
 indicator_loader_CFLAGS = \
-        -Wall -Werror \
+        -Wall \
        $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) \
        -DBUILD_DIR="\"$(builddir)\""


Quote:

Originally Posted by Poprocks (Post 6040705)
I tried building libido3 on my laptop which is running -current as well. It did produce the same error as you, whereas on my tablet it worked. I have no idea why, as both are running the same versions of gcc and the autotools. I think my tablet is a bit behind on -current though, so maybe some other link in the chain I'm not seeing has been updated since I last updated my tablet which is causing breakage. Anyway, this patch gets it to build for me:

libido3-16.10-drop-werror.patch

thanks to you both!
I pushed these as sed commands ("s|-Wall -Werror|-Wall|").

still waiting for other jobs to finish and will have a look at simple-scan.


All times are GMT -5. The time now is 05:30 AM.