LinuxQuestions.org
Share your knowledge at the LQ Wiki.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 04-08-2020, 08:00 AM   #1
tfonz
LQ Newbie
 
Registered: May 2011
Location: Berlin, Germany
Posts: 12

Rep: Reputation: 15
SBo oath-toolkit on -current needs a patch


On my -current oath-toolkit failed to compile with

Code:
fseeko.c:110:4: error: #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
It compiled fine after applying a patch from Debian that I found at https://bugs.debian.org/cgi-bin/bugr...cgi?bug=915175

The patch is:

Code:
Description: Check _IO_EOF_SEEN instead of _IO_ftrylockfile
 Needed to get fseeko.c to build with glibc 2.28.
 Inspired by https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4af4a4a71827c0bc5e0ec67af23edef4f15cee8e.
Author: Sascha Steinbiss <satta@debian.org>
Last-Update: 2019-02-09
--- a/liboath/gl/fseeko.c
+++ b/liboath/gl/fseeko.c
@@ -47,7 +47,7 @@
 #endif
 
   /* These tests are based on fpurge.c.  */
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
   if (fp->_IO_read_end == fp->_IO_read_ptr
       && fp->_IO_write_ptr == fp->_IO_write_base
       && fp->_IO_save_base == NULL)
@@ -123,7 +123,7 @@
           return -1;
         }
 
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
       fp->_flags &= ~_IO_EOF_SEEN;
       fp->_offset = pos;
 #elif defined __sferror || defined __DragonFly__ || defined __ANDROID__
The change to the SlackBuild is:

Code:
--- oath-toolkit/oath-toolkit.SlackBuild.orig   2020-04-08 14:55:10.575368954 +0200
+++ oath-toolkit/oath-toolkit.SlackBuild        2020-04-08 14:43:32.466195197 +0200
@@ -70,6 +70,7 @@
   -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
 patch -p1 < $CWD/oath-toolkit-gcc.patch
+patch -p1 < $CWD/oath-toolkit-fseek.patch
 
 CFLAGS="$SLKCFLAGS" \
 CXXFLAGS="$SLKCFLAGS" \
 
Old 04-08-2020, 10:25 AM   #2
ponce
LQ Guru
 
Registered: Aug 2004
Location: Pisa, Italy
Distribution: Slackware
Posts: 5,523

Rep: Reputation: Disabled
I just pushed the patch to this repository, thanks for the report!
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
LXer: Facebook re-licenses React.js, a new open source tool from Oath, and more news LXer Syndicated Linux News 0 09-30-2017 03:51 PM
Wonder we could get Mr. Martin to endorse this oath for the freeware movement... rcgy LinuxQuestions.org Member Intro 3 05-31-2015 05:26 AM
I wonder if we could get George R. R. Martin to endorse this oath... rcgy Linux - Newbie 0 05-30-2015 07:45 PM
Nvidia-driver.SlackBuild from SBo (or: I am a bad and sloppy SBo maintainer) kingbeowulf Slackware 8 08-31-2012 02:41 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 08:14 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration