LinuxQuestions.org
Visit Jeremy's Blog.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 04-23-2014, 04:01 AM   #1
ruario
Senior Member
 
Registered: Jan 2011
Location: Oslo, Norway
Distribution: Slackware
Posts: 2,520

Rep: Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664Reputation: 1664
Request: Slackware Info-Zip ZipNote be patched to support writing back comments


ZipNote is a utility provided as part of the Info-ZIP suite of tools. It allows for viewing and editing ZIP file comments and names. ZipNote 3.0 (the latest stable release) has a bug that prevents it from performing its editing functionality.

I reported this bug upstream and received a reply from Steven M. Schweda of the Info-ZIP development team. He confirmed that this was a known issue and was fixed in the Zip 3.1b beta release already. In the mean time he pointed out that zipnote.c needed only a very minor change to make this work.

I would therefore request the following changes be included in slackware-current.

Here is a patch to infozip.SlackBuild:

Code:
--- ./infozip.SlackBuild.orig   2014-04-23 10:31:02.000000000 +0200
+++ ./infozip.SlackBuild        2014-04-23 10:33:14.000000000 +0200
@@ -45,6 +45,7 @@
 rm -rf zip$(echo $ZIP | tr -d .)
 tar xvf $CWD/zip$(echo $ZIP | tr -d .).tar.?z* || exit 1
 cd zip$(echo $ZIP | tr -d .)
+zcat $CWD/zip.zipnote.c.diff.gz | patch -p1 --verbose || exit 1
 chown -R root:root .
 mkdir -p $PKG/usr/doc/zip-$ZIP
 cp -a BUGS CHANGES INSTALL LICENSE README* TODO US* WHATSNEW WHERE \
Here are the uncompressed contents of zip.zipnote.c.diff.gz referenced above:

Code:
--- ./zipnote.c.orig    2014-04-23 10:26:14.000000000 +0200
+++ ./zipnote.c 2014-04-23 10:27:27.000000000 +0200
@@ -661,7 +661,7 @@
     if ((r = zipcopy(z)) != ZE_OK)
       ziperr(r, "was copying an entry");
   }
-  fclose(x);
+  fclose(in_file);
 
   /* Write central directory and end of central directory with new comments */
   if ((c = zftello(y)) == (zoff_t)-1)    /* get start of central */
Thanks in advance for considering this request.

Last edited by ruario; 04-23-2014 at 04:49 AM. Reason: copied too much in the second code example; grammar
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] Problems with zipnote writing to files ruario Linux - Software 2 04-23-2014 04:02 AM
[Request] Info-Zip UID/GID and bzip2 support for -current ruario Slackware 2 09-15-2013 03:41 AM
[SOLVED] [Request] Slackware 14.1 with kernel 3.10 for a better support to AMD GPU sardinha Slackware 5 07-06-2013 09:16 AM
Request: Mozilla Firefox ESR (Extended Support Release) for Slackware kikinovak Slackware 4 07-18-2012 11:24 AM
PHP ZIP MYSQL - open zip without writing it to disk benjalien Programming 2 01-15-2010 05:14 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 07:24 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration