[SOLVED] regression on -current with pulseaudio

nobodino · 05-08-2021, 10:57 AM

pulseaudio doesn't build anymore on Slackware64-current:
-------------------------
[426/565] Compiling C object src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o
FAILED: src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o
ccache cc -Isrc/modules/module-echo-cancel.so.p -I. -I.. -Isrc -I../src -I/usr/include/orc-0.4 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -O3 -O2 -fPIC -fPIC -pthread -DHAVE_CONFIG_H -D_GNU_SOURCE -D__INCLUDED_FROM_PULSE_AUDIO -DPA_MODULE_NAME=module_echo_cancel -DHAVE_ADRIAN_EC=1 -MD -MQ src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o -MF src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o.d -o src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o -c ../src/modules/echo-cancel/adrian-aec.c
../src/modules/echo-cancel/adrian-aec.c:30:10: fatal error: adrian-aec-orc-gen.h: No such file or directory
30 | #include "adrian-aec-orc-gen.h"
| ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[434/565] Compiling C object src/modules/module-echo-cancel.so.p/echo-cancel_module-echo-cancel.c.o
ninja: build stopped: subcommand failed.
-------------------------

lovemeslk · 05-08-2021, 12:21 PM

seems in in pulseaudio -Dorc=enabled is broken. actually reversed some how

According to this.

Code:

   27 #include "adrian-aec.h"
   28 
   29 #ifndef DISABLE_ORC
   30 #include "adrian-aec-orc-gen.h"
   31 #endif

This tells me pthread most likely not finding orc 04.32.
But what blows my mind is if you disable it.
-Dorc=disabled
It builds that makes no sence. nothing has changed on the tarball.
This points to "meson"

Code:

Sun May  2 19:41:57 UTC 2021
d/meson-0.58.0-x86_64-1.txz:  Upgraded.

yes revert to meson 0.57.2 and then it builds.
mark it solved hope Pat reads this.
This makes sence because I have had ton of build issues with meson enable disable and auto lately.

ponce · 05-08-2021, 12:58 PM

I just know meson very little but I suspect this happens because of the following change in version 0.58.0

https://mesonbuild.com/Release-notes...ories-is-false

in fact, if you add this sed before the build routine (in this case I'm not sure if there are any side-effects)

Code:

sed -i 's|implicit_include_directories : false||' src/modules/meson.build

pulseaudio builds fine.

lovemeslk · 05-08-2021, 01:12 PM

That isn't a fix. that is a hack. Looking at the commits on this that Sir will break other builds.
It is up to the devs to use enabled disabled auto. Then you have other ones like atk etc that still use true false .
revert back to 0.57.2 till 058.1 is released ton of issues this is right out broken on python 3.9.
there is hundreds of issues since release. Not for us to write code for meson.
Up to Meson to parse our code correct. As it has done for a long time.

Spent hours days trying to build with 0.58. If Pat uses it on GTK+3 most likley it built but not to his calls.
same for atk Glib-2
It isn't parsing the build.

ponce · 05-08-2021, 01:26 PM

well, I prepared a patch following the hints here

https://github.com/GStreamer/gst-plu...on.build#L1021

Code:

--- pulseaudio-14.2.orig/src/modules/meson.build        2021-01-16 18:26:36.000000000 +0100
+++ pulseaudio-14.2/src/modules/meson.build     2021-05-08 20:23:23.605579000 +0200
@@ -268,6 +268,8 @@
 # FIXME: meson doesn't support multiple RPATH arguments currently
 rpath_dirs = join_paths(privlibdir) + ':' + join_paths(modlibexecdir)
 
+common_args = '-I@0@'.format(meson.current_build_dir())
+
 foreach m : all_modules
   name = m[0]
   sources = m[1]
@@ -280,7 +282,8 @@
     sources,
     headers,
     include_directories : [configinc, topinc],
-    c_args : [pa_c_args, server_c_args, '-DPA_MODULE_NAME=' + name.underscorify()] + extra_flags,
+    cpp_args : common_args,
+    c_args : [common_args, pa_c_args, server_c_args, '-DPA_MODULE_NAME=' + name.underscorify()] + extra_flags,
     install : true,
     install_rpath : rpath_dirs,
     install_dir : modlibexecdir,

lovemeslk · 05-08-2021, 01:34 PM

why patch Pulse audio it is correct everything in the code is setup to Meson 0.58 standards it is broken.
For once pulseaudio is right.
Patching this is only creating confusion till the whole world makes Meson happy.
My point of view. Love your work Ponce. Horse before the cart.

nobodino · 05-12-2021, 06:49 AM

Should be solved by Ponce patch.Still not applied on -current.