[SOLVED] regression on -current with kmymoney

nobodino · 12-12-2021, 08:17 AM

kmymoney doesn't build anymore on -current:
----------------------
Consolidate compiler generated dependencies of target kmm_mymoney
[ 5%] Building CXX object kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/mymoneycontact.cpp.o
/tmp/kde_build/applications-extra/kmymoney-5.1.2/kmymoney/mymoney/mymoneycontact.cpp:13:10: erreur fatale: AkonadiCore/RecursiveItemFetchJob*: Aucun fichier ou dossier de ce type
13 | #include <AkonadiCore/RecursiveItemFetchJob>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminée.
make[2]: *** [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/build.make:524 : kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/mymoneycontact.cpp.o] Erreur 1
make[1]: *** [CMakeFiles/Makefile2:2115 : kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/all] Erreur 2
make: *** [Makefile:146 : all] Erreur 2
applications-extra:kmymoney failed to build.
-----------------------
seems to be related to the new akonadi package.

Daedra · 12-12-2021, 09:25 AM

I just cloned the git repo and was able to compile that. So I guess its just a matter of finding the right commit. If I find it I will report back.

Daedra · 12-12-2021, 09:28 AM

Ok I think I found it. This commit fixes the build on my end. But give it a test on your end.

nobodino · 12-12-2021, 10:35 AM

ok it builds fine with this:
----------------------------

Code:

# patch to build with new akonadi package:
cat $CWD/patch/kmymoney/kmymoney.patch | patch -p1 --verbose || { touch ${SLACK_KDE_BUILD_DIR}/${PKGNAME}.failed ; continue ; }

and this patch:
----------------------------

Code:

diff -aurN kmymoney-5.1.2/kmymoney/mymoney/mymoneycontact.cpp kmymoney-5.1.2-mod/kmymoney/mymoney/mymoneycontact.cpp
--- kmymoney-5.1.2/kmymoney/mymoney/mymoneycontact.cpp	2021-06-23 17:49:12.000000000 +0200
+++ kmymoney-5.1.2-mod/kmymoney/mymoney/mymoneycontact.cpp	2021-12-12 17:03:38.513691645 +0100
@@ -8,11 +8,20 @@
 #include "mymoneycontact.h"
 
 #ifdef ENABLE_ADDRESSBOOK
-#include <KIdentityManagement/IdentityManager>
 #include <KIdentityManagement/Identity>
+#include <KIdentityManagement/IdentityManager>
+#include <akonadi_version.h>
+
+#if AKONADI_VERSION >= QT_VERSION_CHECK(5, 18, 41)
+#include <Akonadi/Collection>
+#include <Akonadi/ItemFetchScope>
+#include <Akonadi/RecursiveItemFetchJob>
+#else
 #include <AkonadiCore/RecursiveItemFetchJob>
 #include <AkonadiCore/ItemFetchScope>
 #include <AkonadiCore/Collection>
+#endif
+
 #include <KContacts/Addressee>
 #include <QRegularExpression>
 #endif
@@ -67,7 +76,7 @@
         job->fetchScope().fetchFullPayload();
         job->fetchScope().setAncestorRetrieval(Akonadi::ItemFetchScope::Parent);
         job->setProperty("MyMoneyContact_email", email);
-        connect(job, SIGNAL(result(KJob*)), this, SLOT(searchContactResult(KJob*)));
+        connect(job, &Akonadi::RecursiveItemFetchJob::result, this, &MyMoneyContact::searchContactResult);
         job->start();
     }
 #else

---------------------------
Thanks twice in 2 days to Daedra

nobodino · 12-12-2021, 02:13 PM

fixed in the kde source tree and FTBFS.log
----------------------------

Code:

Sun Dec 12 19:21:35 UTC 2021
  kmymoney: Fix build with recent akonadi. Thanks to Daedra and nobodino.
+--------------------------+
Sat Dec  5 23:01:14 UTC 2020
  All packages tested and found to compile properly.

Thanks to PV.