LinuxQuestions.org
Share your knowledge at the LQ Wiki.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 05-08-2021, 10:15 AM   #1
nobodino
Member
 
Registered: Jul 2010
Location: in France
Distribution: slackware, slackware from scratch, LFS, slackware [arm], linux Mint,Manjaro...
Posts: 873

Rep: Reputation: 461Reputation: 461Reputation: 461Reputation: 461Reputation: 461
regression on -current with gst-plugins-base


gst-plugins-base doesn't build anymore on Slackware64-current:
-------------------
[218/698] Compiling C object gst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p/egl_gstglcontext_egl.c.o
FAILED: gst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p/egl_gstglcontext_egl.c.o
ccache cc -Igst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p -I. -I.. -Igst-libs -I../gst-libs -Isubprojects/gl-headers/abyss -I../subprojects/gl-headers/abyss -Isubprojects/gl-headers/wglext -I../subprojects/gl-headers/wglext -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gudev-1.0 -I/usr/include/libdrm -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -fvisibility=hidden -fno-strict-aliasing -DG_DISABLE_CAST_CHECKS -Wmissing-declarations -Wredundant-decls -Wundef -Wwrite-strings -Wformat -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -Wmissing-prototypes -Wdeclaration-after-statement -O2 -fPIC -fPIC -pthread -DHAVE_CONFIG_H -DBUILDING_GST_GL -MD -MQ gst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p/egl_gstglcontext_egl.c.o -MF gst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p/egl_gstglcontext_egl.c.o.d -o gst-libs/gst/gl/libgstgl-1.0.so.0.1804.0.p/egl_gstglcontext_egl.c.o -c ../gst-libs/gst/gl/egl/gstglcontext_egl.c
In file included from ../gst-libs/gst/gl/egl/gstglcontext_egl.c:46:
../gst-libs/gst/gl/egl/../wayland/gstglwindow_wayland_egl.h:25:10: fatal error: xdg-shell-client-protocol.h: No such file or directory
25 | #include "xdg-shell-client-protocol.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[225/698] Generating GstAudio-1.0.gir with a custom command
ninja: build stopped: subcommand failed.
------------------
 
Old 05-08-2021, 12:36 PM   #2
ponce
LQ Guru
 
Registered: Aug 2004
Location: Pisa, Italy
Distribution: Slackware
Posts: 6,152

Rep: Reputation: Disabled
I just know meson very little but I suspect this happens because of the following change in version 0.58.0

https://mesonbuild.com/Release-notes...ories-is-false

in fact, if you add this sed before the build routine (should be safe as we surely won't use any case-insensitive filesystem when building the package)

Code:
sed -i 's|implicit_include_directories : false||' gst-libs/gst/gl/meson.build
gst-plugins-base builds fine.

EDIT: I had a look at upstream and they seem to have done it differently

https://github.com/GStreamer/gst-plu...on.build#L1021

EDIT2: I prepared a patch following the upstream changes

Code:
diff -Naur gst-plugins-base-1.18.4.orig/gst-libs/gst/gl/meson.build gst-plugins-base-1.18.4/gst-libs/gst/gl/meson.build
--- gst-plugins-base-1.18.4.orig/gst-libs/gst/gl/meson.build    2021-03-15 18:48:01.251275800 +0100
+++ gst-plugins-base-1.18.4/gst-libs/gst/gl/meson.build 2021-05-08 20:31:27.857579000 +0200
@@ -989,11 +989,20 @@
     command : [mkenums, glib_mkenums, '@OUTPUT@', '@INPUT@'])
   gen_sources = [gl_enumtypes_h]
 
+  common_args = gst_plugins_base_args + gl_cpp_args + ['-DBUILDING_GST_GL']
+
+  # We have custom_target() that generate headers in the current build dir,
+  # but with implicit_include_directories: false, meson >= 0.58.0 won't include
+  # it by default. We cannot use include_directories('.') here because it would
+  # also include current source dir which is what we want to avoid because
+  # case-insensitive FS would include gst-libs/gl/egl/egl.h as EGL/egl.h.
+  common_args += '-I@0@'.format(meson.current_build_dir())
+
   gstgl = library('gstgl-' + api_version,
     gl_sources, gl_egl_sources, gl_x11_sources, gl_wayland_sources, gl_priv_sources, gl_enumtypes_c, gl_enumtypes_h,
-    c_args : gst_plugins_base_args + gl_cpp_args + ['-DBUILDING_GST_GL'],
-    cpp_args : gst_plugins_base_args + gl_cpp_args + ['-DBUILDING_GST_GL'],
-    objc_args : gst_plugins_base_args + gl_cpp_args + gl_objc_args + ['-DBUILDING_GST_GL'],
+    c_args : common_args,
+    cpp_args : common_args,
+    objc_args : common_args + gl_objc_args,
     include_directories : [configinc, libsinc, gl_includes],
     version : libversion,
     soversion : soversion,
Attached Files
File Type: txt meson-0.58.0.patch.txt (1.5 KB, 10 views)

Last edited by ponce; 05-08-2021 at 01:35 PM.
 
1 members found this post helpful.
Old 05-12-2021, 06:50 AM   #3
nobodino
Member
 
Registered: Jul 2010
Location: in France
Distribution: slackware, slackware from scratch, LFS, slackware [arm], linux Mint,Manjaro...
Posts: 873

Original Poster
Rep: Reputation: 461Reputation: 461Reputation: 461Reputation: 461Reputation: 461
should be solved by Ponce patch. Still not applied on -current.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] Issue with compilation of gst-plugins-base Didier Spaier Slackware 10 11-03-2019 05:36 PM
[SOLVED] gstreamer-plugins-base conflicts with gstreamer-plugins-good Raveolution Linux - Software 14 11-17-2009 12:24 PM
The error of compile gst-plugin-base-0.10.22 jeazh Linux - Newbie 3 05-13-2009 01:11 PM
error in gst-plugins-base-0.10.22 for GNOME sumeet inani Linux - Newbie 0 03-16-2009 11:27 PM
installing gst-base-plugins ankscorek Linux - Software 1 01-18-2007 03:28 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 09:18 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration