LinuxQuestions.org

LinuxQuestions.org (/questions/)
-   Slackware (https://www.linuxquestions.org/questions/slackware-14/)
-   -   Questions for Robby, ponce, or anyone from SBo about SBo submission requirements. (https://www.linuxquestions.org/questions/slackware-14/questions-for-robby-ponce-or-anyone-from-sbo-about-sbo-submission-requirements-4175544696/)

ReaperX7 06-06-2015 10:20 PM

Questions for Robby, ponce, or anyone from SBo about SBo submission requirements.
 
If I submit a SlackBuild package that has a source available only from a git clone that is repackaged as-is in a public/private repository (such as my libclc git cloned package), is this acceptable under the terms and conditions of SBo as long as I can provide the tarball download from my git repository?

Also, if I have a package that has semi-custom patches that are required for compiling the package, but aren't in the most professional labeling (such as is with my libomxil-bellagio package on Slackworks), does SBo still accept these or do they need to be reworked?

dugan 06-07-2015 02:06 AM

I'm not an SBo admin, but I think I can answer these.

Quote:

Originally Posted by ReaperX7 (Post 5373344)
If I submit a SlackBuild package that has a source available only from a git clone that is repackaged as-is in a public/private repository (such as my libclc git cloned package), is this acceptable under the terms and conditions of SBo as long as I can provide the tarball download from my git repository?

Absolutely. See the GZDoom SlackBuild, for example.

Quote:

Also, if I have a package that has semi-custom patches that are required for compiling the package, but aren't in the most professional labeling (such as is with my libomxil-bellagio package on Slackworks), does SBo still accept these or do they need to be reworked?
If the patches are required to get the package to build, then they're required to get the package to build. I haven't looked at either your libomxil-ballagio package or at Slackworks, but if you follow the templates then it should be fine.

ReaperX7 06-07-2015 02:48 AM

Thanks Dugan. I might submit more of my work then.

kikinovak 06-07-2015 02:50 AM

Quote:

Originally Posted by ReaperX7 (Post 5373344)
If I submit a SlackBuild package that has a source available only from a git clone that is repackaged as-is in a public/private repository (such as my libclc git cloned package), is this acceptable under the terms and conditions of SBo as long as I can provide the tarball download from my git repository?

Also, if I have a package that has semi-custom patches that are required for compiling the package, but aren't in the most professional labeling (such as is with my libomxil-bellagio package on Slackworks), does SBo still accept these or do they need to be reworked?

I think the SBo mailing list will be the best place to ask this sort of question.

ponce 06-07-2015 11:30 AM

Quote:

Originally Posted by kikinovak (Post 5373384)
I think the SBo mailing list will be the best place to ask this sort of question.

what niki said: please, try to use the official channels.
we should avoid transforming LQ in the SBo support forum.

btw, I had a look at your repository and seems to me stuff that, IMHO, shouldn't be on SBo: those are dependencies of mesa, and mesa is in Slackware.
We shouldn't have on SBo a package that requires a rebuild of libdrm/mesa.
plus, those are not even applicable with the software versions that we have on stable and SBo targets that version only.

besides that, let me tell you a pair of things that I would fix in the scripts:

- you used VERSION=${VERSION:-20150524-svn} but that's a no-no, because a VERSION variable with a dash confuses pkgtools;
you should use something like 20150524_svn, shouldn't be a problem as you create and self-host the tarball (btw, I tried to download and I got a 404 error); remember to use a wget-friendly place where to host the tarballs.
as a personal consideration I also think that a revision number (like r3245) get from subversion is more appropriate than a date (that's ambiguos as there could be multiple revisions for that date) for version-naming a tarball; for git I usually version the tarballs with ${date}_${first_7_letters_of_commit} (like 20120211_234796c, you can find the related data with "git log") as date alone is ambiguos and commit alone is unintelligible.

- you shouldn't hardcode the jobs number in the script: do it only if it breaks with multiple jobs (setting it to -j1);

- don't use something like
Code:

[ -f $CWD/doinst.sh ] && cat $CWD/doinst.sh > $PKG/install/doinst.sh
but try to stick to the templates: if there's a doinst.sh to put in the $PKG/install directory add a line
Code:

cat $CWD/doinst.sh > $PKG/install/doinst.sh
if there isn't don't add any line.


All times are GMT -5. The time now is 09:21 AM.