Problem with latest -current patch

niels.horn · 04-16-2009, 07:10 AM

Hi,

Today I tried to install the latest update in -current (pkgtools-12.34567890-noarch-2.tgz) with slackpkg, but it returned with an error that the md5sum was not matching.

After some research, I found out that in the 'checkpkg' function in /usr/libexec/slackpkg/core-functions.sh the 'MD5ORIGINAL' variable receives the md5sum of both the package to be installed and the source package (source/a/pkgtools/pkgtools-12.34567890-noarch-2.tgz).

A temporary solution is to turn of md5sum checking in Slackpkg in /etc/slackpkg/slackpkg.conf: change CHECKPKG=on to CHECKPKG=off

+Alan Hicks+ · 04-16-2009, 04:55 PM

Thanks for the bug report. It's been mentioned to PiterPUNK already. After looking into this, I noticed that this only ever happens when the Slackware package and the source archive both have the same name. Thus, pkgtools encounters this bug but the majority of packages don't. The following diff should fix the problem.

http://www.slackware.com/~alan/core-...ns.sh.diff.txt

I've already sent it to PiterPUNK and expect to hear something back from him soon.

niels.horn · 04-16-2009, 06:18 PM

Alan,

ok, looking at the diff it should fix the problem.
I'm still at work (no machine running -current here) but will try it as soon as I get home.

Thanks for the quick reply!

niels.horn · 04-16-2009, 07:41 PM

And, as expected, the patch works fine!

Just upgraded my -current machine at home with the latest package

<edit>
Eh, well, almost fixed

It updates the package, but tries to update it twice. Probably there is some other point in Slackpkg where it gets confused by the duplicated name.
</edit>

In an attempt to give some additional info, the output after "slackpkg upgrade-all" is like this:

Code:

Package: pkgtools-12.34567890-noarch-2.tgz
	Downloading pkgtools-12.34567890-noarch-2.tgz...
...
...
2009-04-16 21:41:18 (16.0 MB/s) - `/var/cache/packages/pkgtools-12.34567890-noarch-2.tgz.asc' saved [197]

	Upgrading pkgtools-12.34567890-noarch-2...
basename: extra operand `.tbz'
Try `basename --help' for more information.

+==============================================================================
| Upgrading pkgtools-12.34567890-noarch-1 package using ./pkgtools-12.34567890-noarch-2.tgz
+==============================================================================

Pre-installing package pkgtools-12.34567890-noarch-2...

Removing package /var/log/packages/pkgtools-12.34567890-noarch-1-upgraded-2009-04-16,21:41:18...

Verifying package pkgtools-12.34567890-noarch-2.tgz.
Installing package pkgtools-12.34567890-noarch-2.tgz:
...
...
Package pkgtools-12.34567890-noarch-2.tgz installed.

Package pkgtools-12.34567890-noarch-1 upgraded with new package ./pkgtools-12.34567890-noarch-2.tgz.

Package: pkgtools-12.34567890-noarch-2.tgz
	Downloading pkgtools-12.34567890-noarch-2.tgz...
...
...
	Upgrading pkgtools-12.34567890-noarch-2...

+==============================================================================
| Skipping package pkgtools-12.34567890-noarch-2 (already installed)
+==============================================================================

The lines in red probably have nothing to do with this problem, but might be interesting as well.

arny · 04-17-2009, 05:34 AM

Quote:

Originally Posted by niels.horn

The lines in red probably have nothing to do with this problem, but might be interesting as well.

The pkgtools-12.34567890-noarch-2 package should fix this problem.