LinuxQuestions.org
Share your knowledge at the LQ Wiki.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 03-26-2016, 06:13 AM   #1
Linux.tar.gz
Senior Member
 
Registered: Dec 2003
Location: Paris
Distribution: Slackware forever.
Posts: 2,420

Rep: Reputation: 95
Minor typo in Slackware -current /etc/rc.d/rc.6


Hi !

It's been there for some time :
Code:
$grep systohc /etc/rc.d/rc.6
# Save the system time to the hardware clock using hwclock --systohc.
    /sbin/hwclock $CLOCK_OPT --systohc
    /sbin/hwclock $CLOCK_OPT --utc --systohc
    /sbin/hwclock  $CLOCK_OPT --localtime --systohc
A space needs to be removed in the last line between hwclock and $CLOCK_OPT.
--Edit : not visible on LQ without editing the post, check live.
--Edit2 : added code tags.

Last edited by Linux.tar.gz; 03-26-2016 at 09:32 AM.
 
Old 03-26-2016, 06:44 AM   #2
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 7,617

Rep: Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046Reputation: 6046
Ever heard of quote tags? They are quite useful here on LQ.
 
Old 03-26-2016, 07:47 AM   #3
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-14.2.1.2 on Lenovo Thinkpad W520
Posts: 8,925

Rep: Reputation: Disabled
It's not a bug as in this context you can write more than one space without changing the interpretation of the command by the shell, in other words the results of parsing it. If you have a reason to think otherwise, please provide a pointer to a relevant specification to sustain your claim.

But if that really hurts your eyes, feel free to remove the additional space in your system.

Last edited by Didier Spaier; 03-26-2016 at 07:49 AM.
 
1 members found this post helpful.
Old 03-26-2016, 07:49 AM   #4
GazL
LQ Guru
 
Registered: May 2008
Posts: 5,125
Blog Entries: 17

Rep: Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808
The shell doesn't care how much white-space is between a command and/or command arguments. 'needs to be removed' is probably over stating it a little.

edit: beaten to it.
 
Old 03-26-2016, 08:38 AM   #5
FTIO
Member
 
Registered: Mar 2015
Location: Las Vegas, NV
Distribution: Slackware 14.1_32
Posts: 260

Rep: Reputation: 129Reputation: 129
Geez...a guy tries to help clean things up a bit, is told his help is irrelevant (and not even close to anything he commented about! It is about a *typo*, not what it could or couldn't do to a running system!) and does anyone expect him to come back if he does find something that could be damaging to a Slackware installed system? If I were a newbie Slackware user, or someone interested in possibly trying it out and had questions and saw how someone is treated by the elitists in here, hell...I'd probably go to another distro faster than a synapse could happen and would even consider an systemd abortion using distro over this one.
 
5 members found this post helpful.
Old 03-26-2016, 09:03 AM   #6
GazL
LQ Guru
 
Registered: May 2008
Posts: 5,125
Blog Entries: 17

Rep: Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808Reputation: 2808
All I did was point out that it's a cosmetic issue only and has no impact. There was no nastiness in what I posted, nor do I accept that I was in any way elitist.
 
Old 03-26-2016, 09:17 AM   #7
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-14.2.1.2 on Lenovo Thinkpad W520
Posts: 8,925

Rep: Reputation: Disabled
I just hope that someone who has posted 2273 times in more that twelve years is no more a newbie.

Yes he should have known the purpose of code tags and used them.

And people have tried to help that person a lot.

Quote:
I'd probably go to another distro faster than a synapse could happen.
Don't bet.

Last edited by Didier Spaier; 03-26-2016 at 11:49 AM. Reason: s/that has posted/who has posted/
 
Old 03-26-2016, 09:28 AM   #8
allend
LQ 5k Club
 
Registered: Oct 2003
Location: Melbourne
Distribution: Slackware-current
Posts: 5,239

Rep: Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898Reputation: 1898
At last! The change to save that vital byte on the install size.
Quote:
.I'd probably go to another distro faster than a synapse could happen ...
It takes two neurons to create a synapse.
 
Old 03-26-2016, 09:37 AM   #9
Linux.tar.gz
Senior Member
 
Registered: Dec 2003
Location: Paris
Distribution: Slackware forever.
Posts: 2,420

Original Poster
Rep: Reputation: 95
I never talked about a bug, please read carefully the first post.

I noticed it because I patch a system that must not write to hwclock.
So when I used sed on /etc/rc.d/rc.6 I noticed the typo.

Anyway I think this extra space should be removed on a Slackware.
 
1 members found this post helpful.
Old 03-26-2016, 09:43 AM   #10
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-14.2.1.2 on Lenovo Thinkpad W520
Posts: 8,925

Rep: Reputation: Disabled
Quote:
Originally Posted by Linux.tar.gz View Post
Anyway I think this extra space should be removed on a Slackware.
Why?
 
Old 03-26-2016, 10:32 AM   #11
ReaperX7
LQ Guru
 
Registered: Jul 2011
Location: California
Distribution: Slackware64-Current
Posts: 6,449
Blog Entries: 15

Rep: Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020Reputation: 2020
Mostly it's a cosmetic fix only. The whitespace argument is fickle over a single blank space in a text file. While it is nice to try and reduce whitespace to save as many bits of freespace and reduce data footprint as much as possible, by today's standards, you can actually get away with some wasted whitespace in documents when making tables for documentation and simply making a command structure look nice and evened out.

That being said, guys, please keep the comments humane and helpful. No need to act like snobby elitists. This isn't Debian...
 
2 members found this post helpful.
Old 03-26-2016, 10:38 AM   #12
Philip Lacroix
Member
 
Registered: Jun 2012
Distribution: Slackware, BSD
Posts: 422

Rep: Reputation: 539Reputation: 539Reputation: 539Reputation: 539Reputation: 539Reputation: 539
IMHO a typo is always worth fixing.

@Linux.tar.gz - You might want to send a simple patch to PV, then he would decide.

Code:
diff -r a/etc/rc.d/rc.6 b/etc/rc.d/rc.6
66c66
<     /sbin/hwclock  $CLOCK_OPT --localtime --systohc
---
>     /sbin/hwclock $CLOCK_OPT --localtime --systohc
 
1 members found this post helpful.
Old 03-26-2016, 10:46 AM   #13
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-14.2.1.2 on Lenovo Thinkpad W520
Posts: 8,925

Rep: Reputation: Disabled
I fail to see how requesting the rationale for a change of which implementation would waste need attention and time from the Slackware team better spent on something more useful is acting like a snobby elitist.

PS And if someone cares about typos, there are many more than just that one. So it would be more efficient and helpful to chase them systematically in all Slackware scripts and provide a single unified diff for all of them, or better one per source package.

PPS I have been and still am occasionally in contact with Debian contributors and didn't observe anything in their behavior that I would qualify as snobby elitism either. Maybe I am lucky?

Last edited by Didier Spaier; 03-26-2016 at 12:05 PM. Reason: PPS added.
 
Old 03-26-2016, 11:38 AM   #14
DarkVision
Member
 
Registered: Jul 2007
Posts: 189

Rep: Reputation: Disabled
Quote:
Originally Posted by Didier Spaier View Post
PS And if someone cares about typos, there are many more than just that one.
I agree, there are typos, unneeded commands (see xscreensaver.SlackBuild which creates $PKG/etc and $PKG/usr/share/pixmaps while these directories are already created by the sources) and duplicate files (like man6/maze which is included in xgames and xscreensaver). I don't care about those small issues, i prefer a stable distribution with less "important" bugs
 
Old 03-26-2016, 05:02 PM   #15
bassplayer69
Member
 
Registered: Jul 2007
Location: In a van down by the river...
Distribution: Linux Mint 19.1 & Slackware64-Current
Posts: 222

Rep: Reputation: 50
What I find funny is that it takes less time to remove that extra space out of that file than it is to read through this whole thread.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] XFCE Desktop - Slackware 14 - Typo lkraemer Slackware 3 11-10-2012 11:02 AM
SSL version number typo in slackware.com repository clifford227 Slackware 3 04-01-2010 04:33 PM
fluxbox.SlackBuild in -current typo? wadsworth Slackware 9 11-13-2008 01:59 PM
Typo in slackware-current/source/a/lilo/liloconfig drumz Slackware 7 02-22-2008 12:53 PM
dhcpcd in current..minor concerns gravityworks Slackware 3 06-21-2006 06:22 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 04:08 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration