LinuxQuestions.org

LinuxQuestions.org (/questions/)
-   Slackware (https://www.linuxquestions.org/questions/slackware-14/)
-   -   Minor typo in Slackware -current /etc/rc.d/rc.6 (https://www.linuxquestions.org/questions/slackware-14/minor-typo-in-slackware-current-etc-rc-d-rc-6-a-4175575889/)

Linux.tar.gz 03-26-2016 06:13 AM

Minor typo in Slackware -current /etc/rc.d/rc.6
 
Hi !

It's been there for some time :
Code:

$grep systohc /etc/rc.d/rc.6
# Save the system time to the hardware clock using hwclock --systohc.
    /sbin/hwclock $CLOCK_OPT --systohc
    /sbin/hwclock $CLOCK_OPT --utc --systohc
    /sbin/hwclock  $CLOCK_OPT --localtime --systohc

A space needs to be removed in the last line between hwclock and $CLOCK_OPT.
--Edit : not visible on LQ without editing the post, check live.
--Edit2 : added code tags.

Alien Bob 03-26-2016 06:44 AM

Ever heard of quote tags? They are quite useful here on LQ.

Didier Spaier 03-26-2016 07:47 AM

It's not a bug as in this context you can write more than one space without changing the interpretation of the command by the shell, in other words the results of parsing it. If you have a reason to think otherwise, please provide a pointer to a relevant specification to sustain your claim.

But if that really hurts your eyes, feel free to remove the additional space in your system.

GazL 03-26-2016 07:49 AM

The shell doesn't care how much white-space is between a command and/or command arguments. 'needs to be removed' is probably over stating it a little. :)

edit: beaten to it. :)

FTIO 03-26-2016 08:38 AM

Geez...a guy tries to help clean things up a bit, is told his help is irrelevant (and not even close to anything he commented about! It is about a *typo*, not what it could or couldn't do to a running system!) and does anyone expect him to come back if he does find something that could be damaging to a Slackware installed system? If I were a newbie Slackware user, or someone interested in possibly trying it out and had questions and saw how someone is treated by the elitists in here, hell...I'd probably go to another distro faster than a synapse could happen and would even consider an systemd abortion using distro over this one.

GazL 03-26-2016 09:03 AM

All I did was point out that it's a cosmetic issue only and has no impact. There was no nastiness in what I posted, nor do I accept that I was in any way elitist.

Didier Spaier 03-26-2016 09:17 AM

I just hope that someone who has posted 2273 times in more that twelve years is no more a newbie.

Yes he should have known the purpose of code tags and used them.

And people have tried to help that person a lot.

Quote:

I'd probably go to another distro faster than a synapse could happen.
Don't bet.

allend 03-26-2016 09:28 AM

At last! The change to save that vital byte on the install size.
Quote:

.I'd probably go to another distro faster than a synapse could happen ...
It takes two neurons to create a synapse.

Linux.tar.gz 03-26-2016 09:37 AM

I never talked about a bug, please read carefully the first post.

I noticed it because I patch a system that must not write to hwclock.
So when I used sed on /etc/rc.d/rc.6 I noticed the typo.

Anyway I think this extra space should be removed on a Slackware.

Didier Spaier 03-26-2016 09:43 AM

Quote:

Originally Posted by Linux.tar.gz (Post 5521542)
Anyway I think this extra space should be removed on a Slackware.

Why?

ReaperX7 03-26-2016 10:32 AM

Mostly it's a cosmetic fix only. The whitespace argument is fickle over a single blank space in a text file. While it is nice to try and reduce whitespace to save as many bits of freespace and reduce data footprint as much as possible, by today's standards, you can actually get away with some wasted whitespace in documents when making tables for documentation and simply making a command structure look nice and evened out.

That being said, guys, please keep the comments humane and helpful. No need to act like snobby elitists. This isn't Debian...

Philip Lacroix 03-26-2016 10:38 AM

IMHO a typo is always worth fixing.

@Linux.tar.gz - You might want to send a simple patch to PV, then he would decide.

Code:

diff -r a/etc/rc.d/rc.6 b/etc/rc.d/rc.6
66c66
<    /sbin/hwclock  $CLOCK_OPT --localtime --systohc
---
>    /sbin/hwclock $CLOCK_OPT --localtime --systohc


Didier Spaier 03-26-2016 10:46 AM

I fail to see how requesting the rationale for a change of which implementation would waste need attention and time from the Slackware team better spent on something more useful is acting like a snobby elitist.

PS And if someone cares about typos, there are many more than just that one. So it would be more efficient and helpful to chase them systematically in all Slackware scripts and provide a single unified diff for all of them, or better one per source package.

PPS I have been and still am occasionally in contact with Debian contributors and didn't observe anything in their behavior that I would qualify as snobby elitism either. Maybe I am lucky?

DarkVision 03-26-2016 11:38 AM

Quote:

Originally Posted by Didier Spaier (Post 5521558)
PS And if someone cares about typos, there are many more than just that one.

I agree, there are typos, unneeded commands (see xscreensaver.SlackBuild which creates $PKG/etc and $PKG/usr/share/pixmaps while these directories are already created by the sources) and duplicate files (like man6/maze which is included in xgames and xscreensaver). I don't care about those small issues, i prefer a stable distribution with less "important" bugs :)

bassplayer69 03-26-2016 05:02 PM

What I find funny is that it takes less time to remove that extra space out of that file than it is to read through this whole thread. :)


All times are GMT -5. The time now is 09:20 PM.