lilo.SlackBuild vs Makefile

hpfeil · 12-13-2013, 09:49 AM

Going back as far as v13.0, the SlackBuilds are pretty-much the same.
A problem presents itself just after extracting the lilo source in /tmp, chown root etc., then
`make || exit 1`

The lilo src Makefile has no default. You need to supply an argument like,
`make all || exit 1`
From a bash prompt, `make' with no arguments generates the help message.
I don't remember why I stumbled upon this, the pre-built versions for x86_64 all work fine.

wildwizard · 12-14-2013, 02:54 AM

I can see why Pat has missed this for so long, the first call to make shows the help and then exits without error.
The second call to make with install as the target results in the actual build as all the prerequisites are called in and since the code is pretty clean it probably hasn't had an error in all that time.

hpfeil · 12-14-2013, 03:13 PM

It's that pesky `|| exit 1` that needs attention. I'm certain that this used to work before the new guy started fiddling about with the makefile. Without a default target, nothing below the first call to `make` gets executed. In a previous version, there was an include file with lots of variable definitions. Maybe that set up a default target?

I keep getting mixed up: in Bash, (0 == true); in C and Perl, (0 == false). Good thing I'll never see that on an exam. ;-)

Emsi · 12-19-2013, 04:19 AM

This is exit status: 0 represents success, 1 and higher mean some sort of error. It's not just true or false.