LinuxQuestions.org
Welcome to the most active Linux Forum on the web.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 10-18-2007, 03:47 PM   #1
arubin
Senior Member
 
Registered: Mar 2004
Location: Middx UK
Distribution: Slackware64 14.2 (multilib)
Posts: 1,268

Rep: Reputation: 61
freetype.slackbuild This breaks too many things


freetype.slackbuild has the following

# This breaks far too many things. Freetype2 developers will have to get their
# punishment on someone else's distribution.
zcat $CWD/freetype.illadvisederror.diff.gz | patch -p1 --verbose || exit 1

Should this line be commented out or not?

Thanks
 
Old 10-18-2007, 03:50 PM   #2
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 8,559

Rep: Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061
Why do you think Pat leaves it in you think? Did you look at the content of the patch?

Eric
 
Old 10-18-2007, 03:55 PM   #3
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 2,558

Rep: Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312
Did you actually read the patch?
Code:
diff -u -r freetype-2.1.7.orig/include/freetype/freetype.h freetype-2.1.7/include/freetype/freetype.h
--- freetype-2.1.7.orig/include/freetype/freetype.h     2003-11-09 00:38:13.000000000 -0800
+++ freetype-2.1.7/include/freetype/freetype.h  2004-06-05 13:43:55.000000000 -0700
@@ -16,13 +16,20 @@
 /***************************************************************************/
 
 
-#ifndef FT_FREETYPE_H
-#error "`ft2build.h' hasn't been included yet!"
-#error "Please always use macros to include FreeType header files."
-#error "Example:"
-#error "  #include <ft2build.h>"
-#error "  #include FT_FREETYPE_H"
-#endif
+/***************************************************************************/
+/*                                                                         */
+/* If you think breaking almost 100% of all source that links with         */
+/* freetype (anything using a configure file for sure) is a good idea,     */
+/* then feel free to uncomment this block.                                 */
+/*                                                                         */
+/* #ifndef FT_FREETYPE_H                                                   */
+/* #error "`ft2build.h' hasn't been included yet!"                         */
+/* #error "Please always use macros to include FreeType header files."     */
+/* #error "Example:"                                                       */
+/* #error "  #include <ft2build.h>"                                        */
+/* #error "  #include FT_FREETYPE_H"                                       */
+/* #endif                                                                  */
+/***************************************************************************/
 
 
 #ifndef __FREETYPE_H__
 
Old 10-18-2007, 03:56 PM   #4
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 2,558

Rep: Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312Reputation: 1312
Heh. Well, perhaps I should have refreshed the page before clicking "submit" ;-)
 
Old 10-18-2007, 03:58 PM   #5
arubin
Senior Member
 
Registered: Mar 2004
Location: Middx UK
Distribution: Slackware64 14.2 (multilib)
Posts: 1,268

Original Poster
Rep: Reputation: 61
I think it would be nice to be able to manage slackware without being a C programmer.

Ok. I have read it. I am really not stupid. I still do not know the answer to the question.
 
Old 10-18-2007, 04:01 PM   #6
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 8,559

Rep: Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061
You want to know if that patch should be left out, yet you don't want to look into the why?
In that case why don't you just trust the judgement of Patrick Volkerding? Leave that package alone.

Eric

Edit: or better - kill the patch, rebuild the package, and then rebuild one or more of the packages that link against freetype2 (there are many in Slackware, and more at http://SlackBuilds.org). This would be more instructive than my (somewhat) harsh original comment...

Last edited by Alien Bob; 10-18-2007 at 04:03 PM.
 
Old 10-18-2007, 04:07 PM   #7
arubin
Senior Member
 
Registered: Mar 2004
Location: Middx UK
Distribution: Slackware64 14.2 (multilib)
Posts: 1,268

Original Poster
Rep: Reputation: 61
What I am trying to find out is what Pat's judgment is on this. As you know there are a couple of other lines in the slackbuild that can be commented out.

I just found lines
# This breaks far too many things. Freetype2 developers will have to get their
# punishment on someone else's distribution.

ambiguous

What is it with you guys? You are usually so helpful.
 
Old 10-18-2007, 04:13 PM   #8
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 8,559

Rep: Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061
I don't like to point out the obvious nor to spend time on something useless.

It means what it says: the default freetype build will break many other pieces of software that link against freetype.. i.e. they will fail at the configure step.

Pat includes this literal text which I can not improve on:

Quote:
If you think breaking almost 100% of all source that links with freetype (anything using a configure file for sure) is a good idea, then feel free to uncomment this block.
Eric
 
Old 10-18-2007, 04:17 PM   #9
arubin
Senior Member
 
Registered: Mar 2004
Location: Middx UK
Distribution: Slackware64 14.2 (multilib)
Posts: 1,268

Original Poster
Rep: Reputation: 61
You have to know that the line in the slack.build refers to the patch to get that far which I did not.
 
Old 10-18-2007, 04:25 PM   #10
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 8,559

Rep: Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061Reputation: 8061
It just dawned on me what your problem may be with that comment in the SlackBuild... you thought that leaving the line in would break things?
In that case, we had a dysfunctional conversation here... the patch fixes the breakage.

Eric
 
Old 10-18-2007, 04:33 PM   #11
arubin
Senior Member
 
Registered: Mar 2004
Location: Middx UK
Distribution: Slackware64 14.2 (multilib)
Posts: 1,268

Original Poster
Rep: Reputation: 61
Exactly. :-)
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
nfs mount breaks things ciscohead Linux - Newbie 0 05-10-2006 09:53 AM
new sata drive breaks things futz Linux - Hardware 3 11-26-2005 03:04 AM
Common Things Kernel Compiling "Breaks" Skazi Linux - General 2 08-29-2004 09:09 AM
Freetype-devel for freetype-2.1.4-1 (redhat 9) Goog Linux - Distributions 0 05-05-2003 06:55 PM
RH v9.0 breaks a few things... but its still pretty cool KevinJ Linux - Software 11 04-01-2003 12:08 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 10:00 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration