LinuxQuestions.org
Share your knowledge at the LQ Wiki.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 02-05-2019, 10:01 AM   #16
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35

The 4.19 patch above does not remove the comment above the if clause.
Use the 5.0-rc5 patch (identical) or the one attached here (or just edit). or just don't bother, it won't make any difference.
Attached Files
File Type: txt rev-4.19-fs_inode.c.patch.txt (291 Bytes, 6 views)

Last edited by rogan; 02-05-2019 at 10:03 AM.
 
Old 02-06-2019, 08:19 PM   #17
GazL
Senior Member
 
Registered: May 2008
Posts: 4,881
Blog Entries: 14

Rep: Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438
Thanks for all your hard work on this rogan. Reading the threads on LKML, DC seems like a very clued up guy. I hope he gets his way with this, especially as I don't use control groups so I don't really care about the horse poo.

Rather than reworking the patches it might be better just to reverse patch from the original commits (which I've extracted from git and attached).

Code:
cd /usr/src/linux
patch -R -p1 < a76cf1a474d7.patch.txt
patch -R -p1 -F3 < 172b06c32b94.patch.txt
The '-F3' fuzz is required because vmscan.c has changed again since the original commit, but the change is distinctive enough not to need the context, so it'll still revert ok. I can't remember the exact offset it reported, but it was somewhere around +10 to +12.

I've just done this on my 4.20.7. All I can report at present is that it booted ok.


update: These have been reverted upstream as of today's stable kernel updates so I'll remove the patchfiles to save any confusion.

Last edited by GazL; Today at 08:45 AM.
 
2 members found this post helpful.
Old 02-07-2019, 02:52 AM   #18
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35
Thank's Gazl
I think cgroups is a cool feature but like you I don't acually "use" it.
 
Old 02-07-2019, 03:00 AM   #19
syg00
LQ Veteran
 
Registered: Aug 2003
Location: Australia
Distribution: Lots ...
Posts: 17,509

Rep: Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744
cgroups are (now) getting to be really useful. At first (when they were called control groups) they were pretty limited, and the controllers didn't really exist as such.
I have been using them for years simply to isolate CPUs when I am doing benchmarks - my monitoring tools (and my shell session) reside in a cgroup that has dedicated CPU(s) so I can track real-time numbers without interference.
 
1 members found this post helpful.
Old 02-11-2019, 06:52 AM   #20
dederon
Member
 
Registered: Oct 2013
Posts: 94

Rep: Reputation: 46
as i don't want to compile a kernel i want to ask if and when this revert will be applied to the kernel source. will there be a back port to 4.19.x? i am using ext3 and write cache flushing is terrible slow.
 
Old 02-11-2019, 08:46 AM   #21
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35
Last I watched lkml, Andrew Morton said he'd "queued the reverts". I suppose that means they're going to be applied next release (4.19.21).
 
Old 02-11-2019, 09:43 AM   #22
Petri Kaukasoina
Member
 
Registered: Mar 2007
Posts: 389

Rep: Reputation: 246Reputation: 246Reputation: 246
It should first be in Linus's tree before it can be put to stable kernels. It's not.
 
1 members found this post helpful.
Old 02-14-2019, 05:29 AM   #23
Petri Kaukasoina
Member
 
Registered: Mar 2007
Posts: 389

Rep: Reputation: 246Reputation: 246Reputation: 246
The fix is now in Linus's git tree. Next it can be added to the stable trees.
 
3 members found this post helpful.
Old 02-14-2019, 09:48 AM   #24
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35
Great news, Thanks Petri !
 
Old 02-18-2019, 07:12 AM   #25
Petri Kaukasoina
Member
 
Registered: Mar 2007
Posts: 389

Rep: Reputation: 246Reputation: 246Reputation: 246
The fix is now in the stable queue (for 4.19.24 and 4.20.11).
 
3 members found this post helpful.
Old 02-18-2019, 02:07 PM   #26
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35
The reverts are already applied to 5.0-rc7 (I'm running it now).
 
Old Today, 08:47 AM   #27
GazL
Senior Member
 
Registered: May 2008
Posts: 4,881
Blog Entries: 14

Rep: Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438Reputation: 2438
Stable updates containing these are now out.
 
Old Today, 11:09 AM   #28
rogan
Member
 
Registered: Aug 2004
Distribution: Slackware
Posts: 121

Original Poster
Rep: Reputation: 35
This one is solved
 
1 members found this post helpful.
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
Getting Artifacts and occasional "signal not supported" messages - External Monitor from fc25 onwards 6th_sense Linux - Laptop and Netbook 3 02-08-2019 08:43 PM
LXer: Onwards to Valhalla: Java ain't dead yet and it's only getting bigger LXer Syndicated Linux News 0 10-06-2017 02:42 AM
awk - print field 2 from line 8 and onwards dazdaz Programming 2 03-27-2013 04:55 AM
LXer: Onwards to Four LXer Syndicated Linux News 0 10-28-2012 02:40 PM
Onwards to kde4.2 jdkaye Debian 11 08-01-2009 12:21 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 03:38 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration