fbreader.SlackBuild uses /usr/lib in x86_64

gapan · 01-13-2010, 03:21 PM

I used the fbreader.SlackBuild in a 64bit system to create a package and I got some libraries installed under /usr/lib instead of /usr/lib64. FBReader seems to work fine though, so I'm not sure this is a problem. I guess it could be if some other app looks for those libraries. Just thought I should report it anyway.

I used UI=gtk if it matters.

piratesmack · 01-13-2010, 04:15 PM

Here's a patch, but I haven't tested it yet.
If it works, I'll send it to the maintainer of that SlackBuild.

Code:

--- fbreader.SlackBuild	2009-08-27 16:07:53.000000000 -0600
+++ fbreader.SlackBuild.new	2010-01-13 14:31:53.838728997 -0700
@@ -2,6 +2,7 @@
 
 # Slackware build script for fbreader
 # Written by Audrius Kažukauskas <audrius@neutrino.lt>
+# Modified by Steven Pledger <piratesmack@ymail.com>
 
 PRGNAM=fbreader
 VERSION=0.10.7
@@ -51,6 +52,8 @@
 
 # Add SLKCFLAGS
 sed -i "s|CFLAGS =|CFLAGS = $SLKCFLAGS|" makefiles/arch/desktop.mk
+# Fix lib directory on Slackware64 (hopefully)
+sed -i "s|LDFLAGS =|LDFLAGS = /usr/lib${LIBDIRSUFFIX}|" makefiles/arch/desktop.mk
 
 # Fix all Qt3 related flags (just in case)
 sed -i 's|moc-qt3|moc|' makefiles/arch/desktop.mk

Save it as patch.diff and apply it with:

Code:

patch -p0 < patch.diff

gapan · 01-13-2010, 04:33 PM

Nope. Doesn't work.

gapan · 01-13-2010, 04:56 PM

Got it. A

Code:

sed -i "s|LIBDIR ?= \$(INSTALLDIR)/lib|LIBDIR ?= \$(INSTALLDIR)/lib${LIBDIRSUFFIX}|" makefiles/config.mk

before make is enough to make it behave.

rworkman · 01-13-2010, 05:02 PM

No need for a patch even. Assuming INSTALLDIR is a synonym for PREFIX, then this will work:

Code:

make LIBDIR=/usr/lib${LIBDIRSUFFIX}
make install LIBDIR=/usr/lib${LIBDIRSUFFIX}

If INSTALLDIR includes the $PKG directory, then you'd need to do this instead:

Code:

make LIBDIR=/usr/lib${LIBDIRSUFFIX}
make install LIBDIR=$PKG/usr/lib${LIBDIRSUFFIX}

Well, this is untested, of course.

gapan · 01-13-2010, 05:19 PM

Yep. This one works too.

Code:

make LIBDIR=/usr/lib${LIBDIRSUFFIX}
make install LIBDIR=/usr/lib${LIBDIRSUFFIX}

rworkman · 01-13-2010, 05:42 PM

Cool; thanks. Please mail the maintainer and CC our mailing list.