LinuxQuestions.org
Welcome to the most active Linux Forum on the web.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 01-12-2017, 07:26 AM   #1
glorsplitz
Senior Member
 
Registered: Dec 2002
Distribution: slackware!
Posts: 1,304

Rep: Reputation: 368Reputation: 368Reputation: 368Reputation: 368
/etc/nanorc empty after last current updates


ls -la /etc/nanorc*
-rw-r--r-- 1 root root 0 Jan 10 17:34 /etc/nanorc
-rw-r--r-- 1 root root 8777 Nov 3 15:07 /etc/nanorc.orig


ap/nano-2.7.4-x86_64-2.txz: Rebuilt.
Fixed /etc/nanorc.new. Thanks to SeB.

Last edited by glorsplitz; 01-13-2017 at 06:24 AM. Reason: solved
 
Old 01-12-2017, 07:48 AM   #2
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-15.0
Posts: 11,048

Rep: Reputation: Disabled
Weird, as the new nanorc weighs 8777 bytes.

Anyway I attach the new one. You can check it is the new one as it includes
Code:
# set numbercolor cyan
and line numbering is a new feature.
Attached Files
File Type: txt nanorc.txt (8.6 KB, 20 views)
 
Old 01-12-2017, 08:42 AM   #3
GazL
LQ Veteran
 
Registered: May 2008
Posts: 6,882

Rep: Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988Reputation: 4988
Confirmed.

Code:
test@ws1:~$ tar -tvf /srv/slackware/slackware64-current/slackware64/ap/nano-2.7.4-x86_64-1.txz etc/nanorc.new
-rw-r--r-- root/root         0 2017-01-10 22:34 etc/nanorc.new
 
Old 01-12-2017, 10:27 AM   #4
phenixia2003
Senior Member
 
Registered: May 2006
Location: France
Distribution: Slackware
Posts: 1,052

Rep: Reputation: 1008Reputation: 1008Reputation: 1008Reputation: 1008Reputation: 1008Reputation: 1008Reputation: 1008Reputation: 1008
Hello,

nano.SlackBuild fails to generate nanorc.new because the source for this file has been renamed from nanorc.sample to sample.nanorc :

Code:
$ ls nano-2.6.0/doc/*nanorc*
nano-2.6.0/doc/nanorc.sample  nano-2.6.0/doc/nanorc.sample.in
...

$ ls nano-2.7.4/doc/*nanorc*
nano-2.7.4/doc/nanorc.5       nano-2.7.4/doc/sample.nanorc
nano-2.7.4/doc/nanorc.5.html  nano-2.7.4/doc/sample.nanorc.in

$ grep nanorc.new nano.SlackBuild
sed 's?^# include?include?g' doc/nanorc.sample > $PKG/etc/nanorc.new 

$ ./nano.SlackBuild 
....
make[2]: Leaving directory `/tmp/nano-2.7.4'
make[1]: Leaving directory `/tmp/nano-2.7.4'
mkdir: created directory ‘/tmp/package-nano/etc’
sed: can't read doc/nanorc.sample: No such file or directory
cp: cannot stat ‘BUGS’: No such file or directory
cp: cannot stat ‘UPGRADE’: No such file or directory
cp: cannot stat ‘doc/nanorc.sample’: No such file or directory
...

--
SeB

Last edited by phenixia2003; 01-12-2017 at 10:29 AM.
 
1 members found this post helpful.
Old 01-12-2017, 07:37 PM   #5
MadMaverick9
Member
 
Registered: Aug 2010
Posts: 353
Blog Entries: 4

Rep: Reputation: Disabled
These kind of errors could have been caught, if ...

Why isn't "set -e" used in Slackware's scripts?

This is the third time already:
  1. Seamonkey 2.46: missing include files
  2. Subversion 1.7.22 (in 14.0 and probably 14.1 as well): ruby language binding fails to build
  3. And now Nano.
Most SBo scripts actually do a "set -e".
 
Old 01-12-2017, 07:38 PM   #6
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 4,651

Rep: Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772Reputation: 1772
Anyway, it's fixed already in latest current update
 
Old 01-12-2017, 07:43 PM   #7
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: West Jordan, UT, USA
Distribution: Slackware
Posts: 8,792

Rep: Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656
Quote:
Originally Posted by MadMaverick9 View Post
These kind of errors could have been caught, if ...

Why isn't "set -e" used in Slackware's scripts?

This is the third time already:
  1. Seamonkey 2.46: missing include files
  2. Subversion 1.7.22 (in 14.0 and probably 14.1 as well): ruby language binding fails to build
  3. And now Nano.
Most SBo scripts actually do a "set -e".
Careful, the goal of SBo was to not differ from Slackware's SlackBuilds and then having users question Pat's scripts

Quote:
For that reason, the golden rule was established that all SlackBuild entries at slackbuilds.org would follow the style of the “mother” scripts. Basically, a SBo script should be transferable into the Slackware core distro without feeling out of place. I think it was this rule that made Pat give the nod of approval. Just think of the scenario where the SBo site would become popular using a style of SlackBuild scripts that did not look at all like Slackware’s own. There was a good chance that people would start demanding that Slackware must adopt the scripting style of SBo. This was a big no-no.

SOURCE: http://alien.slackbook.org/blog/ten-...ackbuilds-org/
NOTE: I don't think that a minor change like set -e was what they were thinking of when they were intending to not differ from the "mother" scripts and I said the above jokingly. Overall, it probably wouldn't be a bad idea for Pat to incorporate set -e into future versions of his SlackBuild scripts, but as always, it's his distro, so we'll see what happens.
 
Old 01-12-2017, 08:18 PM   #8
volkerdi
Slackware Maintainer
 
Registered: Dec 2002
Location: Minnesota
Distribution: Slackware! :-)
Posts: 2,465

Rep: Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373Reputation: 8373
Quote:
Originally Posted by MadMaverick9 View Post
These kind of errors could have been caught, if ...

Why isn't "set -e" used in Slackware's scripts?

This is the third time already:
  1. Seamonkey 2.46: missing include files
  2. Subversion 1.7.22 (in 14.0 and probably 14.1 as well): ruby language binding fails to build
  3. And now Nano.
Most SBo scripts actually do a "set -e".
If it is supposed to be a fatal error, I use || exit 1 after the command. But "set -e" does not work well when an error should be considered "soft" -- for example, I like to try to pack up any documentation file that's ever been seen in the sources, and don't want to have to edit that list when a file disappears. And if it's only gone for one release, editing the list could cause it to be dropped if it returns.

Basically, there are pros and cons to either approach, but I prefer to handle erroring out line by line.
 
7 members found this post helpful.
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
XFCE notification tray empty after latest -current update dsotm Slackware 2 03-17-2016 07:01 PM
recent current updates, nscd.conf empty? glorsplitz Slackware 7 12-19-2015 03:04 PM
[SOLVED] Empty lines in xdm config files after current update BroX Slackware 3 07-10-2013 01:02 PM
[SOLVED] multiline string regex for nanorc syntax not proper even with start/end keywords deskt0plinux Linux - Software 6 09-08-2012 01:34 AM
Slackware-Current kde menus empty TNWestTex Slackware 3 04-09-2007 07:52 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 02:28 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration