LinuxQuestions.org
Download your favorite Linux distribution at LQ ISO.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 01-05-2020, 05:44 AM   #1
kgha
Member
 
Registered: May 2018
Location: Sweden
Distribution: Slackware 64 -current multilib from AlienBob's LiveSlak MATE
Posts: 236

Rep: Reputation: 151Reputation: 151
Failure when trying to rebuild ufraw


Occasionally I edit raw pics and have used ufraw for this. After upgrading lensfun to Eric's 0.3.95 version, ufraw stopped working (no liblensfun.so.1). I tried to rebuild ufraw but make ended with

Code:
dcraw_api.cc: In function ‘void dcraw_finalize_raw(dcraw_data*, dcraw_data*, int*)’:
dcraw_api.cc:692:13: error: ‘pixels’ not specified in enclosing ‘parallel’
  692 |             for (int i = 0; i < pixels; i++) {
      |             ^~~
dcraw_api.cc:689:21: error: enclosing ‘parallel’
  689 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
dcraw_api.cc:695:77: error: ‘black’ not specified in enclosing ‘parallel’
  695 |                gint32 p = (gint64)(get_pixel(h, dark, i, cc, pixels) - black) *
      |                                                                        ^~~~~

dcraw_api.cc:689:21: error: enclosing ‘parallel’
  689 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
dcraw_api.cc:705:13: error: ‘pixels’ not specified in enclosing ‘parallel’
  705 |             for (int i = 0; i < pixels; i++) {
      |             ^~~
dcraw_api.cc:702:21: error: enclosing ‘parallel’
  702 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from uf_glib.h:20,
                 from dcraw_api.cc:27:
dcraw_api.cc:709:82: error: ‘black’ not specified in enclosing ‘parallel’
  709 |                                         ((gint64)h->raw.image[i][cc] - black) *
      |                                                                        ^~~~~

/usr/include/glib-2.0/glib/gmacros.h:805:23: note: in definition of macro ‘MIN’
  805 | #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
      |                       ^
dcraw_api.cc:708:47: note: in expansion of macro ‘MAX’
  708 |                     h->raw.image[i][cc] = MIN(MAX(
      |                                               ^~~
dcraw_api.cc:702:21: error: enclosing ‘parallel’
  702 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
make[2]: *** [Makefile:886: dcraw_api.o] Error 1
make[2]: Leaving directory '/tmp/SBo/ufraw-0.22'
make[1]: *** [Makefile:1026: all-recursive] Error 1
make[1]: Leaving directory '/tmp/SBo/ufraw-0.22'
make: *** [Makefile:581: all] Error 2
Not sure how to interpret this. I rebuilt dcraw, but no change.

Managed to build rawtherapee-5.7 using the SBo buildscript, so I'm still able to dabble with raw files. Maybe I should just accept that dcraw and ufraw no longer works on -current?
 
Old 01-05-2020, 09:07 AM   #2
kgha
Member
 
Registered: May 2018
Location: Sweden
Distribution: Slackware 64 -current multilib from AlienBob's LiveSlak MATE
Posts: 236

Original Poster
Rep: Reputation: 151Reputation: 151
After some googling I found three different patches that solved the build problems:
https://bugs.gentoo.org/685138
https://sourceforge.net/p/ufraw/bugs/425/

EDIT: Spoke too soon... package builds ok, starts ok, but when trying to open a raw file it segfaults...

Last edited by kgha; 01-05-2020 at 09:27 AM.
 
Old 01-06-2020, 05:02 AM   #3
kgha
Member
 
Registered: May 2018
Location: Sweden
Distribution: Slackware 64 -current multilib from AlienBob's LiveSlak MATE
Posts: 236

Original Poster
Rep: Reputation: 151Reputation: 151
Well, this is a first: don't think I ever have posted about a problem without getting good advice or elucidating information. My premature marking SOLVED may of course have contributed to this.
Well, in a way it is solved - rawtherapee works fine. I also tried darktable-3.0.0 which builds and runs fine, but I found the GUI a bit unfriendly. The sweet and simple GUI is the only thing I miss, having to ditch ufraw.
Found the nufraw fork of ufraw, and with a couple of patches I managed to build that one too, but once again it segfaulted (with no additional info) when trying to open a raw file.
 
Old 01-06-2020, 10:26 AM   #4
TracyTiger
Member
 
Registered: Apr 2011
Location: California, USA
Distribution: Slackware
Posts: 504

Rep: Reputation: 247Reputation: 247Reputation: 247
Quote:
Originally Posted by kgha View Post
Well, this is a first: don't think I ever have posted about a problem without getting good advice or elucidating information.
Look at the lack of response as an opportunity. You continued to put out effort and solved more of the problems. You may expand your discovery of Internet resources such as looking for assistance on the Slackware chat channel. It's an opportunity to expand your use of resources.

I've found that when I'm not "handed" the answer to a technical problem that I can usually figure it out or get the answer from other Internet sources, usually it's a combination of both. I then realize that I was just being lazy by asking for help before I had fully explored the problem on my own (not calling you lazy).

When we are "ignored" in a forum we learn that next time we need to pick a problem/question that is more interesting to other forum members.

Note that I know nothing about "ufraw".
 
Old 01-06-2020, 12:01 PM   #5
kgha
Member
 
Registered: May 2018
Location: Sweden
Distribution: Slackware 64 -current multilib from AlienBob's LiveSlak MATE
Posts: 236

Original Poster
Rep: Reputation: 151Reputation: 151
Cheers, TracyTiger, good points.
I don't feel ignored, nor disappointed - only slightly surprised. And yes, I have learnt something from my searches.
It was probably a mistake upgrading lensfun to 0.3.95 from https://slackware.nl/alien-kde/curre...t/x86_64/deps/ since I don't have his Plasma5 installed, even if I have some stuff from his kde /deps/ section installed. I can see that every other distro that have ufraw in their repos include lensfun-0.3.2. It might be that someone will solve the issue when the next lensfun version takes dominance.
I could of course have created a dirty symlink from liblensfun.so.2 to so.1, but that's an emergency solution and I ususally avoid it in order to prevent new problems in the future.
So I've reverted to theprevious lensfun version, reinstalled my old ufraw package, and also rebuilt rawtherapee - everything's fine now.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
ufraw software noelc Linux - Software 6 08-11-2009 05:54 AM
Question on Ufraw plugin for Gimp noelc Linux - Software 4 08-01-2009 03:37 AM
LXer: UFRaw 0.12 could make new converts to open source RAW photo conversion LXer Syndicated Linux News 0 08-29-2007 01:10 PM
UFRaw cthomas Linux - Software 5 09-25-2005 01:03 PM
UFraw cthomas Linux - Software 1 08-23-2005 11:19 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 10:48 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration