LinuxQuestions.org
Download your favorite Linux distribution at LQ ISO.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 12-01-2022, 12:02 AM   #1
jloco
Member
 
Registered: Apr 2016
Location: Detroit, MI
Distribution: Slackware
Posts: 81

Rep: Reputation: 80
Regression on gptfdisk 1.0.9 (on -current)


Some time a month or so ago in my testing of gnome liveslak images I lost the ability to write disks with Eric's iso2usb.sh script. It no longer worked at all and would completely destroy any partition table on said disk when ran. Chalked it up to PEBCAK and started testing in virt-manager instead.

Did a fresh install and it kept happening there as well. Then recently I tried a MX Linux live usb thingy and the program I used to write to usb worked within my VM, which finally gave me the idea, it's not me... it's Slackware!

As of 2 weeks ago Arch pushed a patch (there's actually 3 they added) to gptfdisk from this merge request, and I told myself to try it out on Slackware but hadn't gotten to it. Today was that day, and what do ya know? IT WORKS!

This is likely important to patch, as gdisk seems to destroy any partition table that even looks it's way, and I'm honestly amazed no one has complained about this yet, surely someone has wiped a drive by now?!?

Anyway, now I can safely resume writing persistent isos to usb now for testing and I am happy again I no longer need to use VMs to do this.
 
Old 12-01-2022, 06:22 AM   #2
brobr
Member
 
Registered: Oct 2003
Location: uk
Distribution: Slackware
Posts: 911

Rep: Reputation: 227Reputation: 227Reputation: 227
Out of curiosity I followed your links. FWIW, the arch patch is not for gpt but popt, that parses command-line options (from man popt). The pull-request to gpt seems to address possible (maybe unexpected) output from popt. Which of these patches did you test?

Last edited by brobr; 12-01-2022 at 06:24 AM.
 
Old 12-01-2022, 06:36 AM   #3
jloco
Member
 
Registered: Apr 2016
Location: Detroit, MI
Distribution: Slackware
Posts: 81

Original Poster
Rep: Reputation: 80
I only tested them together with the gptfdisk 1.0.9 sources and built a new package. Previously, if using gdisk, it would write a partition entry and save etc and the disk would appear fine. But using the liveslak iso2usb.sh script on the same drive (which also uses gdisk) it would wipe the partition data and crash immediately with an error about it requesting to write beyond the available space.

Since applying the 3 patches, the program works as expected now and no longer corrupts gpt headers/disks during writing. Whatever the patches are patching (I'm not on that machine currently), it seems to be working as intended now.
 
2 members found this post helpful.
Old 12-01-2022, 10:04 AM   #4
keefaz
LQ Guru
 
Registered: Mar 2004
Distribution: Slackware
Posts: 6,541

Rep: Reputation: 866Reputation: 866Reputation: 866Reputation: 866Reputation: 866Reputation: 866Reputation: 866
I wonder why those disk tools use external library for parsing command line options... Anyway good information, thanks
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] regression on -current with new autoconf-2.70 nobodino Slackware 2 01-12-2021 12:34 PM
[SOLVED] Slackware-current: Bash-completion regression orbea Slackware 2 04-05-2016 04:44 PM
[SOLVED] i915 regression in -current NicePics13 Slackware 12 09-13-2015 06:36 PM
xorg regression in -current mina86 Slackware 5 03-06-2013 11:48 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 10:35 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration