Using apt-get in if statement in bash script

jax8 · 03-28-2009, 01:53 PM

Hi

I have a problem using apt-get in my bash script.

Quote:

logFile='log.txt'
packageList='slapd'

for package in $packageList; do
echo -n "Installing $package : Please Wait "
if [ $(apt-get -y install "$package" | tee -a "$logFile") ]; then
echo '(Installed)'
else
echo "Error installing $package - view $logFile for details"
exit 1
fi
done

When I run this I get an error that says

" ./ubuntuSchoolServerInstaller.sh: line 63: [: too many arguments"

In my script line 63 is in bold above.

TBC Cosmo · 03-28-2009, 02:12 PM

Try this (I have not tested)

Code:

logFile='log.txt'
packageList='slapd'

exec >$logFile 2>&1


for package in $packageList; do
echo -n "Installing $package : Please Wait "
if apt-get -y install "$package"; then
echo '(Installed)'
else
echo "Error installing $package - view $logFile for details"
exit 1
fi
done

jax8 · 03-28-2009, 02:52 PM

Quote:

Originally Posted by TBC Cosmo

Try this (I have not tested)

Code:

logFile='log.txt'
packageList='slapd'

exec >$logFile 2>&1


for package in $packageList; do
echo -n "Installing $package : Please Wait "
if apt-get -y install "$package"; then
echo '(Installed)'
else
echo "Error installing $package - view $logFile for details"
exit 1
fi
done

That seems to work thanks.

Do you know why this does not work?

Code:

if [ $(apt-get -y install "$package") ]; then

TimothyEBaldwin · 03-29-2009, 01:11 PM

Because $(some command) substitutes the standard output of "some command" for itself. The output of apt-get is not sensible input for the [ command.

Perhaps you meant

Code:

if [ (apt-get -y install "$package") ]; then

that is without the dollar sign before the bracket.

jax8 · 03-29-2009, 10:23 PM

Ok, thanks