syntax error near unexpected token `else'

nav007_2000 · 02-10-2011, 04:44 PM

Hello all,
I have an ubuntu 10.10 server and want to run a script on it to check if a process is running. If it is not running, it will start the process and also write into a log file.

When running the script i get the following error message:

syntax error near unexpected token `else'

Here is my script. Hope someone can help.

#!/bin/bash
process=`ps auxwww | grep test.x6 | grep -v grep | awk '{print $1}'`
if [ -z "$process" ]; then
echo "Couldn't find test.x86 running Restarting test Server" >>/var/testlog/test.check
echo && date >>/var/testlog/test.check
/emu/test/test.x86 -d >>/var/testlog/testdbg.log;
else echo "test.x86 is still OK!" >>/var/testlog/test.check
fi

xeleema · 02-10-2011, 05:06 PM

Greetingz!

I've always seen "else" get it's own line....

Code:

#!/bin/bash
process=`ps auxwww | grep test.x6 | grep -v grep | awk '{print $1}'`
if [ -z "$process" ]; then
   echo "Couldn't find test.x86 running Restarting test Server" >>/var/testlog/test.check
   echo && date >>/var/testlog/test.check
   /emu/test/test.x86 -d >>/var/testlog/testdbg.log;
else
   echo "test.x86 is still OK!" >>/var/testlog/test.check
fi

crabboy · 02-10-2011, 05:10 PM

Yes, and the semicolon before the else is not necessary. A cleaner way to test for the process would be to use pgrep. Is ps and grep all in one and it sets the return code based on a find. Here is its usage:

Code:

EXECUTABLE=/emu/test/test.x86
PROCESS=`basename $EXECUTABLE`
CHECK_FILE=/var/log/$PROCESS.check
LOG_FILE=/var/log/$PROCESS.log

pgrep $PROCESS  > /dev/null
if [ $? -eq 1 ]; then
echo "Couldn't find $PROCESS running Restarting Server" >> $CHECK_FILE
date >> $CHECK_FILE
$EXECUTABLE &
else
   echo "$PROCESS is still OK!" >> $CHECK_FILE
fi

nav007_2000 · 02-11-2011, 03:25 AM

Thanks for your help crabboy

i now get the following errors:

./chk.sh: line 14: syntax error: unexpected end of file

appilu · 02-11-2011, 03:47 AM

Hi nav,

your first code itself is working nice without semicolon.
Also crabboy's code is working fine .

grail · 02-11-2011, 04:46 AM

You will need to show what your newly adjusted code looks like seeing you have changed it and now have a different error.

nav007_2000 · 02-11-2011, 08:07 AM

Could it be that I am running the code on an ubuntu desktop version?

Here is my code:

EXECUTABLE=/emu/cccam/cccam.x86
PROCESS=`basename $EXECUTABLE`
CHECK_FILE=/var/log/$PROCESS.check
LOG_FILE=/var/log/$PROCESS.log
pgrep $PROCESS > /dev/null
if [ $? -eq 1 ]; then
echo "Couldn't find $PROCESS running Restarting Server" >> $CHECK_FILE
date >> $CHECK_FILE
$EXECUTABLE &
else
echo "$PROCESS is still OK!" >> $CHECK_FILE
fi

crts · 02-11-2011, 09:14 AM

Hi,

your syntax looks ok. The semicolon/else issue is unusual but it should not throw an error. I see a windows logo in the left column of your post. Did you by any chance edit/create the file under windows? It might be some CR/LF issue. Execute the following command

Code:

od -c /path/to/your/script

Look out for suspicious character-sequencies like
\r\n

If it turns out that it is a CR/LF issue then you can correct this with

Code:

sed -i 's/\r//' <your file>