LinuxQuestions.org

LinuxQuestions.org (/questions/)
-   Programming (https://www.linuxquestions.org/questions/programming-9/)
-   -   Small C issue.. "expected expression before.." (https://www.linuxquestions.org/questions/programming-9/small-c-issue-expected-expression-before-693678/)

skuzye 12-31-2008 12:21 PM

Lightening fast answer :P

Quote:

...(if it matters) execution speed...
Now talking about coding itself (not restricted by this kind of silly things but with bigger issues), I mean, it won't make any difference at all because nowadays nobody uses a processor that would care about this slight change in code. The question is: even if it's only to make things more correct as possible and not for the sake of speed improvement (but not forgetting about it), should I care about these stuff?
Quote:

When you have a big array (or more complex container) of objects, you should consider data size as a factor in designing those objects. When you have ordinary objects one at a time, you don't consider their size.
That's interesting. I've been reading some stuff and I think a light came to me hahaha...

Let me know if I understood something:

1. Shrinking code would matter because smaller code is stored on faster memories. (link)

Quote:

Your programs get faster when they have stronger locality, because that makes the caching work better. The easiest way to make programs fast is therefore to make them small.
2. Local variables doesn't matter too much if it's large or not because there are not stored with program code in memory. It's stored at stack segment while code itself is stored at text segment. (Hacking - The Art of Exploitation 2nd Edition)

Is this right?

Quote:

How about "enum"? Was that introduced yet? I think enum is the best data type for this in C.
I'm currently reading Chapter 1.6 and enum is presented at 2.3.

Skuzye

johnsfine 12-31-2008 05:00 PM

Quote:

Originally Posted by skuzye (Post 3392763)
1. Shrinking code would matter because smaller code is stored on faster memories.

That is often true, so smaller code often means faster even if the ordinary CPU execution speed of the smaller code isn't faster.

I didn't mean to imply you should routinely take that into account when coding. You shouldn't. But you seemed to want to know what would be better when you think about the possibility that lots of tiny differences might add up to a significant difference. Then the code size for using char local variables vs. int local variables might add up to something that matters. The data size difference won't.

Quote:

2. Local variables doesn't matter too much if it's large or not because there are not stored with program code in memory. It's stored at stack segment while code itself is stored at text segment.
Large local variables (arrays and structures, etc.) are stored on the stack. Small local variables in complicated functions may also be stored on the stack. But small local variables in simple functions are stored in registers.

On the stack, the data storage size difference between a char and an int usually makes less difference than when stored elsewhere in memory. More often than not, it makes no difference. When stored in a register it is near certain that the data storage size makes no difference (the rest of that register won't be used for anythig else anyway).

So even when you care about tiny differences (such as the possible code size difference) which you usually shouldn't care about, you still shouldn't care about the strage space fscalar local variables.

Quote:

I'm currently reading Chapter 1.6 and enum is presented at 2.3.
When you ask about "good practice" (as you did earlier today) you should expect to be told to use features that are further ahead than your lessons have reached so far.

skuzye 01-01-2009 01:08 PM

Thanks a lot!

Quote:

When you ask about "good practice" (as you did earlier today) you should expect to be told to use features that are further ahead than your lessons have reached so far.
No problem at all. It's good because when I get there I know it's important and I'll pay more attention to it :D

Well I guess this is enough for this thread if you don't mind. I can't see how to go further, although if you have any indications of websites or book I'd appreciate.

Skuzye

agemo 01-02-2009 06:07 AM

A couple of suggestions, sorry I didn't post them earlier but they didn't came to mind then:
First, avoid using #define when dealing with constants. Use const typename for that. const gives your compiler a chance to check for type compatibility and it is also useful to avoid errors like the one you've experienced. #define is useful when you want to write portable code, for example:
Code:

#ifdef PLATFORM == WINDOWS
void draw_line(int x1, int y1, int x2, int y2)
{
  //draw a line using DirectX API
}
#elif PLATFORM == LINUX
void draw_line(int x1, int y1, int x2, int y2)
{
  //draw a line using OpenGL API
}
#else
void draw_line(int x1, int y1, int x2, int y2)
{
  //implement some kind of slow, universal, line-drawing function
}

Second, let's say you are given a list of numbers from 0 to 2^32 - 1 (unsigned ints), and you want to see which numbers appear and which don't. If you want to solve this linearly, meaning you make a single pass over the data, you could implement a char array of 2^32 elements, with x[q] == 1 if q is in the list and x[q] == 0 if q isn't. In terms of space that would take 2^32 bytes = 2^22 Kbytes = 2^12 Mbytes = 4GB of RAM!!
Instead, think of what will happen in case you use EVERY bit in your array (and not just the first from every element).
Thus, the 0-th bit of x[0] will store weather 0 is located in the list or not;
the 1-st bit of x[0] will store info. about 1
...
the 7-th bit of x[0] will store info. about 7
Information about number 59412 will be stored on the fourth bit of x[7426]. Using this technique the total size drops 8 times, or sizeof(char), to a respectable value of 512MB of RAM.
In case you were not familiar with this method, I suggest looking up 'bitsets' or 'bit arrays' (C++ has it's own bitset class, but I would stay away from that until I've understood them well).
In case you already knew about bitsets... well sorry to take you time :P Maybe somebody else will benefit from it.

Cheers!

skuzye 01-02-2009 07:52 AM

@agemo

Really interesting. I laughed when you said it would take 4GB of RAM, I can't even imagine such a result in a computer with less RAM than it (which isn't so rare, huh..hehe)

I didn't know about it thank you, you didn't take my time :P

johnsfine 01-02-2009 09:16 AM

Quote:

Originally Posted by agemo (Post 3394378)
First, avoid using #define when dealing with constants.

I agree.

Quote:

Use const typename for that.
My lack of memory regarding C may be a problem here (I've used C++ rather than C for a long time), but I think there are some stupid flaws in the language rules for const typename that make it a much less effective construct than it ought to be.

Certainly in C++ there are such flaws.

I always use enum when the constant I'm defining logically ought to be a const int (I've done that for so long, I've forgotten some of the flaws in const that made me start doing it) . C++ seems to have better support for enum and an enum can do all the things that a const int could have done.

IIRC, const double is even more flawed in C++ language rules than const int and there is no similar work around. I still try hard to avoid needing to use #define, which is even more flawed.

A scalar constant should be something you can define in a header file with the scoping benefits of whatever scope (typically a class definition) you want to give it. C++ doesn't work that way, which is a flaw in the language specification.

#define ignores ordinary scoping rules and its scope is normally the rest of the compilation unit in which it was seen. That makes it even worse than the flawed rules for const typename.

swodniw 01-02-2009 10:01 AM

Quote:

Originally Posted by johnsfine (Post 3394557)
I agree.
My lack of memory regarding C may be a problem here (I've used C++ rather than C for a long time), but I think there are some stupid flaws in the language rules for const typename that make it a much less effective construct than it ought to be.

Certainly in C++ there are such flaws.

Please explain what these "stupid flaws" are.

Quote:

I always use enum when the constant I'm defining logically ought to be a const int (I've done that for so long, I've forgotten some of the flaws in const that made me start doing it) . C++ seems to have better support for enum and an enum can do all the things that a const int could have done.
What are the differences between C and C++ enums besides using the enum keyword?

Quote:

IIRC, const double is even more flawed in C++ language rules than const int and there is no similar work around. I still try hard to avoid needing to use #define, which is even more flawed.
Work around for what flaw?
Quote:

A scalar constant should be something you can define in a header file with the scoping benefits of whatever scope (typically a class definition) you want to give it. C++ doesn't work that way, which is a flaw in the language specification.
Why should it be this way for all scalar types and who says it is a flaw? Constant class members have static linkage, every heard of the one definition rule?

johnsfine 01-02-2009 10:32 AM

Quote:

Originally Posted by swodniw (Post 3394628)
Why should it be this way for all scalar types and who says it is a flaw? Constant class members have static linkage, every heard of the one definition rule?

Yes I've heard of the one definition rule. I just happen to think language design decisions should have been made in the way that lets us write the most effective and maintainable software in that language, not to satisfy abstract absolutes of language purity.

C++ would be a better language (would let us write more effective and more maintainable programs) if constant class members could be defined within the class definition.

swodniw 01-02-2009 10:34 AM

Quote:

Originally Posted by johnsfine (Post 3394670)
C++ would be a better language (would let us write more effective and more maintainable programs) if constant class members could be defined within the class definition.

Some can. So what are these "stupid flaws" you talk about.


All times are GMT -5. The time now is 05:12 PM.