Shell script for moving files into directory have common names

1QAZ2WSX · 08-21-2017, 01:39 AM

MY files are
1996-08-30T02.11.41.940_10
1997-03-04T17.24.17.650_17
1997-04-01T15.43.26.390_20

And folders
1996-08-30T02.11.41.940_5.1
1997-03-04T17.24.17.650_5.0
1997-04-01T15.43.26.390_4.5

the files and folders are in same directories. I want to move file to a folder whose name is matching
ex:
The file 1996-08-30T02.11.41.940_10 should be move in folder 1996-08-30T02.11.41.940_5.1

So far I have did, but no use

#!/bin/bash
for file in ./*T* ; do mv -v $file ${file%_*}; done

pan64 · 08-21-2017, 01:54 AM

I do not really understand. where are the files originally located, what is the target dir/filename, and what is the problem with your script?

astrogeek · 08-21-2017, 02:06 AM

Please place your code snippets inside [CODE]...[/CODE] tags for better readability. You may type those yourself or click the "#" button in the edit controls.

I would probably do it with find, but as is your code is very close to working for the examples as given.

Code:

#!/bin/bash
for file in ./*T* ; do mv -v $file ${file%_*}; done

The red part does not make sense, but this should work:

Code:

#!/bin/bash
for file in ./*T* ; do mv -v $file ${file}_*; done

If the examples are truly representative of the actual files and directories, and the files are all in the parent directory of the targets where the script is run, that will be sufficient.

*** EDIT

pan64's post made me do a double-think and realise the above is not right...

So, falling back to find which I should have done first, and cleaning up after myself:

Code:

.
├── 1996-08-30T02.11.41.940
├── 1996-08-30T02.11.41.940_5.1
├── 1997-03-04T17.24.17.650
├── 1997-03-04T17.24.17.650_5.0
├── 1997-04-01T15.43.26.390
└── 1997-04-01T15.43.26.390_4.5

while read file; do
mv $file ${file}_*
done< <(find ./ -type f -name '*T*')

.
├── 1996-08-30T02.11.41.940_5.1
│   └── 1996-08-30T02.11.41.940
├── 1997-03-04T17.24.17.650_5.0
│   └── 1997-03-04T17.24.17.650
└── 1997-04-01T15.43.26.390_4.5
    └── 1997-04-01T15.43.26.390

That will still be fragile if you have filenames with spaces or special characters, but I leave that detail for an exercise!

MadeInGermany · 08-22-2017, 06:09 AM

With quoting of variables in conmand arguments

Code:

for file in ./*T* ; do mv -v "$file" "${file%_*}"_*/ ; done

The idea is that "${file%_*}" is the basename, and adding _*/ expands to all matching directories, where hopefully only one matches.