Shell script fixing recursion

tankzeu · 10-11-2018, 01:14 PM

I have this script which straight forward installs an application with version 10 and since now there are version 10 and 11 I have changed it to install the version based on the number you pass to $1.However after testing in the case of version 11 recursion happened with the same file and this logic I cannot move to another file to call,however I decided to call the same file with additional parameter $2 with value for example "XYZ" ,it works correctly ,however is it a bad practise?

BW-userx · 10-11-2018, 01:18 PM

Quote:

Originally Posted by OP

version 11 recursion happened with the same file and this logic I cannot move to another file to call

no code to peak at so... if it works without damaging anything and without errors, is that a bad thing?

tankzeu · 10-11-2018, 01:23 PM

Quote:

Originally Posted by BW-userx

no code to peak at so... if it works without damaging anything and without errors, is that a bad thing?

it doesn't damage things,but for e.g in c++ where there is 1 parameter we cannot do this "trick" so I wondered if it is ok to use it or there is another way to get out of this situation minding the restriction I cannot call other .sh file and use the logic in the file

BW-userx · 10-11-2018, 01:47 PM

explain this part in detail, so I can make sure I am on the same page as you.
"version 11 recursion happened with the same file"
what recursion, it tried to install twice? Because to me, installing an app via a script, with a version change, not much different should take place. all that is needed is an check and assignment of the version number then place it where needed within the script, and the install process should be the same.

post the script if you like, to get a better idea of your logic.

rtmistler · 10-11-2018, 01:47 PM

Moved: This thread is more suitable in Programming and has been moved accordingly to help your thread/question get the exposure it deserves.

You really should post an example of your code to clarify your question.

You're asking about the advisability of coding a certain way, you should show what you've coded.

astrogeek · 10-11-2018, 03:05 PM

I have read the question several times and cannot make a best guess at what is being asked - but others should not have to guess what the question is!

Please review the Site FAQ for guidance in posting your questions and general forum usage. Especially, read the link in that page, How To Ask Questions The Smart Way. The more effort you put into understanding your problem and framing your questions, the better others can help!

grail · 10-12-2018, 03:54 AM

Ditto to astrogeek ... the one thing we should have to do in order to help is make up our own ideas about what is being asked.