[SOLVED] sed inputs $vat twice

anon033 · 07-01-2019, 10:36 PM

I am writing a script to setup profanity (an xmpp client) for me, it actually doesn't do much but add my account to the rc file (as I don't want to store my account in a public repo). I have this:

Code:

#!/bin/sh

echo "setting up profanity..."

echo "enter your account: "

read account

cat $HOME/.config/profanity/profrc | sed "s/account=/account=$account/" > tmp

echo "profanity setup"

but this inputs the varibale twice, ie

Code:

account=user@host.orguser@host.org

Why is it inputting twice?

NevemTeve · 07-01-2019, 11:44 PM

Every run of your script inserts the content of $account. Try this:

Code:

sed "s/^account=.*\$/account=$account/"

Note: make sure your $account doesn't contain / \ or & characters.

teckk · 07-02-2019, 06:51 AM

Code:

echo "setting up profanity..."

echo "enter your account: "

read account

Can be replaced with

Code:

read -p $'setting up profanity...\nenter your account: ' account

anon033 · 07-02-2019, 09:23 AM

Quote:

Originally Posted by teckk

Code:

echo "setting up profanity..."

echo "enter your account: "

read account

Can be replaced with

Code:

read -p $'setting up profanity...\nenter your account: ' account

read -p *prompt* var

is a bashism and doesn't work for a UNIX shell script.

anon033 · 07-02-2019, 09:25 AM

Quote:

Originally Posted by NevemTeve

Every run of your script inserts the content of $account. Try this:

Code:

sed "s/^account=.*\$/account=$account/"

Note: make sure your $account doesn't contain / \ or & characters.

That worked! Thank you so much