[SOLVED] Question about a bash script creating a folder variable

TwoPresidents · 04-16-2012, 08:28 PM

I'm trying to write a script where you create a folder ( different name each time), then you CD into the folder, and then vim starts automatically. Something like this --

Code:

mkdir <example> && cd <example> && vim <filename>

Variables don't work the same way in DOS (the %1), and what I have below doesn't quite work (I'm using CYGWIN and creating directories in windows).

Code:

#!/bin/bash
dir=$dir
mkdir $dir && cd $dir && vim filename.txt

It's technically creating the folder, but it's adding some mysterious dot next to the filename in windows, and when deleted it shows "removed foldername/r". I don't know if that's just how it works, of if I'm doing something wrong. Anything would be appreciated, thank you.

fredora · 04-16-2012, 09:43 PM

I have no access to test this now but here's a swing at it.

Code:

#!/bin/bash


echo "Enter Directory Name: "
read dir

echo "Enter Filename: "
read file

sudo mkdir $dir
vim $file

Assuming you create that in the directory you want to execute it, you shouldnt need to 'cd' to it.
Double check you have r+x permissions on the file
then execute -> ./scriptname.sh

Let me know if that works.

TwoPresidents · 04-16-2012, 10:02 PM

Here's the result. I swear if I can get that "/r" out of the way, then I'm good to go. I don't know where it's coming from. No clue. Perhaps CYGWIN is temperamental. Thanks for giving it a shot though, this seems so basic, I shouldn't even be asking it. Haha.

Code:

$ ./scriptname.sh
./scriptname.sh: line 2: $'\r': command not found
Enter Directory Name:
Dir
': not a valid identifierread: `dir
./scriptname.sh: line 5: $'\r': command not found
Enter Filename:
Filename.txt
': not a valid identifierread: `file
./scriptname.sh: line 8: $'\r': command not found

For the hell of it, I tried running it in linux. Didn't work there either, says permission denied, but I'm SU and it still didn't work. Weird. I can both make directories though, and can also create a file, however it doesn't work through the script. Haha. Fun.

TwoPresidents · 04-16-2012, 10:25 PM

I figured it out, for anyone that somehow ends up here.

Fredora's script worked, but you have to use d2u first, which is a program that converts characters from DOS to UNIX (even though you're using a CYGWIN environment in Windows). The correct syntax is below.

Code:

d2u ./<filename>

After you run that, your command should work, presuming the actual code is right. Thanks for the help fredora.

fredora · 04-17-2012, 10:11 AM

Under thread tools at the top, you can mark the thread as solved

theNbomr · 04-19-2012, 06:55 PM

Quote:

Originally Posted by TwoPresidents

I figured it out, for anyone that somehow ends up here.

Fredora's script worked, but you have to use d2u first, which is a program that converts characters from DOS to UNIX (even though you're using a CYGWIN environment in Windows). The correct syntax is below.

Code:

d2u ./<filename>

After you run that, your command should work, presuming the actual code is right. Thanks for the help fredora.

Better still, just create the file with a Cygwin editor, like vi/vim. Then there won't be any superfluous characters there to begin with.
--- rod.