[SOLVED] program to create a link list is giving an error

jamesbon · 09-23-2010, 05:02 AM

I wrote a program to create a link list

Code:

#include <stdio.h>
#include <stdlib.h>
struct node {
	struct node *next, *prev;
	int data;
} *start, *prv;
void add_element(int e);
void read_list ();
static int j = 0;
int main()
{
	int i, element, l, choice;
	choice = 1;
	struct node *temp;
	start = NULL;
	prv = start;
	while (choice == 1) {
		printf("What do you want 0 exit 1 to add\n");
		scanf("%d", &choice);
		if (choice == 0)
			break;
		printf("Enter data to be entered\n");
		scanf("%d", &element);
		add_element(element);
               read_list();
	}

}

void add_element(int e)
{
//      printf("\n printing from function %d\n", e);
	struct node *temp;
	if (j == 0) {
		start = (struct node *)malloc(sizeof(struct node));
		start->next = NULL;
		start->data = e;
		//printf("the data entered is %d \n", start->data);
		j++;
	}


		temp = (struct node *)malloc(sizeof(struct node));
		temp->data = e;
		prv->next = temp;
	          temp->next=NULL;
		prv=temp;//since prv is  global pointer if I do not do this step then next time when new memory is allocated prv is still pointing to start or previous pointer what ever the value was so new temp declaration will not have much effect
		j++;

	
}

void read_list()
{
	struct node *temp;
	temp = start;
	while (temp) {
		printf(" %d --> ", temp->data);
		temp = temp->next;
	}
}

but the above program is giving me Segmentation fault at

Code:

		prv->next = temp;

Can any one point me as what mistake have I done?

GazL · 09-23-2010, 05:57 AM

You appear to be using the prv pointer before you've set it. On the first pass through add_element() it will still be set to NULL so prv->next can't be used at that point.

There's a lot of better programmers than me hang out here, but the way I'd do it would be to have a

struct node *firstNode and
struct node *lastNode

When you add a new node:
If firstNode is NULL then set it to point to the new entry.
If lastNode is not NULL, set lastNode->next to point to new entry.
set lastNode to point to the new entry.
set lastNode->next to NULL.

Been a long time since I've done anything like this but I think that's about right. (I'm sure someone will correct me if it's not

)

jamesbon · 09-23-2010, 06:43 AM

I declared prv and start outside the main loop to be global variables.
I did in main ()

Code:

prv=start;

So my doubt is that is this not going to make sure that when add_list is called prv is pointing to same memory location where
start is pointing.

So what is wrong in main () when I

Code:

prv=start;

and use prv in add_list function ?

GazL · 09-23-2010, 06:54 AM

when you set prv=start, start=NULL, so prv=NULL.

jamesbon · 09-23-2010, 07:12 AM

Ok got your point.