Problems reading from file with fgets

joakim12 · 10-06-2007, 04:06 PM

Hi.

I have one little program code in C:

Code:

#include <stdio.h>
#include <stdlib.h>

int main(void){

	FILE *fp;
	fp = fopen("TextFile", "r");

	if (!fp) {
		printf("Error opening file\n");
		return 0;
	};

	char *Line = malloc (200 * sizeof(char));

	fseek(fp, 0, SEEK_END);
	printf("File size: %li\n\n", ftell(fp));
	rewind(fp);

	while(!feof(fp)){
		fgets(Line,200,fp);
		printf("%s", Line);
		printf("Reading position: %li\n\n", ftell(fp));
	};
	return 0;
}

But it prints the last line of text from the file twice and I don't understand why. Isn't the file reading position in the end of file yet or what?

SeRGeiSarov · 10-06-2007, 04:53 PM

Why do you use !feof(fp). I think that !fgets(Line,200,fp) is enough.

P.S. Can I see the text file

Mara · 10-06-2007, 04:57 PM

Clear the buffer before each read (memset to zero).

fgets() reads to a newline or eof. When reading the last line it reads to the newline character, but it's not yet an eof. So it reads again, but the read is empty this time and the eof is reached.