problem with if statement in bash script

crewblunts · 03-11-2006, 11:58 AM

I am getting an error, unexpected token near `fi' with this script.
all the files in question exist.

Code:

#!/bin/bash

exec < files.txt
while read i
do
        if [ mp3info "$i" ]
                cat "$i" >> badFiles.txt
        fi
done

thanks in advance,

Phil V

alunduil · 03-11-2006, 12:14 PM

Quote:

Originally Posted by crewblunts

I am getting an error, unexpected token near `fi' with this script.
all the files in question exist.

Code:

#!/bin/bash

exec < files.txt
while read i
do
        if [ mp3info "$i" ]
                cat "$i" >> badFiles.txt
        fi
done

thanks in advance,

Phil V

Try this:

Code:

#!/bin/bash

exec < files.txt
while read i
do
        if [ mp3info "$i" ]; then
                cat "$i" >> badFiles.txt
        fi
done

jlliagre · 03-11-2006, 12:24 PM

or better:

Code:

...
  if mp3info "$i"
  then
...

crewblunts · 03-11-2006, 12:38 PM

Thank you both. I don't know how i missed 'then'