[SOLVED] problem with function calling functions in bash

lidi · 07-09-2013, 09:38 AM

Hi all,

I wrote a script to update some text files (which contains a list of files), but I made some mistakes.
In the script I defined a function func_ls that takes as parameters the type of file (_type_ls_='tot' or 'ok'), call the corresponding updating function (_func_lsx_=ls_ok or ls_tot), and do some other small things.
I wanted then to add the possibility to call the function with 'all', so that it would call first func_ls with 'tot' and then with 'ok' and I defined also ls_all.
As I defined it, ls_all stops after calling ls_tot and does not go on.
Can you please explain me why or give me some hints or advices ?

Thanks !

code:
func_ls() {
local _type_ls_=$1
local _path_=$2
local _func_lsx_=`det_func_ls $_type_ls_`
local _station=`det_stat_from_path $_path_`
local _filels=`det_name_filels_new $_type_ls_ $_path_`

eval "$_func_lsx_ $_path_ $_station $_filels"

## some other things to do later
}

ls_all(){
local _path_=$1
local _station=$2
local _filels=$3
func_ls 'tot' $_path_ $_station $_filels
func_ls 'ok' $_path_ $_station $_filels
}

rtmistler · 07-09-2013, 12:33 PM

Firstly the way you have it, you do not have to re-assign the arguments to variables, you can pass them to func_ls as is:

Code:

func_ls tot $@

Should be sufficient.

The question remains what the form/shape of what you want to pass to func_ls be. For instance you can put "tot" or "ok" into another variable and then pass that. Ultimately you want it to be just tot or ok without punctuation, correct? I think you should try passing it without the quotes as I've shown.

When you enter into func_ls, you can echo $1 to see what it appears like. So do that.

Also assuming that you have a main part of this script, because ls_all() is also a function, therefore it won't run without a main section. There is no designator excepting bash commands which are not bound within function framing, to make your main section.

grail · 07-09-2013, 02:45 PM

I would suggest that if you have resorted to using 'eval' then you should rethink the entire script.

If you explained your requirement better we may be able to assist.

konsolebox · 07-09-2013, 07:02 PM

If you're using Bash, you could just use indexed arrays and won't need to have to use eval. You just have to put every argument of the command which would include the "command" itself to each element.

Code:

function call_a_function {
    FUNC=$1; shift   ## Equivalent to
    ARGS=("$@")      ## FUNC=$1; ARGS=("${@:2}")
    COMMAND=("$FUNC" "${ARGS[@]}")
    "${COMMAND[@]}"  ## Execute command.
}
call_a_function do_something a b c

Which is just equivalent to:

Code:

function call_a_function {
    FUNC=$1; shift
    "$FUNC" "$@"
}

or

Code:

function call_a_function {
    "$1" "${@:2}"
}

or

Code:

function call_a_function {
    "$@"
}