Problem in 'makefile'.....

apanimesh061 · 11-24-2010, 10:17 AM

This is the makefile....

Code:

animesh:main.o input.o bsort.o output.o
	gcc -o animesh main.o input.o bsort.o output.o
main.o:main.c output.c
	gcc -c main.c
input.o:input.c A.h
	gcc -c input.c
bsort.o:bsort.c input.c
	gcc -c bsort.c
output.o:output.c bsort.c
	gcc -c output.c

This is bsort.c

Code:

#include "input.c"
int j,k,t;
void bub_sort()
{
   for (j=0 ; j<10 ; ++j)
        {
           for (k=0 ; k<(9-j) ; ++k)  
                {  
                   if (c[k] > c[k+1])
                       t=c[k];
                       c[k]=c[k+1];
                       c[k+1]=t;
                }
        }
}

This is input.c

Code:

#include "A.h"
int c[10], i;
void insert()
{
    printf ("Enter the array.....");
    for (i=0 ; i<=10 ; ++i)
        scanf ("%d", &c[i]);  
}

This is A.h

Code:

#include <stdio.h>

This is main.c

Code:

#include "output.c"
extern void insert();
extern void bub_sort();
extern void op();
void main()
{
   void insert();
   void bub_sort();
   void op();
}

This is output.c

Code:

#include "bsort.c"
void op
{
  printf("The final sorted array is...");
  for (j=0 ; j<=10 ; ++j)
     printf("%d", c[j]);
}

I am having a lot of errors that I am not able to correct...!!!!!!!
Errors are mainly due to multiple declarations of the functions....I cannot debug those errors.....
Please help !!!!!
:|

GrapefruiTgirl · 11-24-2010, 10:23 AM

Quote:

Originally Posted by apanimesh061

I cannot debug those errors.....
Please help !!!!!
:|

Hi there!

Thank you for providing all the program code. The more information included, the better.

But:

While we probably have members who can determine exactly what errors you are getting just by looking at the code, it is generally a very good idea to include the errors in your thread!

So, please show us the error-filled output that you get when you execute `make` on your Makefile, so folks can see exactly what errors you're getting..

ntubski · 11-24-2010, 01:05 PM

Don't #include .c files.

PS the following makefile is sufficient (assuming GNU make):

Code:

CC=gcc
animesh:main.o input.o bsort.o output.o
	$(CC) -o $@ $^

input.o: A.h

apanimesh061 · 11-25-2010, 09:12 AM

@GrapefruiTgirl....
This is the long list of errors......!!!!! :\

Code:

mint@mint ~/Templates $ make
gcc -c main.c
make: Warning: File `A.h' has modification time 3e+05 s in the future
gcc -c input.c
gcc -o animesh main.o input.o bsort.o output.o
input.o: In function `insert':
input.c:(.text+0x0): multiple definition of `insert'
main.o:main.c:(.text+0x0): first defined here
bsort.o: In function `insert':
bsort.c:(.text+0x0): multiple definition of `insert'
main.o:main.c:(.text+0x0): first defined here
bsort.o: In function `bub_sort':
bsort.c:(.text+0x57): multiple definition of `bub_sort'
main.o:main.c:(.text+0x57): first defined here
output.o: In function `insert':
output.c:(.text+0x0): multiple definition of `insert'
main.o:main.c:(.text+0x0): first defined here
output.o: In function `bub_sort':
output.c:(.text+0x57): multiple definition of `bub_sort'
main.o:main.c:(.text+0x57): first defined here
output.o: In function `op':
output.c:(.text+0x118): multiple definition of `op'
main.o:main.c:(.text+0x118): first defined here
collect2: ld returned 1 exit status
make: *** [animesh] Error 1

If anybody can please make out how to correct them....Thanks....

apanimesh061 · 11-25-2010, 09:16 AM

@nTubski

Well thanks...!!!!
I think I understood the code.
But could you please tell me why shouldn't I include '.c' files ???

ntubski · 11-25-2010, 11:45 AM

When you #include a file, it is the same as copy pasting the entire contents in place of the #include line. So when you put #include input.c inside of bsort.c it will have all the text of bsort.c so it will define bub_sort() too. That means that both bsort.o and input.o will have definitions for bub_sort(). You can't link 2 .o files defining the same function together, thus all your errors.

apanimesh061 · 11-27-2010, 12:09 AM

@ntubski

Does that mean that I have to include a.h, input.c, output.c and bsort.c directly in main.c ?

and makefile should be.....

CC=gcc
animesh:main.o input.o bsort.o output.o
$(CC) -o $@ $^

input.o: A.h

What is meaning of '$^' ?

ntubski · 11-27-2010, 08:59 AM

Quote:

Originally Posted by apanimesh061

Does that mean that I have to include a.h, input.c, output.c and bsort.c directly in main.c ?

No, the code in input.c, for example, gets compiled into input.o. Then you link all the .o files into the program (animesh).

Quote:

What is meaning of '$^' ?

It expands to the names of the prequisites of the rule. In this case it would be the same if you wrote

Code:

CC=gcc
animesh:main.o input.o bsort.o output.o
	$(CC) -o $@ main.o input.o bsort.o output.o

input.o: A.h

But if you add a new .o file using $^ saves you from having to write it in two places in the Makefile. See Automatic Variables