Problem Bash not running.Help Please.

13BUBUS · 05-23-2018, 09:28 PM

Hello everybody,
Im trying to get this script working but what I get is:
14: Syntax error: "(" unexpected (expecting "fi").

Hope you guys can solve my problem...

Thanks in advance.

Here is the script:

Code:

#!/bin/bash
#========================================
#Eb  
#Date:  15/5/2018
#Nombre:ID:Telefono:Direccion:DOB:Departamento:Salario
#
#=========================================
filein="proyecto3.csv"
IFS=$'\n'
if [ ! -f "$filein" ]
then
echo "Cannot find file $filein"
else
  groups=(`cut -d: -f 6 "$filein" | sed 's/ //'`)
  fullnames=(`cut -d: -f 1 "$filein"`)
  userid=(`cut -d: -f 2 "$filein"`)
  usernames=(`cut -d: -f 1 "$filein" | tr [A-Z] [a-z] | awk '{print substr($1,1,1) $2}'`)
fi
for group in ${groups[*]}
do
grep -q "^$group" /etc/group ; let x=$?
if [ $x -eq 1 ]
then
groupadd "$group"
fi
done
  x=0
  created=0
for user in ${usernames[*]}
do
useradd -n -c ${fullnames[$x]} -g "${groups[$x]}" $user 2> /dev/null
if [ $? -eq 0 ]
then
let created=$created+1
fi
echo "${usernames[$x]}" | passwd --stdin "$user" > /dev/null
echo "Complete. $created accounts have been created."
fi

NevemTeve · 05-23-2018, 11:13 PM

You have to use bash to execute this script, not something else like ksh, dash, ash.

Code:

$ bash proyecto3.sh
proyecto3.sh: line 24: groupadd: command not found
proyecto3.sh: line 38: syntax error near unexpected token `fi'
proyecto3.sh: line 38: `fi'

$ dash proyecto3.sh
proyecto3.sh: 14: proyecto3.sh: Syntax error: "(" unexpected (expecting "fi")

13BUBUS · 05-23-2018, 11:31 PM

Quote:

Originally Posted by NevemTeve

You have to use bash to execute this script, not something else like ksh, dash, ash.

Code:

$ bash proyecto3.sh
proyecto3.sh: line 24: groupadd: command not found
proyecto3.sh: line 38: syntax error near unexpected token `fi'
proyecto3.sh: line 38: `fi'

$ dash proyecto3.sh
proyecto3.sh: 14: proyecto3.sh: Syntax error: "(" unexpected (expecting "fi")

Thanks
I tried using bash...what's up with line 38?

hydrurga · 05-23-2018, 11:39 PM

Count your "if"s. Now count your "fi"s.

NevemTeve · 05-23-2018, 11:42 PM

> I'm using bash...

Cool. Now qoute the output of this command:

Code:

bash yourscriptname

scasey · 05-23-2018, 11:43 PM

use

Code:

set -xv

at the top of the script (after the #! line) to get more information.

Also...don't there need to be spaces around the = in assignments? (lines 14 thru 17)

scasey · 05-23-2018, 11:45 PM

Quote:

Originally Posted by hydrurga

Count your "if"s. Now count your "fi"s.

Aha...good catch!

13BUBUS · 05-24-2018, 12:12 AM

Quote:

Originally Posted by hydrurga

Count your "if"s. Now count your "fi"s.

Thank.
Yep, I did the correction. I deleted the last fi but now I still get an error: unexpected end of file.

hydrurga · 05-24-2018, 12:16 AM

Count your "do"s. Now count your "done"s.

13BUBUS · 05-24-2018, 12:33 AM

Quote:

Originally Posted by hydrurga

Count your "do"s. Now count your "done"s.

I still get an error...
Unrecognized option '--stdin'.

Very helpful,thank you.

hydrurga · 05-24-2018, 12:45 AM

To be entirely frank, 13BUBUS, if you're going to write code then you need to start to learn how to think and also do your own internet searches.

Is this your own code? Genuine question.

passwd --help will show you which command line options your version of passwd supports.

An internet search for "passwd --stdin" returns the following page (read the comments carefully):

https://stackoverflow.com/questions/...-shell-script#