php upload scipt error

kudos · 10-02-2003, 03:14 AM

i am having problems with a PHP script to upload files ona http server, when i go 2 upload afile i get this error

Parse error: parse error, unexpected '{' in /website/upload.php on line 14

this happens wit any type of file. trying to upload from my PC to my website.

my html page contains this code

Quote:

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#FFFFFF" text="#000000">
<p>FILE Upload Demo page</p>
<form name="form1" method="post" action="upload.php" enctype="multipart/form-data">
<p>File to be uploaded.
<input type="file" name="file">
</p>
<p>
<input type="submit" name="Submit" value="Submit">
</p>
</form>
<p>  </p>
</body>
</html>

my php file has this

Quote:

<?php

//Fioe Upload script

$path = "/upload"; //Set this to the full path from ther servers home directory to where the file should be.
//Do not leave a trailing slash.

if($file){

print("File name: $file_name<P>/n");
print("File size: $file_size bytes<P>/n");

if(copy($file, "$path/$file"){

print("Your File was uploaded successfully");
}else{
print("ERROR, your file was not successfully uploaded");
}

unlink($file);
}

?>

could some one please help me out here, many thanks
kudos

micxz · 10-02-2003, 03:30 AM

Well if this, " if(copy($file, "$path/$file"){" is line 14. I think you should change it to:

if(copy($file, "$path/$file")){

micxz · 10-02-2003, 03:36 AM

Also This part:

Code:

print("File name: $file_name<P>/n");
print("File size: $file_size bytes<P>/n");

Should be:

Code:

$file_size = filesize($file);
print("File name: $file<P>/n");
print("File size: $file_size bytes<P>/n");

But I don't know if this will solve you problems. Just what I see.

micxz · 10-02-2003, 04:16 AM

Well I coulnd not get you script to work. So Here's a better way:

Code:

<?php
$uploaddir = '/usr/local/httpd/htdocs/uploads/';
$uploadfile = $uploaddir. $_FILES['file']['name'];
print "<pre>";
if (move_uploaded_file($_FILES['file']['tmp_name'], $uploadfile)) {
    print "File is valid, and was successfully uploaded. ";
    print "Here's some more debugging info:\n";
    print_r($_FILES);
} else {
    print "Possible file upload attack!  Here's some debugging info:\n";
    print_r($_FILES);
}
print "</pre>";
exit;
?>

kudos · 10-02-2003, 05:01 AM

HI tx for the replys every one

micxz u was right i could't get it to work ether, but ur script works grate, many thx for that

thx
kudos

kudos · 10-02-2003, 05:32 AM

HI

just tryed 2 upload a 14mb file to the server and i get
Possible file upload attack! Here's some debugging info:
Array
(
)

same ither anythink bigger than a 14mb file eg 500mb

i can upload 3mb ok

i have
upload_max_filesize 900M

do i need to edit any other config settings?

many thanks kudos

nephilim · 10-02-2003, 07:48 AM

What is the setting of max_file_size in php.ini? Maybe you should change that.

nephilim · 10-02-2003, 07:53 AM

Also, if your method=post, you should probably change post_max_size as well.

micxz · 10-02-2003, 01:59 PM

You can add a hidden field to the form like:

<input type="hidden" name="MAX_FILE_SIZE" value="999999999999">

But I don't beleive this will override the php.ini