[SOLVED] php

pizzipie · 07-14-2020, 07:16 PM

I have rarely used reg-ex expressions and I thought I could learn a little bit of the technique now.

I am converting a thunderbird contacts address book to an 'INSERT.sql' input file for SQlite3. Part of this is deleting array elements I don't want from the header array.

Below I am using 'preg_match' to delete elements with index no's 6, 24-35 and 37.
The highlighted code I have 'settled' on (since it works ) seems to be highly 'clutzy'. Appreciate it if someone could show me the "proper" way to do this?

Code:

for($i=0; $i<count($rows); $i++) {           // eliminate space separating words
	$str=$rows[$i];
	$rows[$i]=str_replace(" ", "", $str);
}

foreach($rows[0] as $key => $value) {     // eliminate array elements with index 6, 24-35, 37 from $rows[$index] ;
	//echo $key."...".$value."\n";
	
	if( preg_match('/^6/', $key) || preg_match('/^2[4-9]/', $key) || preg_match('/^3[0-5]/', $key) ||  preg_match('/^3[7]/', $key)) { 
		unset($rows[0][$key]);     

	} // if preg..

} // foreach

michaelk · 07-14-2020, 09:48 PM

The proper way to do a preg_match or a better way to delete an array element?

I did not test your code but unset does automatically re-index the array.

Quote:

eliminate array elements with index 6, 24-35, 37 from $rows[$index]

Looks like these are the absolute index numbers but at least when I exported Thunderbird contacts my CSV file contained 37 columns but indexes are based on 0, so if you say it works...

To delete element with index 6
array_splice($array, 6, 1);

Then to delete elements from index 24-35
array_splice($array, 23, 11);

To delete element 37
array_splice($array, 25, 1);

pizzipie · 07-14-2020, 10:48 PM

Thanks for the reply michaelk!

Quote:

The proper way to do a preg_match or a better way to delete an array element?

I'd like to see the proper way to do a preg_match

I was just wondering if this line -

Code:

if( preg_match('/^6/', $key) || preg_match('/^2[4-9]/', $key) || preg_match('/^3[0-5]/', $key) ||  preg_match('/^3[7]/', $key)) { 

 unset($rows[0][$key]);     

} // if preg..

can be reduced in some elegant way to only one preg_match() instead of four.

Otherwise it does just what I want and the

Code:

$header=array_values($rows[0]); // headers for INSERT

re-orders the elements from 0 to 23. SEE Array's below.

Code:

Array  <======= $rows[0] - elements unset - numerical order 0->36 
(
    [0] => FirstName
    [1] => LastName
    [2] => DisplayName
    [3] => Nickname
    [4] => PrimaryEmail
    [5] => SecondaryEmail
    [7] => WorkPhone      <===========  6 not there which is good
    [8] => HomePhone
    [9] => FaxNumber
    [10] => PagerNumber
    [11] => MobileNumber
    [12] => HomeAddress
    [13] => HomeAddress2
    [14] => HomeCity
    [15] => HomeState
    [16] => HomeZipCode
    [17] => HomeCountry
    [18] => WorkAddress
    [19] => WorkAddress2
    [20] => WorkCity
    [21] => WorkState
    [22] => WorkZipCode
    [23] => WorkCountry
    [36] => Notes          <========= 24-35 not there
                           <========= 37 not there      which is good

Code:

Array  <======= $header  elements unset - numerical order 0->23 which is what I want
(
    [0] => FirstName
    [1] => LastName
    [2] => DisplayName
    [3] => Nickname
    [4] => PrimaryEmail
    [5] => SecondaryEmail
    [6] => WorkPhone
    [7] => HomePhone
    [8] => FaxNumber
    [9] => PagerNumber
    [10] => MobileNumber
    [11] => HomeAddress
    [12] => HomeAddress2
    [13] => HomeCity
    [14] => HomeState
    [15] => HomeZipCode
    [16] => HomeCountry
    [17] => WorkAddress
    [18] => WorkAddress2
    [19] => WorkCity
    [20] => WorkState
    [21] => WorkZipCode
    [22] => WorkCountry
    [23] => Notes

michaelk · 07-15-2020, 04:38 AM

I probably got confused with the different things I was trying... With my version of Thunderbird i.e. 68.9 there isn't a column 37

Code:

Array
(
    [0] => First Name
    [1] => Last Name
    [2] => Display Name
    [3] => Nickname
    [4] => Primary Email
    [5] => Secondary Email
    [6] => Screen Name
    [7] => Work Phone
    [8] => Home Phone
    [9] => Fax Number
    [10] => Pager Number
    [11] => Mobile Number
    [12] => Home Address
    [13] => Home Address 2
    [14] => Home City
    [15] => Home State
    [16] => Home ZipCode
    [17] => Home Country
    [18] => Work Address
    [19] => Work Address 2
    [20] => Work City
    [21] => Work State
    [22] => Work ZipCode
    [23] => Work Country
    [24] => Job Title
    [25] => Department
    [26] => Organization
    [27] => Web Page 1
    [28] => Web Page 2
    [29] => Birth Year
    [30] => Birth Month
    [31] => Birth Day
    [32] => Custom 1
    [33] => Custom 2
    [34] => Custom 3
    [35] => Custom 4
    [36] => Notes
)

michaelk · 07-15-2020, 04:48 AM

Code:

  array_splice($line, 6, 1);
  array_splice($line, 23, 12);

Just saying using array_splice automatically re-indexes the array as desired.

Code:

Array
(
    [0] => First Name
    [1] => Last Name
    [2] => Display Name
    [3] => Nickname
    [4] => Primary Email
    [5] => Secondary Email
    [6] => Work Phone
    [7] => Home Phone
    [8] => Fax Number
    [9] => Pager Number
    [10] => Mobile Number
    [11] => Home Address
    [12] => Home Address 2
    [13] => Home City
    [14] => Home State
    [15] => Home ZipCode
    [16] => Home Country
    [17] => Work Address
    [18] => Work Address 2
    [19] => Work City
    [20] => Work State
    [21] => Work ZipCode
    [22] => Work Country
    [23] => Notes
)

SoftSprocket · 07-15-2020, 01:02 PM

Quote:

Originally Posted by pizzipie

Thanks for the reply michaelk!

I'd like to see the proper way to do a preg_match

I was just wondering if this line -

Code:

if( preg_match('/^6/', $key) || preg_match('/^2[4-9]/', $key) || preg_match('/^3[0-5]/', $key) ||  preg_match('/^3[7]/', $key)) { 

 unset($rows[0][$key]);     

} // if preg..

can be reduced in some elegant way to only one preg_match() instead of four.

Off the top of my head, wouldn't this be the same thing?

Code:

preg_match('/^(6|2[4-9]|3[0-5]|3[7])/', $key)

pizzipie · 07-15-2020, 01:24 PM

Thank you SoftSprocket,

PERFECT. I knew there was a way, I just couldn't put it together properly.

R

boughtonp · 07-16-2020, 08:27 AM

Also "3[0-5]|3[7]" can be simplified to "3[0-57]".