Hi all,

I am new to this, yes I am taking it for school, but I have a question. I am not asking you to do my homework, but I need help with a script.

here is an example of the script

#!/bin/bash

x=10; echo "Variable x = $x"
y=100; echo "Variable y = $y"
read -p "Press enter to continue"

echo "Now calculating x/y"
value1=$((y/x)); t=$value1
echo "the result is $value1";echo "Variable t is set to $t"
read -p "Press enter to continue"

the script will run, but I keep getting command errors, but the script does what it is supposed to. Am I missing something?

Thanks for the help,
Joey

No errors here. What errors do you receive?

it runs but it tells me "command not found"

What is the entire command you are inputting into the therminal?

sh script1.txt

The script will go work, its just throws :command not found: before every echo command, but the echo still goes through

thanks for the help btw

What distro and version are you using and have you opened script1.txt to see if there are any odd characters in the actual file as it exists on your machine?

Hi,

you probably created this file on a windows machine and it still has '\r\n' as newline characters. Run
on your file and see if it gets better.

Maybe sh is not bash. Try
Are there errors, after that command?

I did create the file on a windows computer, but it was just a normal text document, I actually just typed it out in notepad.

I will try to run the above code once I get home. I will let you know how it turns out. Thanks again for all the help

I am running it through Knoppix. Just because that is what the instructor wanted us to use.

Windows plain text files are DIFFERENT than Unix plain text files.

Windows uses a Carriage Return followed by a Newline character, Unix ises just a Newline character.

Also, Linux has no OS or filesystem-level concept of "file extensions". Shell scripts usually are named with no extension or with ".sh" to make it clear to the user at a glance that it's a shell script.

There are also 'dos2unix' and 'unix2dos' commands (i.e. programs) to convert line endings in text files.

the only reason why it was names .txt is because that is what the assignment called for. I did read that most script files are .sh just for ease of scanning and finding script files.