[SOLVED] Need help with my Bash Script

HyperTrey · 02-04-2011, 10:48 AM

Code:

#!/bin/bash

#checks current users folder for hidden file of .xlpr
if [ -e ~/.xlpr ];
then
	#If it exists, then tells the user it has already run
        echo "Setup has already been ran."
else
        #If no, then asks for the username
	echo "Please type the username you wish to print with, followed by [ENTER]:"
	read uname

	echo $uname > ~/.xlpr
fi

That is the code for script named XLPR-Setup. I have then ran chmod 700 XLPR-Setup. However, when I try to run it, it tells me "Bad command or file name". I am attempting to use this on CentOS LiveCD under /home/CentOS.

What am I doing wrong with it?

goossen · 02-04-2011, 10:53 AM

It works OK for me.

druuna · 02-04-2011, 11:12 AM

Hi,

What is the output of the following command: od -c XLPR-Setup | head -5

HyperTrey · 02-04-2011, 11:35 AM

0000000 # ! / b i n / b a s h \r \n i f
0000020 [ - e ~ / . x l p r ] ; \r
0000040 \n t h e n \r \n \t e c h o " S e
0000060 t u p h a s a l r e a d y
0000100 b e e n r a n . " \r \n e l s e

HyperTrey · 02-04-2011, 11:36 AM

Quote:

Originally Posted by goossen

It works OK for me.

is it because I am trying to running it on the LiveCD instead of the full install? and did you just do chmod 700 XLPR-Setup?

druuna · 02-04-2011, 11:45 AM

Hi,

Quote:

Originally Posted by HyperTrey

0000000 # ! / b i n / b a s h \r \n i f
0000020 [ - e ~ / . x l p r ] ; \r
0000040 \n t h e n \r \n \t e c h o " S e
0000060 t u p h a s a l r e a d y
0000100 b e e n r a n . " \r \n e l s e

The bold parts, line terminator/carriage return, show that this is not a regular linux/unix file (would be: \n \n) but a dos file (\r \n), which is also the reason why your script doesn't behave as expected.

How did you create this file?

A fast solution: dos2unix XLPR-Setup it should be fixed now.

Hope this helps.

HyperTrey · 02-04-2011, 12:11 PM

OK, I gotcha ya. I wrote it in windows as that was all I had at the time (NotePad++). So if I write it in a linux environment it will be fine. Is there a windows application that will allow me to write in a linux file? Sometimes I only have windows to write my stuff.

I do apologize, I am a linux novice. I write alot of perl, just not Linux stuff.

druuna · 02-04-2011, 12:20 PM

Hi,

You can use (g)vim. Also available for other OS flavours. Maybe there are other window specific program, but I cannot help you with that one.

Quote:

I do apologize, I am a linux novice.

No need to apologize, we all where novice at one point

If this is solved, can you put up the tag (First post -> Thread Tools).

Acron_0248 · 02-04-2011, 12:24 PM

Also, notepad++ and most windows editors have an option that allows you to convert a file to unix format, can't remember exactly where that option is though :-/

grail · 02-05-2011, 02:33 AM

I now this has already been marked as SOLVED, but I thought I would just point out that using an existing command name as a variable name can prove error prone later on.

Code:

read uname

If you do a man uname you will see what this function does. In the scope of your script I do not see this possibly being an issue, but thought I would just point it out