need help with a fan control script

brain_bashed · 09-05-2007, 03:08 PM

Hello everyone!

I have a thinkpad t43 and i'm trying to run tp-fancontrol to lower the fan speeds cause its just too loud.

On that wiki page it says i have to change a kernel parameter for ibm-acpi.experimental to 1 so in my /etc/sysctrl.conf i added the line

PHP Code:



ibm-acpi.experimental=1

is there a way to check that it's working?

second, when i try to run the script i get syntax errors:

PHP Code:



tp-fancontrol: line 201: syntax error near unexpected token `<'
tp-fancontrol: line 201: `    read X Y1 Y2 Y3 Y4 Y5 Y6 Y7 Y8 Z1 Z2 Z3 JNK < <(echo "$THERMAL") '

these are the lines around the errors..

PHP Code:



197 thermometer() { # output list of temperatures
198 # 8 basic temperatures from ibm-acpi:
199 [[ -r $IBM_ACPI/thermal ]] || { echo "$0: Cannot read $IBM_ACPI/thermal" 2>&1 ; exit 1; }
200 read THERMAL < $IBM_ACPI/thermal
201 read X Y1 Y2 Y3 Y4 Y5 Y6 Y7 Y8 Z1 Z2 Z3 JNK < <(echo "$THERMAL") 
202 [[ "$X" == "temperatures:" ]] || { echo "$0: Bad readout: \"$THERMAL\"" >&2;  exit 1; }
203 echo -n "$Y1 $Y2 $Y3 $Y4 $Y5 $Y6 $Y7 $Y8 ";

i'm running ubuntu 6.06 with kernel version 2.6.15-29-386. I have no bash coding experience so i'm completely lost, if any of you guys could help i'd really appreciate it! thanks!

jozyba · 09-05-2007, 03:59 PM

Shouldn't line 200 be:

Code:

read THERMAL < $IBM_ACPI/thermal

$IBM_ACPI looks like the path to a directory whereas you want to read the contents of the file that is in that directory.

brain_bashed · 09-05-2007, 04:06 PM

Yes, you are right. i deleted that when i was hacking away at the script trying to make it work. I edited my post above to include: /thermal

thanks for picking that up! I still get the same syntax errors though..

jozyba · 09-05-2007, 04:36 PM

I did a mock-up of the few lines of code that you gave us and it works fine in a bash shell.

Then I saw that you're using Ubuntu. I seem to remember that they recently changed the symbolic link of /bin/sh from bash to dash. Your script would work with bash but not with dash.

Does the first line of your script say '#! /bin/sh' by any chance? If so, try changing it to '#! /bin/bash'

brain_bashed · 09-05-2007, 04:45 PM

Quote:

Originally Posted by jozyba

Does the first line of your script say '#! /bin/sh' by any chance? If so, try changing it to '#! /bin/bash'

Nope, it says #!/bin/bash