[SOLVED] Multiple Input in bash

pan64 · 12-18-2016, 09:17 AM

Quote:

Originally Posted by MadeInGermany

The main problem is that the shell does not substitute $var in a 'string'

I'm sorry, I do not understand what does it mean?
grail made a mistake, $var1 should be $opt I think, but otherwise it should work.

MadeInGermany · 12-19-2016, 07:50 AM

I did see the latest post in time.
My answer addressed the previous posts that have one 'string'.
Of course one "string" is also okay because the variables in it are substituted.

keefaz · 12-19-2016, 10:14 AM

I would suggest another approach:
- Store each response value in variables
- Write values to configuration file at the end of prompted questions

I think it's not efficient to read and write the whole configuration file at each question...

TashiDuks · 12-20-2016, 08:22 PM

Quote:

Originally Posted by MadeInGermany

The main problem is that the shell does not substitute $var in a 'string'
Split into two strings so it becomes a concatenation of 'part1' "$var" 'part2'!
The shell then does the substution and removes all the quotes, so sed sees one string.

Code:

for PORTOPTN in ftp http rdp smb
do
    read -p "Do you want to enable ${PORTOPTN} port? [y/N]" responsePORTS
    case "$responsePORTS" in
    y|Y )
        sudo sed -i 's/^ *\('"$PORTOPTN"'\.enabled: *\)[^,]*/\1true/' mymy.conf
    ;;
    n|N )
        sudo sed -i 's/^ *\('"$PORTOPTN"'\.enabled: *\)[^,]*/\1false/' mymy.conf
    ;;
    * )
        echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m "
    ;;
    esac
done

Comment on the previous post: the break ends the loop, a continue would continue the loop.

Hi,

I tried with above code in my machine and found out that it does not change any values in the configuration file i.e. mymy.conf

TashiDuks · 12-20-2016, 09:11 PM

Quote:

Originally Posted by grail

Well I would make a search for the port option and then use s/// to change just the true or false.
Something like:

Code:

#Enable/Disable PORTS [Ports]
for PORTOPTN in ftp http smb mysql ssh rdp sip snmp ntp tftp telnet mssql vnc rdp;
do
  read -p "Do you want to enable ${PORTOPTN^^} Port? [y/N]" responsePORTS
  case "${responsePORTS^}" in
    Y ) opt='true';;
    N ) opt='false';;
    * )  echo -e "\033[38;5;1mWrong option used. Operation terminated!!!\033[0m "
         break;;
  esac
  sudo sed -i "/$PORTOPTN/s/:.*/: $opt/" mymy.conf
done

Edit: Fixed variable as per pan64's catch

The sed line which you have mentioned seems to be looking for ftp.*, http.*, ...

Can't it be made for specific like $PORTOPTN.enabled only rather than $PORTOPTN.* ?

The configuration file also contains some other lines like

"ftp.enabled": true,
"ftp.port": 21,
"http.enabled": false,
"http.port": 80
..... so on

grail · 12-20-2016, 11:09 PM

Yes you can add to the first portion if you need to make it more verbose due to overlaps

TashiDuks · 12-20-2016, 11:18 PM

Quote:

Originally Posted by grail

Yes you can add to the first portion if you need to make it more verbose due to overlaps

I did with following:

Code:

sudo sed -i "/$PORTOPTN/s/:.enabled/: $opt/" mymy.conf

the result still the same. Sorry If I did stupid..

grail · 12-21-2016, 12:59 AM

The first part of the sed I have shown is the part that searches for the line we want to change, so that is where you need to add the search item:

Code:

sudo sed -i "/$PORTOPTN.enabled/s/:.*/: $opt/" mymy.conf

This would search for any line containing say 'ftp.enabled', then the s/// part remove the ':' and everything after it and replaces with our new, perhaps same, value.

As mentioned by keefaz, this process is also inefficient as it calls sed multiple times on the same file. So an alternate could be that you use the while loop to create a temporary file
which sed could then use to make the necessary changes

TashiDuks · 12-21-2016, 02:29 AM

Quote:

Originally Posted by grail

The first part of the sed I have shown is the part that searches for the line we want to change, so that is where you need to add the search item:

Code:

sudo sed -i "/$PORTOPTN.enabled/s/:.*/: $opt/" mymy.conf

This would search for any line containing say 'ftp.enabled', then the s/// part remove the ':' and everything after it and replaces with our new, perhaps same, value.

As mentioned by keefaz, this process is also inefficient as it calls sed multiple times on the same file. So an alternate could be that you use the while loop to create a temporary file
which sed could then use to make the necessary changes

Thanks for the help. I have finally managed to fix it. I used following line:

Code:

sudo sed -i 's/\("'"$PORTOPTN"'\.enabled": *\)[^,]*/\1'"$opt"'/' mymy.conf

Cheers

grail · 12-21-2016, 02:57 AM

Is that because my example is not working? Your proliferation of quotes is not very maintainable or obvious, plus you will still have the same possible issue that you now have a command (true/false)
stored in your variable.

pan64 · 12-21-2016, 09:35 AM

Code:

sudo sed -i "s/\($PORTOPTN\.enabled\": *\)[^,]*/\1$opt/" mymy.conf
# is much more readable than this:
sudo sed -i 's/\("'"$PORTOPTN"'\.enabled": *\)[^,]*/\1'"$opt"'/' mymy.conf

# the solution by grail is much more elegant
sudo sed -i "/$PORTOPTN.enabled/s/:.*/: $opt/" mymy.conf

# the idea from keefaz is much more efficient

# and finally you can store the settings in an associative array (not only the enabled ones, bot ports and others too) and finally you will be able to generate the result without sed or with one single sed.

TashiDuks · 12-22-2016, 02:40 AM

Quote:

Originally Posted by grail

Is that because my example is not working? Your proliferation of quotes is not very maintainable or obvious, plus you will still have the same possible issue that you now have a command (true/false)
stored in your variable.

Your is also working fine.

Thanks