Loop in Shell Programming

ali2011 · 07-17-2012, 01:41 PM

I have the following script that reads a file "sort_2" that contains one column of IPs. For every loop, it tries to ftp an IP to get the a file named "vsys.tar".

I think I'm doing some error in the looping as I receive this error "syntax error: unexpected end of file".

Code:

#!/bin/bash

file=sort_2
while read -a num; do
	
	HOST=${num}
	USER=user_name
	PASS=user_pass

	ftp -inv $HOST << EOF

	user $USER $PASS
	cd test
	get vsys.tar
	bye
	EOF
done < "$file"
exit 0

pan64 · 07-17-2012, 01:44 PM

the line containing the second EOF should not contain anything else (spaces or tabs before or after that 3 letters) just the keyword EOF

ali2011 · 07-17-2012, 04:24 PM

Thanks pan64 for your quick and accurate response. Further, I'm looking to save the result of every ftp session to identical file. for example, the first IP-1 to a file named IP1.ftp and so on; any idea regarding this?

tonyfreeman · 07-17-2012, 08:11 PM

Increment a variable as the while loop progresses:

Code:

#!/bin/bash

FILE="sort_2"

USER="user_name"
PASS="user_pass"

a=0

if [[ -s "$FILE" ]]
then
	while read -a HOST
	do
		ftp -inv $HOST << EOF
			user $USER $PASS
			cd test
			get vsys.tar
			bye
EOF
		a=$(expr $a + 1)
		mv -vf vsys.tar ${HOST}${a}.ftp
	done < "$FILE"
else
	echo "Sorry.  $FILE does not exist"
	echo "Exiting ..."
	exit 1
fi

bigearsbilly · 07-18-2012, 02:07 AM

I would use this:

.netrc

Reuti · 07-18-2012, 06:07 AM

To indent the EOF and make it more readable, you can use:

Code:

command <<-EOF

This will strip off any leading TAB characters (not only for the EOF, but for all lines of the here document).

ali2011 · 07-18-2012, 10:00 AM

Thank you all for your perfect comments. However, tonyfreeman, I think I didn't clarify my question enough so you got it on the other side. The file I'm interested to save per IP is not the transferred file itself "vsys.tar", but the ftp report while getting this file (i.e., the speed and other info while the ftp transmission is taken place).

e.g., the following info that I need to be stored in a file named "133.101.33.4.ftp"

Code:

Connected to 133.101.33.4 (133.101.33.4).
220 (vsFTPd 2.0.5)
331 Please specify the password.
230 Login successful.
250 Directory successfully changed.
local: TEST.mp3 remote: TEST.mp3
227 Entering Passive Mode (133,101,33,4,45,211).
150 Opening BINARY mode data connection for TEST.mp3 (5492819 bytes).
WARNING! 22955 bare linefeeds received in ASCII mode
File may not have transferred correctly.
226 File send OK.
5492819 bytes received in 1.21 secs (4555.78 Kbytes/sec)
221 Goodbye.

ali2011 · 07-18-2012, 10:09 AM

While trying the code above, I encounter another problem, which is that the ftp for some reason doesn't succeed for some IPs in the loop. How can I add another loop for only failed IPs whose stored reports (i.e., IP.ftp) don't have the speed info (i.e., in particular the WORD "Kbytes/sec")?

I look to make the failed IPs to be repeated 3 times after fishing the sotr_2, and if failure again, just go to the new 3 attempts of next failed IP.

Reuti · 07-18-2012, 10:17 AM

You can write the output of the ftp command to a file:

Code:

ftp -inv $HOST <<-EOF >$HOST.ftp