Javascript error

Linh · 09-26-2003, 11:43 AM

The alert message never activated when at least one of the ip field is blank. There was a message on the bottom left hand side that sid "error on page"

==================================

Code:

<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script type="text/javascript">
<!--

function check_for_blank_in_ip()
{
   if ((ip1 <>""  && ip2 <>""  && ip3 <>""  && ip4 ==""))  || 
       (ip1 <>""  && ip2 <>""  && ip3 ==""  && ip4 <>"" )  || 
       (ip1 <>""  && ip2 ==""  && ip3 <>""  && ip4 <>"" )  || 
       (ip1 ==""  && ip2 <>""  && ip3 <>""  && ip4 <>"" )  ||
       (ip1 <>""  && ip2 <>""  && ip3 ==""  && ip4 =="" )  ||
       (ip1 ==""  && ip2 <>""  && ip3 <>""  && ip4 =="" ))
     alert ("All four IP values must be filled in"); 
}
    
// -->
</script>
</head>
<body>
<form name="form1" method="post" action="">
   <input type=text size=3 maxlength=3 name=ip1 onblur='check_for_blank_in_ip();'><b>.</b>
   <input type=text size=3 maxlength=3 name=ip2 onblur='check_for_blank_in_ip();'><b>.</b>
   <input type=text size=3 maxlength=3 name=ip3 onblur='check_for_blank_in_ip();'><b>.</b>
   <input type=text size=3 maxlength=3 name=ip4 onblur='check_for_blank_in_ip();'>&nbsp;</td>
</form>

</body>
</html>

jpbarto · 09-26-2003, 12:09 PM

well first it might be cleaner to say

if (ip1 == "" || ip2 == "" || ip3 == "" || ip4 == "")
alert ('fill in your IP');

second I would try an alert before the 'if' to see what values your ip1-4 does have ... (make sure you're referencing what you think your referencing)

alert ('ip1 is '+ip1+' and ip2 is '+ip2);
alert ('ip3 is '+ip3+' and ip4 is '+ip4);

if (ip1 == "" ...

also I think in Java (maybe <> works too ... never tested) that 'not equals' is !=

hope that helps,
jpbarto

svf · 09-29-2003, 03:52 AM

The 'onblur' stuff does not work on my Mozilla Firebird browser (I think Mozilla based browsers might not support 'onblur'). You might want to make your code browser independent. Follow the JS 1.3 standards, they are supported by both IE5, IE6 and Netscape/Mozilla.

I get JS error on IE as soon as the page loads. I think the problem is with the '<>'. Use '!=' instead.

You might want to use jpbarto's logic. i.e instead of checking every combination for an empty field, just check if any one of the fields are empty.

Let us know what happens.

svf

Linh · 09-29-2003, 09:22 AM

Hi jpbarto and svf. Thank you for your suggestion