[SOLVED] issue with variable in bash script

angel115 · 08-21-2006, 02:01 PM

Hi there,

I've the following issue with one of my script.
Here is the script:

Code:

#! /bin/bash

for filename in $( cat /path_of_the_file/list_a ); do
echo FileVersion /path_of_the_file/${filename}.ver.tmp 
done
exit

the file list_a look like this:

Code:

myfile1.dll
myfile2.dll
ect...

but when i execute my script in get the following output:

Code:

./myscript
.ver.tmpion /path_of_the_file/myfile1.dll

But if i type the command line echo FileVersion /path_of_the_file/myfile1.dll.ver.tmp in the command line with out using any variable it work fine and i get the following output:

Code:

echo FileVersion /path_of_the_file/myfile1.dll.ver.tmp
FileVersion /path_of_the_file/myfile1.dll.ver.tmp

I don't understand why the expression .var.tmp is displayed at the beginning of the line.

I have try to escape the dot like this:

Code:

#! /bin/bash

for filename in $( cat /path_of_the_file/list_a ); do
echo FileVersion /path_of_the_file/${filename}\.ver\.tmp 
done
exit

But it's the same issue.
Any idea???

david_ross · 08-21-2006, 02:07 PM

It sounds more like bash is wraping the output - does it look almost right with:
echo FileVersion /${filename}.ver.tmp

jonaskoelker · 08-21-2006, 02:09 PM

It looks very much like list_a contains the $'\r' (Carriage Return) character, which "rewinds" to the beginning of the line.

The reason it contains that character is that it's written for MS-DOS, on which newlines are represented by $'\r\n', whereas on unix they're represented by $'\n'.

To get rid of them, do this

Code:

$ sed -i -e 's/\r$//g' /path/file

If you want to see them, try

Code:

$ tr '\r' '#' < file

Also, try playing around with ascii(1). Also, understand what the magic variable IFS does.

druuna · 08-21-2006, 02:11 PM

Hi,

The script (first example) works fine, it's the infile (list_a) that is the problem.

It's probably not a normal text file, but a dos/windows file:

$ file list_a
list_a: ASCII text, with CRLF line terminators

Instead of:
$ file list_a
list_a: ASCII text

I use vi to change file from one type to another (there are other ways as well). After loading file in vi do the following:
<esc>
:set ff=unix
:wq

Use the file command to see if it worked.

angel115 · 08-21-2006, 02:42 PM

Quote:

Originally Posted by jonaskoelker

It looks very much like list_a contains the $'\r' (Carriage Return) character, which "rewinds" to the beginning of the line.

The reason it contains that character is that it's written for MS-DOS, on which newlines are represented by $'\r\n', whereas on unix they're represented by $'\n'.

To get rid of them, do this

Code:

$ sed -i -e 's/\r$//g' /path/file

If you want to see them, try

Code:

$ tr '\r' '#' < file

Also, try playing around with ascii(1). Also, understand what the magic variable IFS does.

Thanks jonaskoelker,

You are the one, i used you sed script to clean my source file and now every thing is working fine.

Thanks again;
Angel115.