[SOLVED] if then else twice and if not found then run a command

bmxakias · 11-19-2019, 08:31 PM

Hello

I have this code:

Code:

if [[ $(find /path/to/folder1 -type f -not -path "*configs*" -size -800k 2>/dev/null) ]]; then
    echo "[[Warning]]: The files size is under 800 Kilobytes"
if [[ $(find /path/to/another/folder -type f \( ! -iname "123.file*" \) -not -path "*logs*" -size -40k 2>/dev/null) ]]; then
    echo "[[Warning]]: The file size is under 40 Kilobytes"
fi
else

Run a command here

fi

The target is:

Get an echo if a file under size found in any of the above paths or get both echo if a file under size found on both paths and run the command at the end only if not files under size found at any of the above two paths.

Both checks are tested and working but it seems that i have the if or else statements in wrong order ?

Thank you !

Firerat · 11-19-2019, 09:50 PM

find is not great for such tests

it will exit 0 if it finds a file or not
it will only exit non-zero if something went "wrong" ( like incorrect arguments )

I'm not 100% certain I have the logic right

both have to find things to not run the command

Code:

#!/bin/bash

error_in_find () {
echo "something went very wrong with find" 1>&2
exit 1
}


_find1 () {
find /path/to/folder1 \
    -type f \
  ! -path "*configs*" \
    -size -800k \
    -printf "[[Warning]]: %f size is under 800 Kilobytes\n" \
    || error_in_find
}
_find2 () {
find /path/to/another/folder \
    -type f \
    \( ! -iname "123.file*" \) \
  ! -path "*logs*" \
    -size -40k \
    -printf "[[Warning]]: %f size is under 40 Kilobytes\n" \
    || error_in_find
}

dontrun=y
grep --colour=no "." < <(_find1) || unset dontrun
grep --colour=no "." < <(_find2) || unset dontrun

[[ $dontrun ]] || run_your_command



#

testing to exit code of grep, "." is any char. so if the finds printed anything grep returns 0
if the finds don't print anything, grep returns 1

when grep finds something, we unset the dontrun var

when grep does not find something, we unset the dontrun var

so, both have to print ( find ) something to not run
if any of them fail to print ( find ) something the run_your_command is run.

bmxakias · 11-19-2019, 10:31 PM

Quote:

find is not great for such tests

I used that as it works with no issues when i use the two commands separate...

Quote:

both have to find things to not run the command

No. If found one or both the command should not run. The command will only run only if no small files found on both paths.

Firerat · 11-19-2019, 11:26 PM

Quote:

Originally Posted by bmxakias

I used that as it works with no issues when i use the two commands separate...

ahh, yes you are right
$(..) is expanding
[[ ]] is only checking if null or not

Quote:

Originally Posted by bmxakias

No. If found one or both the command should not run. The command will only run only if no small files found on both paths.

if either of the finds print, then do not run

Code:

#dontrun=y
grep --colour=no "." < <(_find1) && dontrun=y
grep --colour=no "." < <(_find2) && dontrun=y

[[ $dontrun ]] || run_your_command
# or
# [[   $dontrun == y ]] || run_your_command
# [[ ! $dontrun == y ]] && run_your_command
# [[   $dontrun != y ]] && run_your_command
#
#

or

Code:

run=y
grep --colour=no "." < <(_find1) && run=n
grep --colour=no "." < <(_find2) && run=n

[[ $run == n ]] && run_your_command

[edit]
this is wrong

Code:

unset count
if [[ $(find /path/to/folder1 -type f -not -path "*configs*" -size -800k 2>/dev/null) ]]
then
    echo "[[Warning]]: The files size is under 800 Kilobytes"
    ((count++))
fi
if [[ $(find /path/to/another/folder -type f \( ! -iname "123.file*" \) -not -path "*logs*" -size -40k 2>/dev/null) ]]
then
    echo "[[Warning]]: The file size is under 40 Kilobytes"
    ((count++))
fi

if [[ $count -lt 2 ]]
then
    run_command
fi


#

Code:

unset count
if [[ $(find /path/to/folder1 -type f -not -path "*configs*" -size -800k 2>/dev/null) ]]
then
    echo "[[Warning]]: The files size is under 800 Kilobytes"
else
    ((count++))
fi
if [[ $(find /path/to/another/folder -type f \( ! -iname "123.file*" \) -not -path "*logs*" -size -40k 2>/dev/null) ]]
then
    echo "[[Warning]]: The file size is under 40 Kilobytes"
else
    ((count++))
fi

if [[ $count == 2 ]]
then
    run_command
fi


#

bmxakias · 11-20-2019, 12:36 AM

Works great !!!

Thank you

MadeInGermany · 11-20-2019, 04:41 AM

Alternatively you can have result variables:

Code:

res1=$(find /path/to/folder1 -name "*configs*" -prune -o -type f -size -800k -print 2>/dev/null)
res2=$(find /path/to/another/folder -name "*logs*" -prune -o -type \! -iname "123.file*" -size -40k -print 2>/dev/null)
if [[ -n $res1 ]]; then
  echo "[[Warning]]: The files size is under 800 Kilobytes ($res1)"
fi
if [[ -n $res2 ]]; then
  echo "[[Warning]]: The file size is under 40 Kilobytes ($res2)"
fi
if [[ -z $res1$res2 ]]; then
  : run command
fi

The finds in this example really prune the unwanted pathes, that's faster.

bmxakias · 11-20-2019, 06:39 AM

I will check it. Thank you

Is it good to use the 2>/dev/null or not needed at all ?

MadeInGermany · 11-20-2019, 06:58 AM

The 2>/dev/null can suppress a "permission denied". Normally not needed if run as root or the owner of the files/folders.

BTW in the case of -prune you need the explicit -print in order to not implicitly print the pruned folders.

bmxakias · 11-20-2019, 07:16 AM

Ok thank you !