How to check variables in a FOR loop?

richikiki · 07-06-2006, 08:32 AM

Hello everybody,
I have this code for checking external environment variables:

Code:

...
...
   if [[ ! -d $EXTVARONE  || "$EXTVARONE" == '' ]]
   then
        cat /dev/null | mailx -s "ERROR:$SCRIPTNAME No Env var EXTVARONE" $MAILTO
        exit 1
   fi

   if [[ ! -d $EXTVARTWO  || "$EXTVARTWO" == '' ]]
   then
        cat /dev/null | mailx -s "ERROR:$SCRIPTNAME No Env var EXTVARTWO" $MAILTO
        exit 1
   fi
...
...

I try to put them in a FOR in order to review all the externals variable which uses my script.

I try something like:

Code:

ciclo='$EXTVARONE $EXTVARTWO ...ETC'
for i in $ciclo;
do
      # Cheching if the directory exist & variable isn't NULL
      if [[ ! -d $i  || "$i" == '' ]]
      then
          cat /dev/null | mailx -s "ERROR:$SCRIPTNAME No Env var \     
          EXTVARTWO" $MAILTO
          exit 1
      fi
done

I'm doing something wrong because I want $i to be $EXTVARONE $EXTVARTWO ...ETC on each loop and compare the value of each variable. I'm sure that it is a matter of how I declare the variable but until now I have been playing without success on this way.

Does anyone knows how to declare or assign my variable in the loop FOR?.
REGARDS

richikiki · 07-06-2006, 08:36 AM

Sorry,
I forgot to mention it is on Kron Shell.
#!/usr/bin/ksh

bigearsbilly · 07-06-2006, 09:20 AM

if you use:

Code:

#!/usr/bin/ksh -eu

any unset variables will cause an error message and exit.
so you could do:

Code:

#!/bin/ksh -eu

ciclo='$EXTVARONE $EXTVARTWO'
for i in $ciclo;
do
    eval : $i
done

Code:

billym.primadtpdev>rich.sh
rich.sh[6]: EXTVARONE: parameter not set

richikiki · 07-06-2006, 10:14 AM

Thanks bigearsbilly,

Your tip is just AMAZING!!!.
Now I need to find how to log the information into a log file in order to track what was wrong.

Because:
EVAL
3) Errors cause a script that contains them to abort.

Any idea?

bigearsbilly · 07-06-2006, 10:24 AM

simplest is

> blah.log 2>&1 script.sh
2>&1 script.sh | tee blah.log

or put:

Code:

#!/bin/ksh -eu
exec > out.log 2>&1

at the top of the script

or execute it as a batch job and get a mail posted to you
is my preference

richikiki · 07-06-2006, 12:58 PM

Thanks bigearsbilly,

In fact, I have both implement sending a mail and log in a file the trace of the execution.

I want to see the the information on the cosole and send also this information to the logfile.

After checking the logfile and directory I did this,but it does not work

:

exec 2>&1 | tee -a $LOGDIR/$LOGFILE

$LOGDIR -> Directory for the logfile
$LOGFILE -> logfile to add info

? ?

bigearsbilly · 07-10-2006, 03:57 AM

no, exec | tee
won't work unfortunately.
you'll have to run the script to a logfile
script | tee -a log

a way of doing it is to wrap in a function,
like

Code:

main()
{
   # script in here
}
time main | tee logfile

but it has pitfalls too.
I tend to Keep It Simple and just batch it, cron it or tee it.
You can always simply tail -f the log file.